[dpdk-dev] mk: disable new gcc truncation flag

  disable truncation check to ignore below warning
dpdk/x86_64-native-linuxapp-gcc-default/build/lib/librte_eal/linuxapp/kni/igb_main.c:2476:30: error: '%d' directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=]

Signed-off-by: Nirmoy Das <ndas@suse.de>
---
 lib/librte_eal/linuxapp/kni/Makefile | 3 +++
 1 file changed, 3 insertions(+)
  

On 06/02/2017 05:31 PM, Nirmoy Das wrote:
> disable truncation check to ignore below warning
> dpdk/x86_64-native-linuxapp-gcc-default/build/lib/librte_eal/linuxapp/kni/igb_main.c:2476:30: error: '%d' directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=]
> 
> Signed-off-by: Nirmoy Das <ndas@suse.de>
> ---

I haven't check the code but is this a bogus warning or a real one? If
it's bogus then could you explain why in the commit message so we do not
bring it back in the future? If it's a real problem, then perhaps worth
fixing it instead of masking it?
  

On 06/02/2017 07:38 PM, Markos Chandras wrote:
> On 06/02/2017 05:31 PM, Nirmoy Das wrote:
>> disable truncation check to ignore below warning
>> dpdk/x86_64-native-linuxapp-gcc-default/build/lib/librte_eal/linuxapp/kni/igb_main.c:2476:30: error: '%d' directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=]
>>
>> Signed-off-by: Nirmoy Das <ndas@suse.de>
>> ---
> 
> I haven't check the code but is this a bogus warning or a real one? If
> it's bogus then could you explain why in the commit message so we do not
> bring it back in the future? If it's a real problem, then perhaps worth
> fixing it instead of masking it?
> 

Actually this should have already been fixed in the series posted in
http://dpdk.org/ml/archives/dev/2017-May/065261.html
  

On 06/12/2017 04:35 PM, Markos Chandras wrote:
> On 06/02/2017 07:38 PM, Markos Chandras wrote:
>> On 06/02/2017 05:31 PM, Nirmoy Das wrote:
>>> disable truncation check to ignore below warning
>>> dpdk/x86_64-native-linuxapp-gcc-default/build/lib/librte_eal/linuxapp/kni/igb_main.c:2476:30: error: '%d' directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=]
>>>
>>> Signed-off-by: Nirmoy Das <ndas@suse.de>
>>> ---
>> I haven't check the code but is this a bogus warning or a real one? If
>> it's bogus then could you explain why in the commit message so we do not
>> bring it back in the future? If it's a real problem, then perhaps worth
>> fixing it instead of masking it?
>>
> Actually this should have already been fixed in the series posted in
> http://dpdk.org/ml/archives/dev/2017-May/065261.html
I see the issue in master with CONFIG_RTE_KNI_KMOD_ETHTOOL=y
  

On 06/13/2017 12:18 PM, Nirmoy Das wrote:
> 
> 
> On 06/12/2017 04:35 PM, Markos Chandras wrote:
>> On 06/02/2017 07:38 PM, Markos Chandras wrote:
>>> On 06/02/2017 05:31 PM, Nirmoy Das wrote:
>>>> disable truncation check to ignore below warning
>>>> dpdk/x86_64-native-linuxapp-gcc-default/build/lib/librte_eal/linuxapp/kni/igb_main.c:2476:30: error: '%d' directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=]
>>>>
>>>> Signed-off-by: Nirmoy Das <ndas@suse.de>
>>>> ---
>>> I haven't check the code but is this a bogus warning or a real one? If
>>> it's bogus then could you explain why in the commit message so we do not
>>> bring it back in the future? If it's a real problem, then perhaps worth
>>> fixing it instead of masking it?
>>>
>> Actually this should have already been fixed in the series posted in
>> http://dpdk.org/ml/archives/dev/2017-May/065261.html
> I see the issue in master with CONFIG_RTE_KNI_KMOD_ETHTOOL=y
> 

Yeah I think you are right. This doesn't seem to have been fixed yet. In
the end, I think your patch is good so:

Reviewed-by: Markos Chandras <mchandras@suse.de>