From patchwork Tue Jun 13 16:42:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 25300 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C03B47CB0; Tue, 13 Jun 2017 18:42:37 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A408D568A; Tue, 13 Jun 2017 18:42:28 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 13 Jun 2017 09:42:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.39,338,1493708400"; d="scan'208"; a="1140846287" Received: from silpixa00372839.ir.intel.com (HELO silpixa00372839.ger.corp.intel.com) ([10.237.222.154]) by orsmga001.jf.intel.com with ESMTP; 13 Jun 2017 09:42:18 -0700 From: Ferruh Yigit To: Adrien Mazarguil , Nelio Laranjeiro Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org Date: Tue, 13 Jun 2017 17:42:11 +0100 Message-Id: <20170613164212.42374-4-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170613164212.42374-1-ferruh.yigit@intel.com> References: <20170613164212.42374-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/5] net/mlx5: fix build with gcc 7.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" build error: .../dpdk/drivers/net/mlx5/mlx5_fdir.c: In function ‘fdir_filter_to_flow_desc’: .../dpdk/drivers/net/mlx5/mlx5_fdir.c:146:18: error: this statement may fall through [-Werror=implicit-fallthrough=] desc->dst_port = fdir_filter->input.flow.udp4_flow.dst_port; ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../dpdk/drivers/net/mlx5/mlx5_fdir.c:147:2: note: here case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER: ^~~~ Fixed by adding fallthrough comment to the code. Fixes: 76f5c99e6840 ("mlx5: support flow director") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_fdir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_fdir.c b/drivers/net/mlx5/mlx5_fdir.c index 1cff41bab..c8d47489f 100644 --- a/drivers/net/mlx5/mlx5_fdir.c +++ b/drivers/net/mlx5/mlx5_fdir.c @@ -144,6 +144,7 @@ fdir_filter_to_flow_desc(const struct rte_eth_fdir_filter *fdir_filter, case RTE_ETH_FLOW_NONFRAG_IPV4_TCP: desc->src_port = fdir_filter->input.flow.udp4_flow.src_port; desc->dst_port = fdir_filter->input.flow.udp4_flow.dst_port; + /* fallthrough */ case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER: desc->src_ip[0] = fdir_filter->input.flow.ip4_flow.src_ip; desc->dst_ip[0] = fdir_filter->input.flow.ip4_flow.dst_ip;