From patchwork Tue Jun 20 05:24:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 25443 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 8C8D72C72; Tue, 20 Jun 2017 07:25:20 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10076.outbound.protection.outlook.com [40.107.1.76]) by dpdk.org (Postfix) with ESMTP id 2E1ED374; Tue, 20 Jun 2017 07:25:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MWupGvWzGwLcKXi0sAqbpnHuFSCCZRJexgOvvG9Ae+4=; b=jC/rZL6mVLzaoQYysF/aMPHap8LxPtOsfDELnWtnFy+Vce95VQlTsY6MQIqOVE0V2zmB5LX9ZMUpqby4qH5VCbbPqeClN/ANPiKzfA4FpYHEH6Dj7y5SVvc74TrgT7/OZA94tSMxlBTJD3Eun4ftzafitY1UGCvJwVLMhziz0BE= Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=none action=none header.from=mellanox.com; Received: from mellanox.com (82.166.227.17) by HE1PR05MB1516.eurprd05.prod.outlook.com (2a01:111:e400:59ab::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Tue, 20 Jun 2017 05:25:13 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 20 Jun 2017 08:24:47 +0300 Message-Id: <20170620052447.31846-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: AM5PR0402CA0011.eurprd04.prod.outlook.com (2603:10a6:203:90::21) To HE1PR05MB1516.eurprd05.prod.outlook.com (2a01:111:e400:59ab::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 903ac254-98e2-4072-0703-08d4b79cbb03 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:HE1PR05MB1516; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1516; 3:46yltkIuFTguhFa4AISaon0SV+8mrn/2qB73rfBMdcogNRu4HB5hx+fpq0J7GijB3FrgurM9M4LY9ABrT04wO1Nma4Fvi/kZMUeXMGkS11OHqzlQGAN4EKGFrVFc8yjHOLH5VEY63YmsDojPLUS+xpIzAW7ZAhaGLnNrdZVTxKSJOQBHggoD87ZFpfw0kJA6WQCaJo9gEKOXF+X8FehNB539K6umanNep9l2/lvXs2PWFw3ZDlznZlXNg++oZhWAnn3bUbHFd2koaa3aMv88EbhjDS5av38qPL1FVtUp6y3+bXU7eHRISejco694DNSqAdpqmMcUnjbsYeW9c2UikB603zxAjCDNrRUpI4u0ZGo=; 25:oGLVVWUEG6qigDZyroAFn7dLXgz4Ea5slbYLqIjcj2xWaT324EwCiCS4QASm1y4nqQ6+8EJ9visPD0IS1HD6vn9DK3v5YjQ07GvFoj05DkZ9kA35KFDJsuOTFREAllYg7ZcdRSCefy3vJ5JkBKjKbuUrCc11hjVZd6ggtvUQBG7l392aruIm1Tu51t5cQW4KPTkMN2suCaeBy929mrVHLVjnhJ6aZWP/AKUMk1XA/VDBdtwSWuaxjwFb+tNbla72RjAi1r26h9ju2JHFL92xxq8mTNum0dxZyfwHoOhH9k776TI/blDHrPcW60u6Jtv2dy9Aig6Nlam2416JHKoqOZi4WLfpzw98dg4PvNWcHuPlCL6G2WaFMZaXfYzwQHwWKei25OVRI5By7e46iq7rJAhxJh6RdnXw7wpjXA1bnQE+uFGdMSKJBtWEOr1Az5P/z8H5nbMkb9kJJa0A/fvgKOWX1zoJ8p/VZBbwpSU+4g0= X-MS-TrafficTypeDiagnostic: HE1PR05MB1516: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1516; 31:mjyhKsLlz372LP5di6qieWVwYH3KPFILKxYKu/LUb7CE5tYW7KGgtb+6JgTEzYhWEFCT1LogWZfTwZSxQ3w4W5X+yrZ+IaDLBjnElKVdqqgbAQqu1aYYkbDq2Eagy77sql1ExC5NPS8dy0ElJ3vu6ZvYiVeaxzZ9xIPNpdlT8/KXEfuNPXDY7ve9c+elB/nxhcdKRNmLdoVbKIC21JfuCICsacSA5lFUFoSPIiuOd2KS0YDjpQEKmkb4HiUtfvBH; 20:/yhJvBsfRLHdNZCi+j/ezz+Jdu8X9i02Y0pcfdm6lZEEKJl1+cGXCMYcwpbCjcJZ6XDqRyuOSbXFQP8lrmEPQ4s9FcdtH+08qtAcD1HS2O0QoPw0GibPQBPcGKUfeT4jeVz/vb9DfNVPwnFMVZkSJVJO535+kmCov48bKSlzsriURaYRWPDK3HVhiDATzRSbDlSdzLJQwMvQSIROqnNaVbHDKxn/tlfeDGoZrRESb0LnbrWdoizoy8KT4VcZNlBoB0PRlBis4MQysD3q3VXv1jJgdB1VqfWnduyegffBSjHQM+CIkWgv/uQ7xImjGKqHxhlCMOX1bxv4vxFaT0iht5PG9hjvgv4bundsjRIQjJ12p8OGWalG2t99cbHrJ0lobnFXZeT3YZNC/rXHNr0/4Dl0uh6c5ob1kn44LRajxEnACe1Fy4fRIQItj+mABcDaVWqDMcTFtL6W4x9EuV9snFuDiQpRlw/tQApKmx6G9w1wEuydvlfyC5Z8SvQ5bTeZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR05MB1516; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR05MB1516; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB1516; 4:mhHucHBWliBp/bC03j4bSPwChr3FPogTJwVS7hDZU/?= eZOuL2N8NU026Fc0nEbkZnAVdGDbcQ8sPyTGPqO8fiPpw+MA1gFM/G4pV64uXCLOgHb8Sz2QXR8geNj73UF5a7YhpBQzSIKlaX8+HCwpIxzi6hjVmm23hJr0Yfnt/7wsEhYBqbQ504dXBNO6BDF5wz739rnocT0A+QU43NybvwCXlxOxToka3phy+ro8ajb04ry1LdoDr7dEC/PXuHs0f6dRvDvTvwnisFsyVYApcTwc/Cn5eOLcieU1XHarYb+k6+88xsyE9x8/3Ho5XbscNSOIB5ompkF1iBh03i5FqyuWh3ddLeD/WCymVkoBse99RJuSOpgiTe+4BwP9l63zYrssY9u1RqjYvvcluylHWzG8aprgs+/iCTcjp5LLL/ImRO67qFht68f57b1PhCNZVzHTipdpo8awsmKxUeDfJCymqf9KRYADF++ClFcXRrGXSTbyJj863giLb7B7Ox+1/kDaLT8AkmmeJjczkGcUk+eEnEL6UAVDuryRkDT/sLcEYK5JwkOd02KnMSLXYG9nCDNHda2mt3Nek8BUt5e4E41H2bsvBTFgsXcr8k8vYoqizWq+8OBUOJAVKF65e76a2Hg3D/apraD1RE9uwPg9pIY+XH6Wn+yTKhsw/+DrUGadZj/gkq3ugYQB/zQ0WJknpDhsB71ANDcuL8OumZh0GDhtg08WsLIW9+d8DzbqsvdIkThrvJNJvuUNAW/uswdXEnnEL6F4NFcoku6S4GS+QD35dSUtmoZXAGAah0nM3nH6+555FHxzpNX8lOsxFRii2b6C5dJ5JBsxvkwP98pnoZXXgqvu+YtjrndqmOei2SHEn8fZpgAnJeNbgcdG2Lp6UYc658XqgI+ZaWoqwoZGvHEN+KTYBFvDv0INRc6h5FGIIy7m+1pdAoVajhDCkJngHT2MvbTw5aJovGrzWTWUDDUWAYpOHxHVUqt0nv1GmPnoEaLkUqnvT0rTuISys2i0je2caGSbklBVfBeIqPS3JEHPMNiobsU3k5c9jlrLynG9a0DuxgumxOLWByQU4gQL9rZ4BqwNjehJhHJvLfx643RdYjdjVWee98dv38h5IrY2KsmSwV8ymKwUJxLgcdxlSvvZjuUBBiloQdm21IR/3zhQ== X-Forefront-PRVS: 03449D5DD1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39400400002)(39410400002)(39860400002)(39840400002)(39450400003)(39850400002)(478600001)(6666003)(50226002)(305945005)(50986999)(8676002)(4326008)(81166006)(5660300001)(25786009)(86362001)(5003940100001)(7736002)(2906002)(189998001)(53936002)(36756003)(110136004)(33646002)(38730400002)(47776003)(55016002)(66066001)(33026002)(42186005)(1076002)(3846002)(6116002)(50466002)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB1516; H:mellanox.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB1516; 23:3WerZusL7NwBI6MuitYWILrgLMjSut7a5abfW9Glb?= Sd0LuVEbETn2InRPFcVjXSvlcaTb9Re7Z808mD8ihtZPuTb+jV0WlPP2QEePZkcXl1tKPHGyvJe1JR1MRm3Lvyh1ivpHhmMMSbTLfOPdM2cx69cg9WF95I1l/Vznp2tSi2WPA90XfAycAxJYheNYMoLgQHxj8kGs5PlJxB7IslV2Mbt1Ph3lfIAXZGOa33EK+ZUpcjOuL9WazhLiA9RLp40cBq9Y9JmT7KJNAhv3Q+hpAQyF0mmBNXZROuLfjHuHWPo6/RmX/W21KI1WLG/28yZA0epTGKg3RZTpZ3GjnIvtnAvUFxQ/c6fa+VovDkI4Za8HwY7lxzAU9G7dPoprGb2EZ9DLlRuY3ohyn7E089aXaNs78CIYXLME+QKxJ3WX926c3aw2mUlJzkPqc4+uSjOtoLMABmJbPIt7ki43DCjmU7YIT66MFsfGewW36Hcx5/laRE2gjd23BqqWeJAiziKJWXx4U+trJ3cAZRZ85gYCxnEkGNBpNfm9pS1YGmLBO5gMUDU09wRdGGhHf4Wqzq9XM3SHBFkbBhOfkCGL3UJUWi41Ry2s/520out/8Q2FsxrVZVMH4+9Of6BYDfbjp6DGx0joHTbSCmlES0SULjvrwqSIfd+CMUgmKKP58BSo/HiusvDa9bv8nA51eYYMxbivmlMZPwy0HzDrItV86uFIGDb/oNqQbITQ1HltshfAuAaDelymGK9pZciIVyuaR4C/XFqous67krbz9tE9WxnPdDVB14hDHq2VbwjsS/Z/9MD8LZGawPVLRviMs9riiB0WLMrN9rnpq3lXxsnrVQbC8SrSrNgf+NK4EBVwPN/fYX2RuAUxmvPR6V/EWFAIupQV/I+RETT80d1juOeSRsORC5knXb7zXg5QoP7dxpuPtxWF+8+XuwTLf3mlUB1KU27xjvnVPsqab2SAGfah5iZfb5yZZ/3L+nwlkk+eRiHsXQ= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB1516; 6:gO8u7K2IyqpKWfDhYK3fJ2ijsqDOTR1TmeDB9TJ0CE?= ijkK/SiSSENrWd8FvH5OWEkguobc9WF4zOxO44qboMXvxaYYe7BQWoaJmuCBd1mVV8pFtBsyeOkiHnqhzIOdPqN44ArgpJSuaE7twJ3S51noqXkvxwzHRMX0uSP1vo5V7I6y0w8gE6AYK1j8FDHGhKM1ALyodM4KzrfYAgJnN+3nw5pDhVEAN3l36JZaOK+Au9kWyVdxmhpndW9FVfhrYEJZDRbfS9qxsgm257kct2SU7toO0vqvbOvnov+nrmflNs2KLDJnN+NXbx4GEGgrb/Se7YWIa4UWS5S/N9FlPsoxmsbBKnyIZVfI5QHc+N2q6vG9xSLdrLf4q0CcDZWYIr5/LOOYpuBwSWJuTGI2uz31Lrgph27XgkXXSRVPuTgTeagowFs6B5OoFJWXJXE13TX2m7gRQf056nOtLxB0TETn0ULQbCl3k0i+sy8HdIRy+9x3CDyc8LqrItlTNIxpryUyCrUBhi0msLH4gjlBM44v05QqCDCRS3+bUqMRSljop4nXLFgleqXcrHymwwAdjEt21uUHCxMCfhbuiFA2f21zUAMd4nStd6GxUg7p+SkeqxYklhBsnBFrospVlnx63ymndlRe/87uKthfwVpqp66n0r75PUX8J6XTSLSdEOQNamVBJ7/K23XJ3Z1nbESN5Ywb094pk037dE9NaPzpOMjeeuYW+orqUESZjSUqcLOB+/0NW8rrnSxcBqLGKy3kxzjAmCskUrbEe4wc4/rfeYY66z//Uxq+HAW/9fNuHbKDt3KyA8nYKPa87L408RneQQcmcz2CePdyZOHiamDmPkNsEt3weBmQq4b2DCp0RGyxUutwRE0n+JooM0rlGN8uXftYYbhyBMUslCXbZR6Y96VGY9CmKbI5o2+mbouvAy2XBYxeo0vMXEIcJfxwzS8aP7g30k6Hkvta5PuTRh+d0kUoMVZI/q5kAXkyRM6eKyPCA6fzH3P6pq+ouiiTKaTpL2 X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1516; 5:UaezV8TdBH6KGlvwEkQL+X++cIXsBvmMFlGAK6hXQwxT+ZBFlb1DsJ/131JkTwzT6uBAjLpcAq2ooXOhY8u0FKBhRIxUmd1Wo5nOqinpZVSeNZhJe+RbeJtQXJ2UfJZ8fgnMypTeGzSfWYwxkSKOG0cZdI5/SoytvWVz/3y4A4FARO/LxXsQWj39R2JCQZaWXKU5Ks8y2VbckEI8Ca1rhASiBKKbZs73t/sUKnk8TPIZu0rDvCrWEWI2O9XOCxfLbC4aaUOyqirCYbcbup77RO4JYuUT7f2SmC/p4oI8JXYx7oU/37p2T9pRzNauFCu/cSzkfI8AjfoUHVbkomTVYAgGgXefRNo9pF3GXbozCqAApKuih5a3DM2/nzR6aYDYfvF1jcTugb+d5gv7848hRhl/A4iDkWni+xlaXMTZ257DM66ov1zvcxt9Q923A0rpkbbtt+k4/0/bFSr+HfqyeT/4O5btBJvYCVFDOwyuXgwQO1BU80vkICFxeuOfnA0f; 24:fY7bLi5Cune7/MsUHnFOmC4UPPEuUUFacmwCOhiciXtI9GJSeu8EU8XctKM0CgS6Y28dU0Tr+iOCoECWXrDwkUPaYL6EGrFsdZzDCUDJbw8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1516; 7:e1KpmKLduR1t0111J/S2rsDPbp+t0LsMRBoowotKkLaptc6Md96ufyvOEf6Oi3Szn4vyKWXPNnw0FvkVbqt2Wrm6ss+mYGiHFJeIbp/VVFA0rVc1Zy5mgQyf/wZa08LukZyA5ZtjDsP+jyq0rlsESAGuex/AP8Hftwka+LYwxGiUKQ3hugGAVgYY2ff+cFk6bmvl0LOJbPizjw3heh1teHY+0Hn+kMSBrAztxklUoexIMf6tuLgvQ4mS6vnCRRh0hlh8mTu7VI8p/D9tn4SCxq3w7wohkD4hNhM3q6jNKxWHLRDEK8qbh62ZRKSRYGVlaoDA0pkNeMCQoMGHCwslvI+FfX0Kq78wk5Fa6TuPXGhCaFI1GP7bHQTkSco/IA4zL9IKyhbEKSYHY1b4xiXC2u6uyYz1km1GL7x12Cke3sKzFzrJq4Z3m14jnYWfonTO2bxT/fLGvZOz9jlo9E+A2S0oATunFPhWL3vlI8mJJQrvnDjSbpjPl4bO3UhuYEPVhWtRmpFHQaJvW7UYUYSlObgUzLTmQmZ6cCycBpNhn9oDpzi8AcbJyKuZGI9c7/aYhILoldVhxlV/YP4D5Qoenw/O8PXtvRmghRNdssk96oyuJkFwECSJJztIaIWF/3cJALNSSYtR8s/4I6jlFPWoRKeifggHdLSKRyEJNnLK/ljaNirmG47mWjLBo+17RfwjYq6CKtv7zsznIPB6+m43bWtcKYOu0S74jEGNOY5rGE+o/Prs2L0QUOJd7IZH8Pk/VVm05OTzI3a4q9LQn52I7iWB+Bilk8Vd1TPxKMvTYYw= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2017 05:25:13.4682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1516 Subject: [dpdk-dev] [PATCH] net/mlx5: fix TSO segment size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case on multi segment packet, the TSO segment size was taken from the last segment. This may lead to incorrect values in case not all segments are initialized with the field. Fixing it by taking the value from the first segment. Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO") Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index cade625f9..70314b393 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -527,6 +527,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) uint16_t ehdr; uint8_t cs_flags = 0; uint64_t tso = 0; + uint16_t tso_segsz = 0; #ifdef MLX5_PMD_SOFT_COUNTERS uint32_t total_length = 0; #endif @@ -622,6 +623,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) tso_header_sz = buf->l2_len + vlan_sz + buf->l3_len + buf->l4_len; + tso_segsz = buf->tso_segsz; if (is_tunneled && txq->tunnel_en) { tso_header_sz += buf->outer_l2_len + @@ -821,7 +823,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) }; wqe->eseg = (rte_v128u32_t){ 0, - cs_flags | (htons(buf->tso_segsz) << 16), + cs_flags | (htons(tso_segsz) << 16), 0, (ehdr << 16) | htons(tso_header_sz), };