From patchwork Thu Jul 13 09:48:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Jastrzebski X-Patchwork-Id: 26882 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C06D25A6E; Thu, 13 Jul 2017 11:49:23 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2A2035905 for ; Thu, 13 Jul 2017 11:49:21 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2017 02:49:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.40,353,1496127600"; d="scan'208"; a="1171979500" Received: from unknown ([10.103.103.76]) by fmsmga001.fm.intel.com with SMTP; 13 Jul 2017 02:49:17 -0700 Received: by (sSMTP sendmail emulation); Thu, 13 Jul 2017 11:48:34 +0200 From: Michal Jastrzebski To: dev@dpdk.org Cc: deepak.k.jain@intel.com, declan.doherty@intel.com, Michal Jastrzebski Date: Thu, 13 Jul 2017 11:48:32 +0200 Message-Id: <20170713094832.16904-1-michalx.k.jastrzebski@intel.com> X-Mailer: git-send-email 2.12.2 Subject: [dpdk-dev] [PATCH] app/testpmd: fix bonding initialization due to unproper name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" when creating a bond device in testpmd, a name for a device must meet the correct convention described in the documentation: The device name must start with the net_bonding prefix followed by numbers or letters. Change for ALB mempool allocation - mem_name was too long. Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option") Signed-off-by: Michal Jastrzebski Reviewed-by: Jingjing Wu --- app/test-pmd/cmdline.c | 2 +- drivers/net/bonding/rte_eth_bond_alb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index d4ff608..23361bc 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -4900,7 +4900,7 @@ static void cmd_create_bonded_device_parsed(void *parsed_result, return; } - snprintf(ethdev_name, RTE_ETH_NAME_MAX_LEN, "net_bond_testpmd_%d", + snprintf(ethdev_name, RTE_ETH_NAME_MAX_LEN, "net_bonding_testpmd_%d", bond_dev_num++); /* Create a new bonded device. */ diff --git a/drivers/net/bonding/rte_eth_bond_alb.c b/drivers/net/bonding/rte_eth_bond_alb.c index 7f6884d..d9d3749 100644 --- a/drivers/net/bonding/rte_eth_bond_alb.c +++ b/drivers/net/bonding/rte_eth_bond_alb.c @@ -80,7 +80,7 @@ * The value is chosen to be cache aligned. */ data_size = 256 + RTE_PKTMBUF_HEADROOM; - snprintf(mem_name, sizeof(mem_name), "%s_MODE6", + snprintf(mem_name, sizeof(mem_name), "%s_ALB", bond_dev->device->name); internals->mode6.mempool = rte_pktmbuf_pool_create(mem_name, 512 * RTE_MAX_ETHPORTS,