From patchwork Fri Jul 21 11:21:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonid Myravjev X-Patchwork-Id: 27100 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C4B402C50; Fri, 21 Jul 2017 10:19:33 +0200 (CEST) Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by dpdk.org (Postfix) with ESMTP id F13B92C2B for ; Fri, 21 Jul 2017 10:19:31 +0200 (CEST) Received: by mail-lf0-f67.google.com with SMTP id l125so2839958lfg.5 for ; Fri, 21 Jul 2017 01:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=RecOmLq+B7yqPYxN3+V5IBlig6xKZGE3EhtgbrlIx+0=; b=euhenRmLFajbtWweNOJzKpFceVWt9SmgJ5kJplb0z24bP45ca/WfWSjCk48sW2VurI a0DNG1CUHHJm3fQaTYCvhOOToYcKBi/fn36q0VUftx/y/UOirI5uEs/868YQuooczHOi jL8zdazNFQKgwwrXpjYshTeeLbpi3ORsQSh7K7PkP8ZW3e45LBbW/lEqLlQfji+PhhCG zDT17f4pS+3QcVMhvdeg8uDMpEUL+1d5VpBFvLRw/REAa3PFHgXnIDzY3z+JT/YZEYs3 mloaaKsUvGLAnB5P6hF65bXZpb01ZO9MPOkzkuL7WDJFgd5gXNg/hEEfetCVo/ER8Rq3 Ti0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=RecOmLq+B7yqPYxN3+V5IBlig6xKZGE3EhtgbrlIx+0=; b=YRvqgNfIHonhTf4yI/whI3bnvBZJD9KQMNShph+FaEPxsAzM0WasOgelG+o0u6yvv/ 7a1rRcgeANDxNA7Wh1gKdJo5Bx3csDUcucjMuXZgNd9laC8dX0Nc6lLTcZBSvy110+dP q/CoLw9wmWP5xtFBGg1Eq84RPR6fU010K8GjVV+H0mX8eHOmtOvWh7sTE8GZrsIZz8AJ vFjFTF+zz8gmy8rfUQ7hX8v+q1KYohCh8hPgZOpEd+zkeeA68FMqQsG6F0Wag/KoG3zm ZTlhiKtO/Gnof0pMTXvJJzJn/4y9eUxBkjUF9tj4S4yE98dWDFSxhxjnz67Nh8ELbp8w z3RA== X-Gm-Message-State: AIVw1131O/SEpcFb1t5UrrRhiMF9PQG8PL+8YiPSzd9H6R+urfNEy8oT CS4cbvXrX1wqydheUS8= X-Received: by 10.46.92.193 with SMTP id q184mr2119879ljb.105.1500625171377; Fri, 21 Jul 2017 01:19:31 -0700 (PDT) Received: from localhost.localdomain ([77.108.111.101]) by smtp.gmail.com with ESMTPSA id u139sm813627lja.7.2017.07.21.01.19.30 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 21 Jul 2017 01:19:30 -0700 (PDT) From: Leonid Myravjev To: dev@dpdk.org Cc: Leonid Myravjev Date: Fri, 21 Jul 2017 11:21:05 +0000 Message-Id: <20170721112105.11973-1-asm@asm.pp.ru> X-Mailer: git-send-email 2.13.0 Subject: [dpdk-dev] [PATCH] net/ixgbe: Wrong PCI ids for PMD_INFO_STRING. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The pci_id_ixgbe_map table has only PCI_ANY_ID for .subvend and .subdev in all entries. Using of IXGBE_SUBDEV_ID_82599_SFP for 'dev' is not correct. It generates the wrong PMD_INFO_STRING. The output of the program "dpdk-pmdinfo.py" is confusing. --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 194058fb8..9473a0fee 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -442,13 +442,8 @@ static const struct rte_pci_id pci_id_ixgbe_map[] = { { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_KX4_MEZZ) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_KR) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_COMBO_BACKPLANE) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_KX4_KR_MEZZ) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_CX4) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_SFP) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_RNDC) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_560FLR) }, - { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_SUBDEV_ID_82599_ECNA_DP) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_BACKPLANE_FCOE) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP_FCOE) }, { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_SFP_EM) },