diff mbox

[dpdk-dev] crypto/dpaa2_sec: fix HMAC supported key sizes

Message ID 20170727115408.20386-1-akhil.goyal@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Akhil Goyal July 27, 2017, 11:54 a.m. UTC 
  For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
key sizes are not a fixed value, but a range between
1 and the block size.

Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver")
Cc: stable@dpdk.org

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Comments

Hemant Agrawal July 27, 2017, 1:57 p.m. UTC | #1 
On 7/27/2017 5:24 PM, Akhil Goyal wrote:
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> key sizes are not a fixed value, but a range between
> 1 and the block size.
>
> Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> index e104f71..3849a05 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> @@ -200,9 +200,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_MD5_HMAC,
>  				.block_size = 64,
>  				.key_size = {
> -					.min = 64,
> +					.min = 1,
>  					.max = 64,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 16,
> @@ -221,9 +221,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
>  				.block_size = 64,
>  				.key_size = {
> -					.min = 64,
> +					.min = 1,
>  					.max = 64,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 20,
> @@ -242,9 +242,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
>  				.block_size = 64,
>  				.key_size = {
> -					.min = 64,
> +					.min = 1,
>  					.max = 64,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 28,
> @@ -263,9 +263,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
>  				.block_size = 64,
>  				.key_size = {
> -					.min = 64,
> +					.min = 1,
>  					.max = 64,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  						.min = 32,
> @@ -284,9 +284,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
>  				.block_size = 128,
>  				.key_size = {
> -					.min = 128,
> +					.min = 1,
>  					.max = 128,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 48,
> @@ -305,9 +305,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
>  				.block_size = 128,
>  				.key_size = {
> -					.min = 128,
> +					.min = 1,
>  					.max = 128,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 64,
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
De Lara Guarch, Pablo July 27, 2017, 2:25 p.m. UTC | #2 
> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Thursday, July 27, 2017 2:58 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: Re: [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes
> 
> On 7/27/2017 5:24 PM, Akhil Goyal wrote:
> > For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported key sizes
> are
> > not a fixed value, but a range between
> > 1 and the block size.
> >
> > Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
...
> >
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
index e104f71..3849a05 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
@@ -200,9 +200,9 @@  static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
 				.algo = RTE_CRYPTO_AUTH_MD5_HMAC,
 				.block_size = 64,
 				.key_size = {
-					.min = 64,
+					.min = 1,
 					.max = 64,
-					.increment = 0
+					.increment = 1
 				},
 				.digest_size = {
 					.min = 16,
@@ -221,9 +221,9 @@  static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
 				.algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
 				.block_size = 64,
 				.key_size = {
-					.min = 64,
+					.min = 1,
 					.max = 64,
-					.increment = 0
+					.increment = 1
 				},
 				.digest_size = {
 					.min = 20,
@@ -242,9 +242,9 @@  static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
 				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
 				.block_size = 64,
 				.key_size = {
-					.min = 64,
+					.min = 1,
 					.max = 64,
-					.increment = 0
+					.increment = 1
 				},
 				.digest_size = {
 					.min = 28,
@@ -263,9 +263,9 @@  static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
 				.algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
 				.block_size = 64,
 				.key_size = {
-					.min = 64,
+					.min = 1,
 					.max = 64,
-					.increment = 0
+					.increment = 1
 				},
 				.digest_size = {
 						.min = 32,
@@ -284,9 +284,9 @@  static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
 				.algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
 				.block_size = 128,
 				.key_size = {
-					.min = 128,
+					.min = 1,
 					.max = 128,
-					.increment = 0
+					.increment = 1
 				},
 				.digest_size = {
 					.min = 48,
@@ -305,9 +305,9 @@  static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
 				.algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
 				.block_size = 128,
 				.key_size = {
-					.min = 128,
+					.min = 1,
 					.max = 128,
-					.increment = 0
+					.increment = 1
 				},
 				.digest_size = {
 					.min = 64,