diff mbox

[dpdk-dev] lib/librte_ether: remove the repeat code

Message ID 20170728081014.48104-1-zhiyong.yang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yang, Zhiyong July 28, 2017, 8:10 a.m. UTC 
  The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code
in the function rte_eth_copy_pci_info(), remove it here.

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 lib/librte_ether/rte_ethdev_pci.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Gaëtan Rivet July 31, 2017, 2:42 p.m. UTC | #1 
Hi Zhiyong,

On Fri, Jul 28, 2017 at 04:10:14PM +0800, Zhiyong Yang wrote:
> The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code
> in the function rte_eth_copy_pci_info(), remove it here.
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

> ---
>  lib/librte_ether/rte_ethdev_pci.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ether/rte_ethdev_pci.h
> index c3f7f721c..fe2e0f64c 100644
> --- a/lib/librte_ether/rte_ethdev_pci.h
> +++ b/lib/librte_ether/rte_ethdev_pci.h
> @@ -117,7 +117,6 @@ rte_eth_dev_pci_allocate(struct rte_pci_device *dev, size_t private_data_size)
>  	}
>  
>  	eth_dev->device = &dev->device;
> -	eth_dev->intr_handle = &dev->intr_handle;
>  	rte_eth_copy_pci_info(eth_dev, dev);
>  	return eth_dev;
>  }
> -- 
> 2.13.3
>
Thomas Monjalon July 31, 2017, 3:04 p.m. UTC | #2 
31/07/2017 16:42, Gaëtan Rivet:
> Hi Zhiyong,
> 
> On Fri, Jul 28, 2017 at 04:10:14PM +0800, Zhiyong Yang wrote:
> > The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code
> > in the function rte_eth_copy_pci_info(), remove it here.
> > 
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> 
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ether/rte_ethdev_pci.h
index c3f7f721c..fe2e0f64c 100644
--- a/lib/librte_ether/rte_ethdev_pci.h
+++ b/lib/librte_ether/rte_ethdev_pci.h
@@ -117,7 +117,6 @@  rte_eth_dev_pci_allocate(struct rte_pci_device *dev, size_t private_data_size)
 	}
 
 	eth_dev->device = &dev->device;
-	eth_dev->intr_handle = &dev->intr_handle;
 	rte_eth_copy_pci_info(eth_dev, dev);
 	return eth_dev;
 }