diff mbox

[dpdk-dev,1/2] app/testeventdev: fix string overflow

Message ID 20170731100452.12647-1-jerin.jacob@caviumnetworks.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob July 31, 2017, 10:04 a.m. UTC 
  Coverity issue: 158660
Fixes: 4afd440ec132 ("app/testeventdev: update options through command line")
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 app/test-eventdev/evt_options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Van Haaren, Harry July 31, 2017, 10:08 a.m. UTC | #1 
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Monday, July 31, 2017 11:05 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>;
> nipun.gupta@nxp.com; gprathyusha@caviumnetworks.com; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2] app/testeventdev: fix string overflow
> 
> Coverity issue: 158660
> Fixes: 4afd440ec132 ("app/testeventdev: update options through command line")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Thomas Monjalon July 31, 2017, 8:41 p.m. UTC | #2 
> > Coverity issue: 158660
> > Fixes: 4afd440ec132 ("app/testeventdev: update options through command line")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Series applied, thanks
diff mbox

Patch

diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
index dbab8ea61..65e22f845 100644
--- a/app/test-eventdev/evt_options.c
+++ b/app/test-eventdev/evt_options.c
@@ -109,7 +109,7 @@  evt_parse_queue_priority(struct evt_options *opt, const char *arg __rte_unused)
 static int
 evt_parse_test_name(struct evt_options *opt, const char *arg)
 {
-	strcpy(opt->test_name, arg);
+	snprintf(opt->test_name, EVT_TEST_NAME_MAX_LEN, "%s", arg);
 	return 0;
 }