From patchwork Wed Aug 16 11:43:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 27624 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 456169964; Wed, 16 Aug 2017 13:43:26 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by dpdk.org (Postfix) with ESMTP id 39564995F; Wed, 16 Aug 2017 13:43:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5MnUH103kvV7SckZZCa1yRfpicouauwlzXTOwLLuGNo=; b=elatg3ojrR6vdPaYJbNaFuNOPSciy2movbq7+CiksY2q0g1VoE7N+0i8rR70XrYS2POd10AyvIt7e7c4jF27D5ZcwLU1G872y3VGZcDjrmwf2ui3/comVgxjJgniWUn11bQCRq6XmVY2KZExYkusR1YbZritPH6bm4n50E4GIX0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by DB6PR05MB3144.eurprd05.prod.outlook.com (2603:10a6:6:1a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.21; Wed, 16 Aug 2017 11:43:22 +0000 From: Shahaf Shuler To: thomas@monjalon.net Cc: dev@dpdk.org, gaetan.rivet@6wind.com, stable@dpdk.org Date: Wed, 16 Aug 2017 14:43:08 +0300 Message-Id: <20170816114308.165850-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: HE1PR09CA0082.eurprd09.prod.outlook.com (2603:10a6:7:3d::26) To DB6PR05MB3144.eurprd05.prod.outlook.com (2603:10a6:6:1a::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 843fb483-6a45-4e15-c011-08d4e49bffe5 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(48565401081)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR05MB3144; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 3:Z9hIZtgRgRRYO7joR0wLfhdPEsU/qI5fobMKBDq1+UQktl6ovsKUoBiCcIfj6fsV3JWeklcv9WcGi/n4xfOo7cdmuWjXHbajQUnbMSfDJQ/t8IUBwnXz1C2Ki+lEskyiK5LI8xZlcGyvUtXCT5GuTAKLGEG+q/LyG/PbDnN7tuPTi1cGgz/6C/F68/rjUpVsP2YfL2+TErQ5cik2Jb0uOS13CKZb8ZyEKA1QrAXywX6Wo4UvtkMQEiehkfQvy/fJ; 25:jT9LS9u7AhNmi2SzfIPEJA6n10rEhtwNZjFiD5XWhf6czeKj1uFHG3b7/J5SMmwNf3OMA8btTRc0wIw1foxsjaosXTaJc6OJJ2hm/pbJe/p84Ysr4UTjI5lgXm/PaZZvXaorsJTki6n9jHY2WSwaxvzFYukAIrX7gpyQMAPmwS+DuQd13cNA57Ylya+Jk/l/UHrZg3sm0GCl/vpycGLvETbu1oB2eBAcIqVB8khJfilWr+h5/+LhoLo2++DaOs6jBPSCf4KRilM5S7iocAGAEIDgBAEoYiFjrhKIxU9m4z5VttknMUtk1J4VKaXK7BFj0pRd+Yu5uCD/T4AHvKnEFQ==; 31:+2nHd2k2/vDUaAAS/cmJTd5NjPBt2xXeZG3u8SJ/GAECihy/ug90UJLaBGrS4ZuX54jAJDS97ApIqFWcUUdEmcD9D7ebK5TO/H/ldUiv5ALAxaTbvtGtfPK4SbrtU4bnr5+MMFYPwDNaWwakn3xI0rrm4SZaPBx6oYynwEA9GL/Zz7d06PWfFcS28nHui+QvQI3NYgwMxFpEPAOb/y8Bq/b3wCNbJsllQE29CbztqnY= X-MS-TrafficTypeDiagnostic: DB6PR05MB3144: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 20:PTXyH/YPuMf9bgxiTc51/xfiXcZRl6TqDeYycbnBz/k4XDmUTExDuLsN3yBPHlNkna/i26Tw9/AZyX2vbtCLE01RjH8mOfi5njMS/vBDyaWX8tVZoM595a0SwLxWxQ1ImOg6pEZb6P99g2tsYGaHZelAA8xOqK/K6aWRU8mAz9JZSQQWCbjtC1qNmqa4qT0yPNr+vVIp3pmQePl/ftp7oknZE0gascmCjluZOMHaQour0NB/8nhUCEVzlYGj18UDAJYGMFIpkvkS+0lCV0pjoZOxxwf7WqZFF+/GLilfu2ovaklnusyT6OpQ52RiT8ObMWVPFe6pDipSATaMUkcASrsqE8UkSL2cI7JsSEfAjY+CXoWC6KgZ6qDMjx0gHFd06nJBwf/qyyu4XvIV0sEf1h5fc5WgQpQ8dX/w6aAmQJgLq5niDmEAo5OE6TPrMEdWXskDuI1CuoT2bmVAV8plRQ1m71qr1IHBNUyVgIcdsQB1sntSEVxWzTn+3g6OyYYU; 4:EwRjb4SqNwBzxAS93DzZkXMRJUuYSg1bYgDOVbnIiv3BwdZ0FOlO8EQX2625I3rkExD4PrQm4oJUthsKQdjyooBb+1BBiFQtG4o9y6svgAFvGJ1ALyh7wiaBJ+D7L2QJ70DvlyefxqkzM7Anszb9sbcs2qRUretKYEooyVZRXYiGVPrR5oHT/a6kHqXtGtJ1XDYQSGi9H1Vjh2Fr9CLcYMy3uDgaTvaNZ2hCDX34oKfzhrl/uzGzn108Ah4DhSv1 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR05MB3144; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR05MB3144; X-Forefront-PRVS: 0401647B7F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(39860400002)(189002)(199003)(33646002)(4326008)(110136004)(21086003)(33026002)(7350300001)(53936002)(5003940100001)(69596002)(25786009)(1076002)(6666003)(68736007)(50226002)(5660300001)(97736004)(2906002)(42186005)(478600001)(6916009)(5890100001)(101416001)(105586002)(2351001)(8676002)(66066001)(55016002)(81156014)(81166006)(305945005)(189998001)(2361001)(50986999)(48376002)(106356001)(7736002)(3846002)(6116002)(50466002)(47776003)(36756003)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3144; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3144; 23:kenn/wf8Ukv02kYOPEFpnG2N/Gl1yVa06dYUYtc75?= Xo6Pb+YkcCaZ+7PZgMhWMk1vYcbqGV2Z9dFsga5kewbFEKkFh21RHn3yJwXas5lZx8HPiO/75B4WcrEQQJjIGEQ9c0U0bpJ4kTGp9nGg8w6wsiUz1Y8wfDrTWNu2c/6f6ciNL7nAqs2V8G7hRR/Uy7hS1l1SPQ8anhaE1YddUJgwtGBEnb/4+skNuSpLkzhBJI9X2sbnNZBjilEH3iAclCQkXVuE0pACMGjrSlp3qSTA+L33NqyolKzFxgwky3o4OOtxlSgn6natj+UQk5ha5c6sUgRexquGyAT7DCW3ddwBxLkxeGTlQsR4A4k93Cnd0RhzvzDTo6W/uVKbQbW9qreHtBXhr3G6c5I4ktMi098Gn6aD58KM1G2y301C9KVUnr9UUnj0+Bob2aOXlMjhzkAuKm+5qr/Y7p7nC7cEWYZyFwiRqUoPCGtm8RHuJCbDBNDabi0GchkZnwHzP9+vs7olsSioiAvWd6oNJjWFLST/ilOrP7P2lCM9PmMrjVv+B1j17v98sGlMP4jNRi6hzWU0c2QAkCf8Dl3WswhpQBsUcYG0GyyNFaHsPKiLBG/DIQrOvMbvkOt8M9supQUapMGnoKKoao0UCgLghwwrIC9XiEsmfEbM+uBA7bcOYUoj2O/dOyVNSpsIylyKJR/1MWwKQQ+ObOmG/G/7Qd54q866PbiBXswHdtmtLUQMyYJnbDm7n7fP8UvNtKXRejwOCPJMxI+ANkaGF8DBW5sx3vRwnKRO40tE/58DUVrF+V8ealjNAlmVxyF66DI9A7rP0wtNm74p0KWgeStwMlacUZd6fcxOINQX4mG4cfzTRm8L0VZXD4qTMA5T1M+ocPZPQ/hye55XaDR/7h6QsTggxyiQ/E/xyO6bGzZ/nK4qfjBV/2akV+xMszv85b1zxdcZP/+b7Mi2Lcoky9tezpp0OLs/rcinRgqclxPFvmuwDtTvm6hzr96alKy8wqJiKRjEwwKd4n4iz6PS7e4M8gY2Ujz/KIL/AkY39nO0kcA//ieIedsixxRm2KXbvNQdDBGNDvcgg5tjhAycSKEtelXXuS5wHlwIPy6WP/ILQIbkKfyQ9GgY3oUVechxrgZoSM90+BDy3W/HkFL3bWnSeNeNiehhrOR9kqaRc1iMkt1ljnN5Cs= X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 6:TwSktjwV/y3ZEnpQJa+cR3+OvSOM2wmVOvEJZnv1pxwDyDpnCIS/s2yEToewPDrGcktu4o5w5iOghF5PR4cHr3xgObkKC7RjeYwFOoJeUX8Nv2YhLclZYaFSRJI8VSoM4RBQbJLS4xHzJ89POidhf02mnhjCaLi/5swaWFpjQbLDTeUino8igM1T0yM0uNCKitPbgzQfWFSH53+HKSlEH+bD0rj3w6jFhZsYGbfSp18G4weql+ipN6WKu74kKx3kgrD23fYNzH/9t3zTya6m6918MpMzgPJlyBS/pqKtJ61yeWr9LbkXL9RKMXyuyuqcSjkB85LqFpBeXZytA7VLGg==; 5:l4TJCQo7JV6GueGV8BlXTSnPGtYcaaMJnYWvgLooiqsclwgVHv2hIpzyR0d58ngTrCmvQwUcOjgz3KwsFweCgW1yQ1A7A/1A/nadewkGkmyYzdSf6I0WyYs0RhB/Meqr5bfTg7iLJiIxlM/o9udzcQ==; 24:RgNWivmIL5iWN4FICcGZ8OacHR0Uk20bL/ZbBqlpvOTSepugD5gOMtGR64JgdWnhlb0q4kpO+DKuc4rbF52qlEPGCVYgGBUmmFWvZOLOBrQ=; 7:B7c59E7diORb0qjUQfe2220+rUvLNpsKo1GIP1CdCqhoxN8GPmQ1rAo7YKUmkpPS1Crxxum+RfYuag9KRfEcTSu06XbvbhHfm+bCIbdqXUsd9GAnpQxRY0kUjLATJrm5yp8EjPFWXkDt3P6VjgzfCwUUFelQaQ4XmeSORS6J38ZziYlEnnpdQIGFNAkAvdonWdWe2j/nRUom34LtuJBebR5Pd1aPJJlEXh5euLb8K9Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2017 11:43:22.1026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3144 Subject: [dpdk-dev] [PATCH] ethdev: fix device state on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently device state moves between ATTACHED when device was successfully probed to UNUSED when device is detached or released. The device state following rte_eth_dev_close() operation is inconsist, The device is still in ATTACHED state, however it cannot be used in any way till it will be probed again. Fixing it by changing the state to UNUSED. Fixes: d52268a8b24b ("ethdev: expose device states") Cc: gaetan.rivet@6wind.com Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler --- lib/librte_ether/rte_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 0597641ee..98d9e929c 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -992,6 +992,8 @@ rte_eth_dev_close(uint8_t port_id) dev->data->nb_tx_queues = 0; rte_free(dev->data->tx_queues); dev->data->tx_queues = NULL; + + dev->state = RTE_ETH_DEV_UNUSED; } int