From patchwork Mon Aug 28 21:49:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Howell X-Patchwork-Id: 28039 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 708EA1B53; Mon, 28 Aug 2017 23:49:35 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AAE4811F5 for ; Mon, 28 Aug 2017 23:49:33 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2017 14:49:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,442,1498546800"; d="scan'208";a="142937534" Received: from sethhowe-desk.ch.intel.com ([143.182.137.63]) by orsmga005.jf.intel.com with ESMTP; 28 Aug 2017 14:49:24 -0700 From: Seth Howell To: dev@dpdk.org Cc: Seth Howell Date: Mon, 28 Aug 2017 14:49:12 -0700 Message-Id: <20170828214912.133503-1-seth.howell@intel.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170815205336.9266-1-seth.howell@intel.com> References: <20170815205336.9266-1-seth.howell@intel.com> Subject: [dpdk-dev] [PATCH v3] eal/linuxapp: check mmap return value MAP_FAILED X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If mmap fails, it will return the value MAP_FAILED. Checking for this return code allows us to properly identify mmap failures and report them as such to the calling function. Signed-off-by: Seth Howell Acked-by: Sergio Gonzalez Monroy --- lib/librte_eal/linuxapp/eal/eal_memory.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index 5279128..63fec29 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -716,6 +716,8 @@ create_shared_memory(const char *filename, const size_t mem_size) } retval = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); close(fd); + if (retval == MAP_FAILED) + return NULL; return retval; }