From patchwork Tue Sep 5 08:46:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Congwen Zhang X-Patchwork-Id: 28346 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 2F112374F; Tue, 5 Sep 2017 11:02:38 +0200 (CEST) Received: from mxct.zte.com.cn (out1.zte.com.cn [202.103.147.172]) by dpdk.org (Postfix) with ESMTP id 9BB033254 for ; Tue, 5 Sep 2017 11:02:36 +0200 (CEST) Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 219E78282BAD17736454; Tue, 5 Sep 2017 17:02:33 +0800 (CST) Received: (from root@localhost) by mse01.zte.com.cn id v8592Tm3013413; Tue, 5 Sep 2017 17:02:29 +0800 (GMT-8) (envelope-from zhang.congwen@zte.com.cn) Message-Id: <201709050902.v8592Tm3013413@mse01.zte.com.cn> Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v858ljT4054933; Tue, 5 Sep 2017 16:47:45 +0800 (GMT-8) (envelope-from zhang.congwen@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.171]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017090516474872-1680132 ; Tue, 5 Sep 2017 16:47:48 +0800 From: Congwen Zhang To: rahul.lakkireddy@chelsio.com Cc: dev@dpdk.org, Congwen Zhang Date: Tue, 5 Sep 2017 16:46:57 +0800 X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-09-05 16:47:48, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2017-09-05 16:47:41, Serialize complete at 2017-09-05 16:47:41 X-MAIL: mse01.zte.com.cn v8592Tm3013413 X-MSS: AUDITRELEASE@mse01.zte.com.cn Subject: [dpdk-dev] [PATCH] net/cxgbe: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In function t4_wr_mbox_meat_timeout(), Dynamic memory stored in 'temp' not free when the functon return, It possible memory leak. Signed-off-by: Congwen Zhang Acked-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_hw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c index a8ccea0..013d996 100644 --- a/drivers/net/cxgbe/base/t4_hw.c +++ b/drivers/net/cxgbe/base/t4_hw.c @@ -403,6 +403,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, t4_os_atomic_list_del(&entry, &adap->mbox_list, &adap->mbox_lock); t4_report_fw_error(adap); + free(temp); return (pcie_fw & F_PCIE_FW_ERR) ? -ENXIO : -EBUSY; } @@ -446,6 +447,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, &adap->mbox_list, &adap->mbox_lock)); t4_report_fw_error(adap); + free(temp); return (v == X_MBOWNER_FW ? -EBUSY : -ETIMEDOUT); } @@ -546,6 +548,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, T4_OS_MBOX_LOCKING( t4_os_atomic_list_del(&entry, &adap->mbox_list, &adap->mbox_lock)); + free(temp); return -G_FW_CMD_RETVAL((int)res); } }