[dpdk-dev] test: fix wrong assignment operation
Checks
Commit Message
It should be an comparation operation rather than an assignment
operation.
Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
test/test/test_link_bonding_mode4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 9/15/2017 3:35 AM, Zhiyong Yang wrote:
> It should be an comparation operation rather than an assignment
> operation.
>
> Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 9/18/2017 8:25 PM, Ferruh Yigit wrote:
> On 9/15/2017 3:35 AM, Zhiyong Yang wrote:
>> It should be an comparation operation rather than an assignment
>> operation.
>>
>> Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
>>
>> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -661,7 +661,7 @@ bond_handshake(void)
TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");
/* If flags doesn't match - report failure */
- return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED;
+ return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
}
#define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)