From patchwork Fri Sep 15 02:35:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yang, Zhiyong" X-Patchwork-Id: 28751 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E4CE2BBE; Fri, 15 Sep 2017 04:36:04 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D6D7D2935 for ; Fri, 15 Sep 2017 04:36:02 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 14 Sep 2017 19:36:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.42,395,1500966000"; d="scan'208"; a="1219064913" Received: from unknown (HELO dpdk5.bj.intel.com) ([172.16.182.182]) by fmsmga002.fm.intel.com with ESMTP; 14 Sep 2017 19:36:00 -0700 From: Zhiyong Yang To: dev@dpdk.org Cc: declan.doherty@intel.com, ferruh.yigit@intel.com, Zhiyong Yang Date: Fri, 15 Sep 2017 10:35:57 +0800 Message-Id: <20170915023557.35681-1-zhiyong.yang@intel.com> X-Mailer: git-send-email 2.13.3 Subject: [dpdk-dev] [PATCH] test: fix wrong assignment operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It should be an comparation operation rather than an assignment operation. Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4") Signed-off-by: Zhiyong Yang Reviewed-by: Ferruh Yigit --- test/test/test_link_bonding_mode4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c index 8e9e23db5..e246f0148 100644 --- a/test/test/test_link_bonding_mode4.c +++ b/test/test/test_link_bonding_mode4.c @@ -661,7 +661,7 @@ bond_handshake(void) TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n"); /* If flags doesn't match - report failure */ - return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED; + return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED; } #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)