From patchwork Wed Sep 20 14:11:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Harton X-Patchwork-Id: 29024 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAC9F2935; Wed, 20 Sep 2017 16:12:23 +0200 (CEST) Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) by dpdk.org (Postfix) with ESMTP id 9E8C025B3 for ; Wed, 20 Sep 2017 16:12:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3070; q=dns/txt; s=iport; t=1505916742; x=1507126342; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=XC9+FT094G1JY/lxOVWC+GXkJ2Ckn/DTJXaQLlmzLEU=; b=StqwPpeVr4I1KqHbz/QsCFqbRNtLd1wywpDp6oBITk3IWb4d4xbyp8i9 M6AKDxQMQyAtPse5ocwBmVeBL/9HqW567HrqClqkWGJwdHMp6hk4uno8i 1xT1Fe80JBGgd1VhEKIRdZFr2haJxQKWH8E30tdhhPWQw4Lpdln7u3yWC g=; X-IronPort-AV: E=Sophos;i="5.42,421,1500940800"; d="scan'208";a="295628008" Received: from alln-core-11.cisco.com ([173.36.13.133]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Sep 2017 14:12:21 +0000 Received: from cpp-rtpbld-31.cisco.com (cpp-rtpbld-31.cisco.com [172.18.5.114]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id v8KECLAL005919; Wed, 20 Sep 2017 14:12:21 GMT Received: by cpp-rtpbld-31.cisco.com (Postfix, from userid 140087) id 542C05A9; Wed, 20 Sep 2017 10:12:21 -0400 (EDT) From: David C Harton To: thomas@monjalon.net, ferruh.yigit@intel.com Cc: dev@dpdk.org, David Harton Date: Wed, 20 Sep 2017 10:11:30 -0400 Message-Id: <20170920141130.19992-1-dharton@cisco.com> X-Mailer: git-send-email 2.10.3.dirty In-Reply-To: <20170901022631.19529-1-dharton@cisco.com> References: <20170901022631.19529-1-dharton@cisco.com> Subject: [dpdk-dev] [PATCH v6] ethdev: add return code to rte_eth_stats_reset() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: David Harton Some devices do not support reset of eth stats. An application may need to know not to clear shadow stats if the device cannot. rte_eth_stats_reset is updated to provide a return code to share whether the device supports reset or not. Signed-off-by: David Harton Reviewed-by: Ferruh Yigit --- v6: * removed duplicated entry on rel_notes v5: * squashed doc patch * moved rel_note change from ABI to API section v4: * commented return values v3: * overcame noob errors and figured out patch challenged v2: * fixed soft tab issue inserted while moving changes doc/guides/rel_notes/release_17_11.rst | 6 ++++++ lib/librte_ether/rte_ethdev.c | 8 +++++--- lib/librte_ether/rte_ethdev.h | 6 +++++- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 22df4fd..9b77c31 100644 --- a/doc/guides/rel_notes/release_17_11.rst +++ b/doc/guides/rel_notes/release_17_11.rst @@ -110,6 +110,12 @@ API Changes Also, make sure to start the actual text at the margin. ========================================================= +* **Modified the return type of rte_eth_stats_reset.** + + Changed return type of ``rte_eth_stats_reset`` from ``void`` to ``int`` + so the caller may know whether a device supports the operation or not + and if the operation was carried out. + * **Modified the vlan_offload_set_t function prototype in the ethdev library.** Changed the function prototype of ``vlan_offload_set_t``. The return value diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 05e52b8..f0f1775 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1341,17 +1341,19 @@ rte_eth_stats_get(uint8_t port_id, struct rte_eth_stats *stats) return 0; } -void +int rte_eth_stats_reset(uint8_t port_id) { struct rte_eth_dev *dev; - RTE_ETH_VALID_PORTID_OR_RET(port_id); + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); dev = &rte_eth_devices[port_id]; - RTE_FUNC_PTR_OR_RET(*dev->dev_ops->stats_reset); + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->stats_reset, -ENOTSUP); (*dev->dev_ops->stats_reset)(dev); dev->data->rx_mbuf_alloc_failed = 0; + + return 0; } static int diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 7254fd0..9110725 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -2246,8 +2246,12 @@ int rte_eth_stats_get(uint8_t port_id, struct rte_eth_stats *stats); * * @param port_id * The port identifier of the Ethernet device. + * @return + * - (0) if device notified to reset stats. + * - (-ENOTSUP) if hardware doesn't support. + * - (-ENODEV) if *port_id* invalid. */ -void rte_eth_stats_reset(uint8_t port_id); +int rte_eth_stats_reset(uint8_t port_id); /** * Retrieve names of extended statistics of an Ethernet device.