[dpdk-dev] usertools/dpdk-devbind.py: fix broken Python 3 support

Message ID 20171006213838.20000-1-omrimor2@illinois.edu (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Omri Mor Oct. 6, 2017, 9:38 p.m. UTC
  When using Python 3, dpdk-devbind.py fails to detect modules other than
igb_uio.

Signed-off-by: Omri Mor <omrimor2@illinois.edu>
---
 usertools/dpdk-devbind.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
  

Comments

Thomas Monjalon Nov. 7, 2017, 10:31 p.m. UTC | #1
06/10/2017 23:38, Omri Mor:
> When using Python 3, dpdk-devbind.py fails to detect modules other than
> igb_uio.
> 
> Signed-off-by: Omri Mor <omrimor2@illinois.edu>

Applied, thanks
  

Patch

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index da6e40cbe..a539995cd 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -204,8 +204,7 @@  def check_modules():
 
         # special case for vfio_pci (module is named vfio-pci,
         # but its .ko is named vfio_pci)
-        sysfs_mods = map(lambda a:
-                         a if a != 'vfio_pci' else 'vfio-pci', sysfs_mods)
+        sysfs_mods = [a if a != 'vfio_pci' else 'vfio-pci' for a in sysfs_mods]
 
         for mod in mods:
             if mod["Name"] in sysfs_mods: