diff mbox

[dpdk-dev] net/vmxnet3: fix memory leak when releasing queues

Message ID 20171101203820.8021-1-3chas3@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Chas Williams Nov. 1, 2017, 8:38 p.m. UTC 
  From: Chas Williams <chas3@att.com>

At the end of the queue release, we can free the containers for the
queue objects.

Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation")

Signed-off-by: <chas3@att.com>
---
 drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Luca Boccassi Nov. 2, 2017, 10:03 a.m. UTC | #1 
On Wed, 2017-11-01 at 16:38 -0400, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
> 
> At the end of the queue release, we can free the containers for the
> queue objects.
> 
> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
> implementation")
> 
> Signed-off-by: <chas3@att.com>
> ---
>  drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index 01c85f1..18dce72 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -203,6 +203,8 @@ vmxnet3_dev_tx_queue_release(void *txq)
>  		vmxnet3_cmd_ring_release(&tq->cmd_ring);
>  		/* Release the memzone */
>  		rte_memzone_free(tq->mz);
> +		/* Release the queue */
> +		rte_free(tq);
>  	}
>  }
>  
> @@ -223,6 +225,9 @@ vmxnet3_dev_rx_queue_release(void *rxq)
>  
>  		/* Release the memzone */
>  		rte_memzone_free(rq->mz);
> +
> +		/* Release the queue */
> +		rte_free(rq);
>  	}
>  }
>  

Reviewed-by: Luca Boccassi <bluca@debian.org>
Ferruh Yigit Nov. 3, 2017, 12:17 a.m. UTC | #2 
On 11/2/2017 3:03 AM, Luca Boccassi wrote:
> On Wed, 2017-11-01 at 16:38 -0400, Chas Williams wrote:
>> From: Chas Williams <chas3@att.com>
>>
>> At the end of the queue release, we can free the containers for the
>> queue objects.
>>
>> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
>> implementation")
>>
>> Signed-off-by: <chas3@att.com>

> Reviewed-by: Luca Boccassi <bluca@debian.org>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 01c85f1..18dce72 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -203,6 +203,8 @@  vmxnet3_dev_tx_queue_release(void *txq)
 		vmxnet3_cmd_ring_release(&tq->cmd_ring);
 		/* Release the memzone */
 		rte_memzone_free(tq->mz);
+		/* Release the queue */
+		rte_free(tq);
 	}
 }
 
@@ -223,6 +225,9 @@  vmxnet3_dev_rx_queue_release(void *rxq)
 
 		/* Release the memzone */
 		rte_memzone_free(rq->mz);
+
+		/* Release the queue */
+		rte_free(rq);
 	}
 }