From patchwork Mon Feb 26 17:50:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 35431 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D7044C74; Mon, 26 Feb 2018 18:51:16 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0042.outbound.protection.outlook.com [104.47.1.42]) by dpdk.org (Postfix) with ESMTP id 0A56949E0; Mon, 26 Feb 2018 18:51:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C4KqXAj9MLYhSHG+kzWjoTzWV1nYFWgiwo06dTRXWwA=; b=oVYfXnSdsEEZOVQ3xLE4kmUdBvNZWaNSrDkwfkVMTRGbZkY9DmJgjYB5wqtKykmfPZEgQERVpCHvmakt+Qhr6y26pcXtecsXB35Vs3snyQy7sSspsXQG79vpdQERYKFOJl5qY+tW7Yhu9BKz7JCT4DIE2lCZ4NiQ1ZhgQ6dsg/A= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2044.eurprd05.prod.outlook.com (2603:10a6:3:35::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Mon, 26 Feb 2018 17:51:10 +0000 From: Yongseok Koh To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, Yongseok Koh , stable@dpdk.org Date: Mon, 26 Feb 2018 09:50:57 -0800 Message-Id: <20180226175057.27565-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CY4PR19CA0046.namprd19.prod.outlook.com (2603:10b6:903:103::32) To HE1PR0501MB2044.eurprd05.prod.outlook.com (2603:10a6:3:35::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 64175d82-ec59-465c-5687-08d57d41865a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0501MB2044; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2044; 3:CPI7mN2OVrpxMyKSbtgXGPyaupNPniCNiGTKI/eKEDeN+rM37CRkQzeUM+Xa1GbFDFU2PBzBxb5RoYvOEQ7RckE8Riwmwh1uDXJb9l8cH5Cmp8u8rPH57z8o2Xh79JF0OoxdCiqbAu2eEAXvu2AFWR85oMV0rHJZolBZ7JPVZYKDDcpYX5uHpNyaYhnVMjmQ+qtc35I4L6HmgQ6W/0DRs9FoRH+gIjEZM+TLDUd7GWfvS7sFS+ENWiNbHmr7z463; 25:6Xstqet7xZrvqNet1PEbDWUm600WiYNhF5YtiONvWPB6TdcZURkOb2hExo8OqT1qqGlmbTj9heWb0AxPOMo0XE3HiD/If6MOAtkcCj59VHikKwAdxZsJOTX16Ylb7j4Lruhhm+4n1A3uTDjAHucnR38W8io1YptKn9q8WP/zTSdeE4oKdU3hR/ux1fJ7Y8tiIOL7evXUVSWo8Ag7PAgFTXLMfv0lP2urtnT/sItYhOeGaAei/mLKWRxSE4Q96c2uxKSNZLbuaG1SO5/5HGH2sOzp+Axlocrha7hLB3TTrLPHbdFtRgWNKUjxB84YuYAgafJHYmFwa8YUPkSteXHeow==; 31:NZ0NmmTkPWdukAYfgYG07+mknj/P0gQ5pjcbtPGS7yCiFJK7buljZ46uFk+ZR92LMCF198+7EX/d+6eSoUK2WzIJq/bvU2aYh96MlsWv9EKG/bBSd+uuNNU/qZuJSWe4uNZFmS7rztC8xyPXf6X1pSlgyFs+oZwfAn9oZxdZOeLq2t2u4pxq2j3Bjs55RhFMGO0Ab/NylNF7SvHS52DSNSxGuwavyK4PSrqNSP7CSJ4= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2044: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2044; 20:3dq8sWpruOZSt04H11KRm1aJ1TjIPYhiffm6Kvm0RZRsjmDfDksPEDRxZKuocdVGVOSbGxXNU7wdrMq+gMftMvL/HfWvg+XP38Qq9sy+5PawOCYkqzKQKomITIITfzUwqQq1IzBio8+WXjI/omeuyftpWrMWkK6fk4tenJH5+zYLHik4rbpX7pBG8PR6dXlCQSrWIG2VRxny6rDVOXvHFnm2q4s9UG4mjonchd+MK3Qcimn85gWe0X1RGbxG3K9jk6hB53676FMfK9Puspn1OaVf5NfJu41LX1eUvAPB/B8FNXEDgIq+9qvgo0nqywWVJNOHgS38Ry8vtlyGgAn2m5gCFBnIbOwO9SMnxaSIXbjCu4cmEL4+DbjM5nOO2uDl/1erdboxz6oqlmReYifP0LDoRDCk9h8MuyqNJoFj50p/4bdptbNW0jpVMNWZl8GPHBJw5tLNTkLXh4Wy15ywKowUbVpWjNIWQylU+vq7oz7AspzIhUviIbrRyk9cMWtt; 4:ko9/2nsxqOTUONCapEQbXrpXjwAmj1hV9Ts1EJLXOjBWlGZmIiAgCRHkih2p63Agc/75eHmtKQahvhOSpnVKJ4+MOv7aOZ5308ekPwEG5dDoj1zto6f9bIut6hDCOkrsEDKjuNZep+NAE8N0Wb0eRMGIcTSnyZXHzwSApu9nD1BwwKKiLtPM68ix1Cj4yPAktbS2I2Ooho7IJ05CyvyAm033pxovxX5DxOAInUcPQJB7vizpuiu3h/03gAk/2D8de5QTAXxGT59SgQN9WuVkxw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231220)(944501161)(52105095)(93006095)(93001095)(6055026)(6041288)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0501MB2044; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2044; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(396003)(366004)(346002)(39380400002)(199004)(189003)(81156014)(55016002)(97736004)(1857600001)(478600001)(16586007)(36756003)(81166006)(26005)(305945005)(316002)(66066001)(186003)(47776003)(106356001)(21086003)(25786009)(7736002)(6666003)(6116002)(69596002)(3846002)(1076002)(59450400001)(16526019)(48376002)(386003)(50466002)(8676002)(2906002)(53936002)(5660300001)(7696005)(105586002)(50226002)(51416003)(8936002)(52116002)(86362001)(68736007)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2044; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2044; 23:ogE3iBhDH3sIT8FSNzbnRvWh7amiQO1oqEv8Ozx?= GK/xVPxkGavBWVoMtIECE1sp/hJoUQU2mr8iaUQa1VhTpg/cwC7b/LjxAkCtXYOQsnpW3tDvzQhNu6rB5GvRXHNzpHArN177UwaOCSVyFFMokDGbeOoQdWHUasPD8BU1enhYa2zJtLzr3kDbGDtE42eto6JR0AOvK+4mP/aeH+gPeEeYa+8otCb0VYcVRRTrCnqzk5BeeRClL+9DkN0JDz4oCWvUsfazoTpVBbBp+pxW0SYkdHQ/1xGwHgOoRbaHI3kLvVtmO7paxBHH4j1AUeE7kM3C2ZoC8Lm+Eh5Y+56mty0OLc3CYSHoNYcW4AmTi3zWAy3bxLfM3JLx0YXBrnscSZsw4cgwTUcc9voiXyExxLtSSjxkhk6UjtbdRGuqp6vRK5LiqcUp2X1GlGpjza3ZpmxfqW3sFc1yr3J5cWY6CX80OUvrXFkNfZTX9ua64dQFCaz33ZAuN/eG+BuNl8aKSes6NLZjhWmJpazeS2ypCTtFTVEB87kUy8xthXhCHKUVRPxDik4hQjGsf+fTpP+llahgLZ3iTouHgAMEQfNC4bnaTq3GAPFep5XFxnUeaiOCkWjFnxfRP5skz5IHl+i+VocPbD/5F7PhPL+6aLpFhzx2YOPtoX7i+JARRR+Q6Chb2m8OD656TV//uliydSgiHql/JZqYr4JDjSyn8NaWSaYia+0hEdz/vy3uSd+o9kNq49QQSFsq9ao1iDodS57EeAoN6843q2Eq3jiK+duO9NSM4qwNgwiVuXqe5r26ol8tmDWXPWVKhr37J+Tf1ACuGEQW7b0G4VKZIJxL+mUSi3P3/p9YGYT/ZE0yxCB15XcmGbEGL+8WPJIvZu6yRRLczpJ8VX5XqvOHDsLNPI9Jjfwr6a6sACiClFhkldd0ItbVxL9yWcMBPgXoiNwWELkxraZ1Kg9+HZI/MqBQy7wowo4lBjxiOase9L6AumkO/pYX1vzk59rR+fiO5fJ0aUje+80OwOJOgCIKyRu5cTJSkO1ZVzv1uWY52M7N9gH5O9gqnXFjQgXesz/rHcqfjJSYV1cKU+MzmaMsu91FBCBQce6xCueoqhJg12bUBcmR0KCy1SUrXZmdmGuTkgbhk67az X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2044; 6:5iH0q5moI2hoClaemwUcTaPPvh+YiWZzPfgG+TCq4oN6snqCoXS5zpM/QkcSxBTKIk5uR3/JVChQXbfRmGFm69V1xolrlyPM67/x9rqpQKLMFekbmi+nQ3KzydVRDujOaXP9mKlPHTxrM36QtsogphN/dV6D6qneRjbOoH2oQX8yvXSJEABPhnIEVVa5c5TNCTJ922YiSMvfZsB046mw7MtyVP7YFdG15WXc1ufCH0l5WxpPJZz4BS825+g7SF4ie/fO1HmAVeYUVOtvUtz0NYajUaeIr0/i3C33h/OcaL6bZnuGX1zHY0CgYPbqolQJ3IZea4apZpKklvj/5yLmr+JzeeMu/u07Mz1CMENxQwY=; 5:MUcgvofleEpDmPN2CPpuznCdsoWP1rxnzkcCS3LveFob5ZIcQz7JW7rY5R6yOdt1kIFaIkCbkhDYt0hVgDVFsD6zJlBtsYT3qRybVq+csvL/XXg8ehOxUsuIJ3vtTv3XJ9pREapj1e70YX/kcHfL6GHP+1hqGCLYNri0fHIGdMk=; 24:+PvIotr/8q6uF2qkeenFnF5BlyJXDB2wDZGP573C4shwlAfTIYL3EM6ZMQAoUI73xG/PiwPo7yISm6frHvET94YSkt7kXuaoR+FSbjb2rQ8=; 7:0MWw4PmHOAjw1xQkI1qqJokrT5+fSxPeTXHS+u2PKhVlGE/ULiUpU9poR3z3DBLfz4OxPvRIVVmVMe9aZ00is+2hxA3Wh6GI3gkGv2rPwvweabUCYNbPeLT6/db+qcOCxCWvW+62BrYexCU1dZVdYtKj99hNnUfEDzNxVd2nghDPssxX3dSb6Nmr+2fQORZguEBtIEDcVbiPvf4LOPhbkmRR4D1wLRubEG8P0mQOC/QXiXqBeKP7uW5htPaQUsAz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:51:10.9924 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64175d82-ec59-465c-5687-08d57d41865a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2044 Subject: [dpdk-dev] [PATCH] net/mlx5: fix disabling Tx packet inlining X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Adding 'txq_inline=0' to PMD parameter should disable Tx packet inlining but it doesn't work properly for Enhanced Multi-Packet Send. Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for ConnectX-5") Cc: stable@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index dc4ead934..049f7e6c1 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -1382,7 +1382,7 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, (!txq->mpw_hdr_dseg || mpw.total_len >= MLX5_WQE_SIZE); } - if (do_inline) { + if (max_inline && do_inline) { /* Inline packet into WQE. */ unsigned int max;