From patchwork Tue Apr 3 16:01:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chas Williams <3chas3@gmail.com> X-Patchwork-Id: 36971 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3EA311B801; Tue, 3 Apr 2018 18:01:32 +0200 (CEST) Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id CBBB81B7E6; Tue, 3 Apr 2018 18:01:30 +0200 (CEST) Received: by mail-qk0-f195.google.com with SMTP id p67so10631712qke.13; Tue, 03 Apr 2018 09:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=I2M0YpRgOtVqAh5ptChKUZieRRwUbyFijTPeza0tMws=; b=LWGFXK/geoNdwEsHqGMJfdpio0pMDMBK04hF3aPIm3ii/6Ml+ybT9WeTgniwwjEXnS NEaYX18kffh6F02Xoq7nrONo9nvGJUybMm05WelVEDCcwFIASixJole838E1/QuBsR2g mwd43IFn+xgBEnvggy5Re1aU2eS7MZiJXvrpft0ABPG1MIMbKm/nwfNZJivTdayQja31 jSNaqxRgNgHfzfakd0mUNxLYDoc9olGcLybOhCihUOTT8ovzL4wv+6laIdS1r3NWhHkB xICzkKBPCJLIC9DO8NV4+d51fde1xWYz7MT0c9Iov/iebM8d1yNrzVymAKkk5r8kihIP rFXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=I2M0YpRgOtVqAh5ptChKUZieRRwUbyFijTPeza0tMws=; b=o4/kcc/PcmFjlpIl2YcEYQlQer1ltbHMZOfsERalpLszaCDtwzWL3yStcy7syTuALL Npbf2dp4tz3DlXCaY633yxkPifWwka4aDVWXAnc/vBCsAu5z7vnre2xbwrHg5AjcNu18 GPFakEQMjGyNtmVRGebf2sbQ46vsZ5Gy7cyJDunuHIiGHBs4bKmtQv6Y2WfGXK4fms9R DK2IyWZjCI8Y4roZFETfFma0tbnTYHpihWHxQHU5AmtWGnCTiKydHCGvLutuw1swqPqv iiDW2FfyCMnePN4OX0uAsym9vcF3TyPOnGD95P4UAyRH6yWqOf4ESaP0L3TdGNnfTyyX YGlQ== X-Gm-Message-State: ALQs6tBuj2sdls7CH0hlOmpVrOqq7k4wceV5ewPb6LS6Z3FsSP9fssG3 fksypS1/k224/vPPW1AuLlcJ/A== X-Google-Smtp-Source: AIpwx4+psHV9aEnqjziRfmZEmnqZqnFctXh7lQlAK9TG9qbPE7olIJw18FYKxNNQb7XaYj7qcW0dpw== X-Received: by 10.55.191.198 with SMTP id p189mr1858385qkf.205.1522771289693; Tue, 03 Apr 2018 09:01:29 -0700 (PDT) Received: from monolith.home (pool-173-79-224-159.washdc.fios.verizon.net. [173.79.224.159]) by smtp.gmail.com with ESMTPSA id s16sm2484328qks.10.2018.04.03.09.01.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Apr 2018 09:01:29 -0700 (PDT) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: declan.doherty@intel.com, Chas Williams , stable@dpdk.org Date: Tue, 3 Apr 2018 12:01:22 -0400 Message-Id: <20180403160122.25407-1-3chas3@gmail.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH] net/bonding: fix setting VLAN ID on slave ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Chas Williams The pos returned is just the offset of the slab. You need to use this to offset the bits in the slab. Fixes: c771e4ef38 ("net/bonding: enable slave VLAN filter") Cc: stable@dpdk.org Signed-off-by: Chas Williams Acked-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_api.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index f854b7375..d5b7260e4 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -211,9 +211,12 @@ slave_vlan_filter_set(uint16_t bonded_port_id, uint16_t slave_port_id) for (i = 0, mask = 1; i < RTE_BITMAP_SLAB_BIT_SIZE; i ++, mask <<= 1) { - if (unlikely(slab & mask)) + if (unlikely(slab & mask)) { + uint16_t vlan_id = pos + i; + res = rte_eth_dev_vlan_filter(slave_port_id, - (uint16_t)pos, 1); + vlan_id, 1); + } } found = rte_bitmap_scan(internals->vlan_filter_bmp, &pos, &slab);