[dpdk-dev,v2] net/mlx5: fix generic tunnel offloading compatibility check

Message ID 20180524052859.171592-1-shahafs@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Shahaf Shuler
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shahaf Shuler May 24, 2018, 5:28 a.m. UTC
  On some distros, the inbox rdma-core tree can contain the Software
Parser enum while the remaining structs still missing.

Fixes: 5f8ba81c4228 ("net/mlx5: support generic tunnel offloading")
Cc: xuemingl@mellanox.com

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---

On v2:
 - Check only for struct mlx5dv_sw_parsing_caps for the feature enablement.

---
 drivers/net/mlx5/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Yongseok Koh May 24, 2018, 5:45 a.m. UTC | #1
> On May 23, 2018, at 10:28 PM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> 
> On some distros, the inbox rdma-core tree can contain the Software
> Parser enum while the remaining structs still missing.
> 
> Fixes: 5f8ba81c4228 ("net/mlx5: support generic tunnel offloading")
> Cc: xuemingl@mellanox.com
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks
  
Shahaf Shuler May 24, 2018, 11:55 a.m. UTC | #2
Thursday, May 24, 2018 8:46 AM, Yongseok Koh:
> Subject: Re: [PATCH v2] net/mlx5: fix generic tunnel offloading compatibility
> check
> 
> 
> > On May 23, 2018, at 10:28 PM, Shahaf Shuler <shahafs@mellanox.com>
> wrote:
> >
> > On some distros, the inbox rdma-core tree can contain the Software
> > Parser enum while the remaining structs still missing.
> >
> > Fixes: 5f8ba81c4228 ("net/mlx5: support generic tunnel offloading")
> > Cc: xuemingl@mellanox.com
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

> 
> Thanks
  

Patch

diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index 293144e8a0..8a5229e619 100644
--- a/drivers/net/mlx5/Makefile
+++ b/drivers/net/mlx5/Makefile
@@ -120,7 +120,7 @@  mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-config-h.sh
 	$Q sh -- '$<' '$@' \
 		HAVE_IBV_MLX5_MOD_SWP \
 		infiniband/mlx5dv.h \
-		enum MLX5DV_CONTEXT_MASK_SWP \
+		type 'struct mlx5dv_sw_parsing_caps' \
 		$(AUTOCONF_OUTPUT)
 	$Q sh -- '$<' '$@' \
 		HAVE_IBV_MLX5_MOD_MPW \