diff mbox series

[dpdk-dev,v3,10/27] net/ena: add lrte_timer dependency for linking

Message ID 20180607094322.14312-10-mk@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/ena: new features and fixes |

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/checkpatch success coding style OK

Commit Message

Michal Krawczyk June 7, 2018, 9:43 a.m. UTC 
  ENA PMD is required to use librte_timer. The appropriate depndency must
be added ifin case the DPDK will be built as shared library.

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
---
 drivers/net/ena/Makefile | 1 +
 mk/rte.app.mk            | 1 +
 2 files changed, 2 insertions(+)

Comments

Ferruh Yigit June 8, 2018, 7:17 p.m. UTC | #1 
On 6/7/2018 10:43 AM, Michal Krawczyk wrote:
> ENA PMD is required to use librte_timer. The appropriate depndency must
> be added ifin case the DPDK will be built as shared library.
> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> ---
>  drivers/net/ena/Makefile | 1 +
>  mk/rte.app.mk            | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
> index 43339f3b9..ff9ce315b 100644
> --- a/drivers/net/ena/Makefile
> +++ b/drivers/net/ena/Makefile
> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>  LDLIBS += -lrte_bus_pci
> +LDLIBS += -lrte_timer
>  
>  include $(RTE_SDK)/mk/rte.lib.mk
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 1e32c83e7..c70bc254e 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -60,6 +60,7 @@ endif
>  
>  _LDLIBS-y += --whole-archive
>  
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE)        += -lrte_cfgfile
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH)           += -lrte_hash
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMBER)         += -lrte_member

Instead of being separate patch, this should be part of the patch that starts
using rte_timer library.
I guess that is next patch (11/27), if you confirm I can squash this to next
patch while merging.
Michal Krawczyk June 11, 2018, 6:24 a.m. UTC | #2 
2018-06-08 21:17 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 6/7/2018 10:43 AM, Michal Krawczyk wrote:
>> ENA PMD is required to use librte_timer. The appropriate depndency must
>> be added ifin case the DPDK will be built as shared library.
>>
>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>> ---
>>  drivers/net/ena/Makefile | 1 +
>>  mk/rte.app.mk            | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
>> index 43339f3b9..ff9ce315b 100644
>> --- a/drivers/net/ena/Makefile
>> +++ b/drivers/net/ena/Makefile
>> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
>>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>>  LDLIBS += -lrte_bus_pci
>> +LDLIBS += -lrte_timer
>>
>>  include $(RTE_SDK)/mk/rte.lib.mk
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 1e32c83e7..c70bc254e 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -60,6 +60,7 @@ endif
>>
>>  _LDLIBS-y += --whole-archive
>>
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE)        += -lrte_cfgfile
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH)           += -lrte_hash
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMBER)         += -lrte_member
>
> Instead of being separate patch, this should be part of the patch that starts
> using rte_timer library.
> I guess that is next patch (11/27), if you confirm I can squash this to next
> patch while merging.
>

Ok, that's fine to squash it with that patch.
Thomas Monjalon June 17, 2018, 10:37 p.m. UTC | #3 
07/06/2018 11:43, Michal Krawczyk:
> ENA PMD is required to use librte_timer. The appropriate depndency must
> be added ifin case the DPDK will be built as shared library.
> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> ---
>  drivers/net/ena/Makefile | 1 +
>  mk/rte.app.mk            | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
> index 43339f3b9..ff9ce315b 100644
> --- a/drivers/net/ena/Makefile
> +++ b/drivers/net/ena/Makefile
> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>  LDLIBS += -lrte_bus_pci
> +LDLIBS += -lrte_timer
>  
>  include $(RTE_SDK)/mk/rte.lib.mk
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 1e32c83e7..c70bc254e 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -60,6 +60,7 @@ endif
>  
>  _LDLIBS-y += --whole-archive
>  
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer

Why is it added in rte.app.mk? It is already there, few lines below.
Michal Krawczyk June 18, 2018, 6:04 a.m. UTC | #4 
2018-06-18 0:37 GMT+02:00 Thomas Monjalon <thomas@monjalon.net>:
> 07/06/2018 11:43, Michal Krawczyk:
>> ENA PMD is required to use librte_timer. The appropriate depndency must
>> be added ifin case the DPDK will be built as shared library.
>>
>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>> ---
>>  drivers/net/ena/Makefile | 1 +
>>  mk/rte.app.mk            | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
>> index 43339f3b9..ff9ce315b 100644
>> --- a/drivers/net/ena/Makefile
>> +++ b/drivers/net/ena/Makefile
>> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
>>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>>  LDLIBS += -lrte_bus_pci
>> +LDLIBS += -lrte_timer
>>
>>  include $(RTE_SDK)/mk/rte.lib.mk
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 1e32c83e7..c70bc254e 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -60,6 +60,7 @@ endif
>>
>>  _LDLIBS-y += --whole-archive
>>
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
>
> Why is it added in rte.app.mk? It is already there, few lines below.

I think that's because it wasn't present on the version I was
preparing the patch (18.02) and I didn't notice that it was added
meantime when I was rebasing this patch.

This patch is already merged to dpdk-next-net. Should I add a patch
that is reverting this change there?
Thomas Monjalon June 18, 2018, 8:30 a.m. UTC | #5 
18/06/2018 08:04, Michał Krawczyk:
> 2018-06-18 0:37 GMT+02:00 Thomas Monjalon <thomas@monjalon.net>:
> > 07/06/2018 11:43, Michal Krawczyk:
> >> ENA PMD is required to use librte_timer. The appropriate depndency must
> >> be added ifin case the DPDK will be built as shared library.
> >>
> >> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> >> ---
> >>  drivers/net/ena/Makefile | 1 +
> >>  mk/rte.app.mk            | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
> >> index 43339f3b9..ff9ce315b 100644
> >> --- a/drivers/net/ena/Makefile
> >> +++ b/drivers/net/ena/Makefile
> >> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
> >>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> >>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
> >>  LDLIBS += -lrte_bus_pci
> >> +LDLIBS += -lrte_timer
> >>
> >>  include $(RTE_SDK)/mk/rte.lib.mk
> >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> >> index 1e32c83e7..c70bc254e 100644
> >> --- a/mk/rte.app.mk
> >> +++ b/mk/rte.app.mk
> >> @@ -60,6 +60,7 @@ endif
> >>
> >>  _LDLIBS-y += --whole-archive
> >>
> >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
> >
> > Why is it added in rte.app.mk? It is already there, few lines below.
> 
> I think that's because it wasn't present on the version I was
> preparing the patch (18.02) and I didn't notice that it was added
> meantime when I was rebasing this patch.
> 
> This patch is already merged to dpdk-next-net. Should I add a patch
> that is reverting this change there?

I can remove it when pulling next-net today.
Michal Krawczyk June 18, 2018, 8:32 a.m. UTC | #6 
2018-06-18 10:30 GMT+02:00 Thomas Monjalon <thomas@monjalon.net>:
>
> 18/06/2018 08:04, Michał Krawczyk:
> > 2018-06-18 0:37 GMT+02:00 Thomas Monjalon <thomas@monjalon.net>:
> > > 07/06/2018 11:43, Michal Krawczyk:
> > >> ENA PMD is required to use librte_timer. The appropriate depndency must
> > >> be added ifin case the DPDK will be built as shared library.
> > >>
> > >> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> > >> ---
> > >>  drivers/net/ena/Makefile | 1 +
> > >>  mk/rte.app.mk            | 1 +
> > >>  2 files changed, 2 insertions(+)
> > >>
> > >> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
> > >> index 43339f3b9..ff9ce315b 100644
> > >> --- a/drivers/net/ena/Makefile
> > >> +++ b/drivers/net/ena/Makefile
> > >> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
> > >>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> > >>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
> > >>  LDLIBS += -lrte_bus_pci
> > >> +LDLIBS += -lrte_timer
> > >>
> > >>  include $(RTE_SDK)/mk/rte.lib.mk
> > >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> > >> index 1e32c83e7..c70bc254e 100644
> > >> --- a/mk/rte.app.mk
> > >> +++ b/mk/rte.app.mk
> > >> @@ -60,6 +60,7 @@ endif
> > >>
> > >>  _LDLIBS-y += --whole-archive
> > >>
> > >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
> > >
> > > Why is it added in rte.app.mk? It is already there, few lines below.
> >
> > I think that's because it wasn't present on the version I was
> > preparing the patch (18.02) and I didn't notice that it was added
> > meantime when I was rebasing this patch.
> >
> > This patch is already merged to dpdk-next-net. Should I add a patch
> > that is reverting this change there?
>
> I can remove it when pulling next-net today.

Ok, that will be fine, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
index 43339f3b9..ff9ce315b 100644
--- a/drivers/net/ena/Makefile
+++ b/drivers/net/ena/Makefile
@@ -58,5 +58,6 @@  CFLAGS += $(INCLUDES)
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
 LDLIBS += -lrte_bus_pci
+LDLIBS += -lrte_timer
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 1e32c83e7..c70bc254e 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -60,6 +60,7 @@  endif
 
 _LDLIBS-y += --whole-archive
 
+_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
 _LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE)        += -lrte_cfgfile
 _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH)           += -lrte_hash
 _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMBER)         += -lrte_member