[v2,1/2] eal: remove deprecated function returning mbuf pool ops name
Checks
Commit Message
rte_eal_mbuf_default_mempool_ops() is replaced by
rte_mbuf_best_mempool_ops().
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
v2:
* remove rte_eal_mbuf_user_pool_ops from .map in next patch instead of this
doc/guides/rel_notes/deprecation.rst | 9 ---------
lib/librte_eal/bsdapp/eal/eal.c | 10 ----------
lib/librte_eal/common/include/rte_eal.h | 11 -----------
lib/librte_eal/linuxapp/eal/eal.c | 10 ----------
lib/librte_eal/rte_eal_version.map | 1 -
5 files changed, 41 deletions(-)
Comments
On 26-Jun-18 10:56 AM, Olivier Matz wrote:
> rte_eal_mbuf_default_mempool_ops() is replaced by
> rte_mbuf_best_mempool_ops().
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
On Tuesday 26 June 2018 03:26 PM, Olivier Matz wrote:
> External Email
>
> rte_eal_mbuf_default_mempool_ops() is replaced by
> rte_mbuf_best_mempool_ops().
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
26/06/2018 11:56, Olivier Matz:
> rte_eal_mbuf_default_mempool_ops() is replaced by
> rte_mbuf_best_mempool_ops().
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>
> v2:
> * remove rte_eal_mbuf_user_pool_ops from .map in next patch instead of this
>
> doc/guides/rel_notes/deprecation.rst | 9 ---------
> lib/librte_eal/bsdapp/eal/eal.c | 10 ----------
> lib/librte_eal/common/include/rte_eal.h | 11 -----------
> lib/librte_eal/linuxapp/eal/eal.c | 10 ----------
> lib/librte_eal/rte_eal_version.map | 1 -
> 5 files changed, 41 deletions(-)
Please bump ABI version and update the release notes.
Thanks
26/07/2018 23:42, Thomas Monjalon:
> 26/06/2018 11:56, Olivier Matz:
> > rte_eal_mbuf_default_mempool_ops() is replaced by
> > rte_mbuf_best_mempool_ops().
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> >
> > v2:
> > * remove rte_eal_mbuf_user_pool_ops from .map in next patch instead of this
> >
> > doc/guides/rel_notes/deprecation.rst | 9 ---------
> > lib/librte_eal/bsdapp/eal/eal.c | 10 ----------
> > lib/librte_eal/common/include/rte_eal.h | 11 -----------
> > lib/librte_eal/linuxapp/eal/eal.c | 10 ----------
> > lib/librte_eal/rte_eal_version.map | 1 -
> > 5 files changed, 41 deletions(-)
>
> Please bump ABI version and update the release notes.
> Thanks
Olivier, ping!
@@ -37,15 +37,6 @@ Deprecation Notices
- ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse``
- ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp``
-* eal: a new set of mbuf mempool ops name APIs for user, platform and best
- mempool names have been defined in ``rte_mbuf`` in v18.02. The uses of
- ``rte_eal_mbuf_default_mempool_ops`` shall be replaced by
- ``rte_mbuf_best_mempool_ops``.
- The following function is deprecated since 18.05, and will be removed
- in 18.08:
-
- - ``rte_eal_mbuf_default_mempool_ops``
-
* mbuf: The opaque ``mbuf->hash.sched`` field will be updated to support generic
definition in line with the ethdev TM and MTR APIs. Currently, this field
is defined in librte_sched in a non-generic way. The new generic format
@@ -153,16 +153,6 @@ rte_eal_mbuf_user_pool_ops(void)
return internal_config.user_mbuf_pool_ops_name;
}
-/* Return mbuf pool ops name */
-const char *
-rte_eal_mbuf_default_mempool_ops(void)
-{
- if (internal_config.user_mbuf_pool_ops_name == NULL)
- return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
-
- return internal_config.user_mbuf_pool_ops_name;
-}
-
/* Return a pointer to the configuration structure */
struct rte_config *
rte_eal_get_configuration(void)
@@ -501,17 +501,6 @@ enum rte_iova_mode rte_eal_iova_mode(void);
const char * __rte_experimental
rte_eal_mbuf_user_pool_ops(void);
-/**
- * @deprecated
- * Get default pool ops name for mbuf
- *
- * @return
- * returns default pool ops name.
- */
-__rte_deprecated
-const char *
-rte_eal_mbuf_default_mempool_ops(void);
-
#ifdef __cplusplus
}
#endif
@@ -161,16 +161,6 @@ rte_eal_mbuf_user_pool_ops(void)
return internal_config.user_mbuf_pool_ops_name;
}
-/* Return mbuf pool ops name */
-const char *
-rte_eal_mbuf_default_mempool_ops(void)
-{
- if (internal_config.user_mbuf_pool_ops_name == NULL)
- return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
-
- return internal_config.user_mbuf_pool_ops_name;
-}
-
/* Return a pointer to the configuration structure */
struct rte_config *
rte_eal_get_configuration(void)
@@ -181,7 +181,6 @@ DPDK_17.11 {
rte_bus_get_iommu_class;
rte_eal_has_pci;
rte_eal_iova_mode;
- rte_eal_mbuf_default_mempool_ops;
rte_eal_using_phys_addrs;
rte_eal_vfio_intr_mode;
rte_lcore_has_role;