[2/2] app/testpmd: fix help string for tm commit cmd

Message ID 20180710065100.29511-2-krzysztof.kanas@caviumnetworks.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [1/2] app/testpmd: fix use of uninitialized field |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Krzysztof Kanas July 10, 2018, 6:51 a.m. UTC
  Fixes: 86dd86088506 ("app/testpmd: fix use of uninitialized field")
Cc: krzysztof.kanas@caviumnetworks.com

Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
---
 app/test-pmd/cmdline_tm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Iremonger, Bernard July 18, 2018, 8:51 a.m. UTC | #1
Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kanas [mailto:krzysztof.kanas@caviumnetworks.com]
> Sent: Tuesday, July 10, 2018 7:51 AM
> To: krzysztof.kanas@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Iremonger,
> Bernard <bernard.iremonger@intel.com>
> Cc: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>
> Subject: [PATCH 2/2] app/testpmd: fix help string for tm commit cmd
> 
> Fixes: 86dd86088506 ("app/testpmd: fix use of uninitialized field")
> Cc: krzysztof.kanas@caviumnetworks.com
> 
> Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
> ---
>  app/test-pmd/cmdline_tm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index
> 4f515241703a..09acc1b87293 100644
> --- a/app/test-pmd/cmdline_tm.c
> +++ b/app/test-pmd/cmdline_tm.c
> @@ -2172,7 +2172,7 @@ static void
> cmd_port_tm_hierarchy_commit_parsed(void *parsed_result,
> cmdline_parse_inst_t cmd_port_tm_hierarchy_commit = {
>  	.f = cmd_port_tm_hierarchy_commit_parsed,
>  	.data = NULL,
> -	.help_str = "Set port tm node shaper profile",
> +	.help_str = "Commit port tm hierarchy",
>  	.tokens = {
>  		(void *)&cmd_port_tm_hierarchy_commit_port,
>  		(void *)&cmd_port_tm_hierarchy_commit_tm,
> --
> 2.18.0

check-git-log.sh is giving the following error:

./devtools/check-git-log.sh -1
Wrong 'Fixes' reference:
        Fixes: 86dd86088506 ("app/testpmd: fix use of uninitialized field")

Regards,

Bernard.
  

Patch

diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
index 4f515241703a..09acc1b87293 100644
--- a/app/test-pmd/cmdline_tm.c
+++ b/app/test-pmd/cmdline_tm.c
@@ -2172,7 +2172,7 @@  static void cmd_port_tm_hierarchy_commit_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_port_tm_hierarchy_commit = {
 	.f = cmd_port_tm_hierarchy_commit_parsed,
 	.data = NULL,
-	.help_str = "Set port tm node shaper profile",
+	.help_str = "Commit port tm hierarchy",
 	.tokens = {
 		(void *)&cmd_port_tm_hierarchy_commit_port,
 		(void *)&cmd_port_tm_hierarchy_commit_tm,