diff mbox series

[05/10] crypto/caam_jr: add queue config functions

Message ID	20180913060846.29930-6-g.singh@nxp.com (mailing list archive)
State	Superseded, archived
Delegated to:	akhil goyal
Headers	From: Gagandeep Singh <g.singh@nxp.com> To: dev@dpdk.org, akhil.goyal@nxp.com Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, Gagandeep Singh <g.singh@nxp.com> Date: Thu, 13 Sep 2018 11:38:41 +0530 Message-Id: <20180913060846.29930-6-g.singh@nxp.com> In-Reply-To: <20180913060846.29930-1-g.singh@nxp.com> References: <20180913060846.29930-1-g.singh@nxp.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR04MB1529; 23:f5ozKjpJcc58cWMGBQ6mCKIpBOnXl4ty4+QjssWRg?= ISIG9JiITej9jMuZ65baY+R7LmQbMa3IlTqVcvCHMzthxOe65e4AUQfyMWDmmQQqYuZb5dY6cVSssw6xWFP+/WmPHKQHeZ0yeY4CTu1a+AAdoLX9ER75RJt1mRKzEYEQpzhGo+sk5lzj+i8G6kQP9zIe/msH9XdJijF22QdKQpvw7ab9QRKwXiZ1AuADs2PzxTjCefO831gpClTwcFePCZ6TyQsXr0Rn9F69vGJMF2e2Wql6OX7TGz6d0UuLiuOyrUhBfaPxGuXzFOqfGpkop6TvdJibF9jg1ZtRZPIZSsIf3n8c9ZY5JtnGNZz9hu0FavaOkaw2QxRKnd5OQGcScydhWx1keFD5EiKTZbFqxLwvbTP2h8pl6JZ48nk8fYLdoNSp+DeGuYbw0jgX6C2ToRhAG2SrDpK+r1DeNwgcWeM7+3KQwGsOBI+wydZoHK0DKF0jFGBnBGMZ+UqwcZo0jh2PtM4M+NuSPpyk6zQRM/PsPokBf+IGA25YD7QwO/D23dZSbeEokv4phtXlLAhYT/P6BeteUQsmWsrNxoAnxbExETDtwGIFO6TS41BFknr7TGAFjc0tnMrWSXHGg5mV/Dt9Jp8B3/LlAcjvySLbOGC/Ss29X5xI3oORoW05Vumc9eJtUPehAF6NcPa1Y+h3Bd1HYBTBdE3QR1FaVTFv2AH/ZgN1XwR9Ly7nqWJePb7zJTCIWgu+Vx+TAVKFApOE7vFamjMQmiRFpxWBxnPGWNEAsMz8SEzEdzH1L8Ci6Q181ODasJoJ6uPyxwahHBSCWZ5E+YdfNCeVwddQIaP+N25iHfcxlYUlv57YHj81GxBFM6USs2OGQU0YtbNcsFDvVQBGr8xdYNxeS+68bpDD3AOdpDYLEdNzkic2SLG9SwXNa1n6Zz4Je9DztXJfTW9wkVFW34/2E2Tnzop2JK9L8bNgCngcp7AE0cqk0VGY/qOQR/JfpmbyGI60jwiBkmgShM90U7EBqE1VIz4J68rOEUAbi6fNNVZrssDyGABCJC526uZfnho+a14b6D3w5Ho88WS82N+fGt11WlmmnR+3SqhoMiH8mX1AlNdQZv2VMfVKGDfiRHD2uhRu7MdU5XMgDELrmAeZ/QeRqzoWgpD3m7T4fAB3ImiIZpkxOwCXoaZ38lnxcFeXCOS85w2MG0D6hsSDpo1x/FHrDkZzNPtolq3RzcX0MYzifyCzwl7GONojmb54I3L8TefRYidCcpN5COwLe0YAZCYjiLE39DJCHL5wYvUWqsqCvotovqu6fwe/smKsvvMo4RTyIGr5E3PtWUd X-Microsoft-Antispam-Message-Info: Gx1Lq3c0d22VWSHXG5L1i9B588WEJpzIc+lg+rPfauZ/XcbjQ2SVZUstn11/vgdWZT0IMQOrSoR9hcpigC+PhzvnVQtZ4uxOlOxX5vTb9EX4KRPgtucmjBhBDSzFljvCwFnT5logmhLeL+055cqvrB4mMLu7UP/F351Y0VTOFKg/erDW/6mk96ETe4QPSlpMHXkOaoy/5W0YTsXuD805p0CRHxYUdVDemSe5EDHrxkOBkmqda9KFQy58Zzzw7ulmSY3WVxMHXFQDyuDE7bTVKIBGifWTzNF2YQvvk2/E6ccCMXUGqOHFcDz1voWf2JgnI+RZUG51kxFTWPDiboQSJHIvhJ9qRA03Z2SSoG2J0OM= X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1529; 6:nXh8fOqZ4e4IgCq8P6riv+kq34bjh66bZHWTENM8Oa0Il8rMTBayt3U/z9Hp8dMVQa2AQIgs/EnBg+lvkaYC2fkN8P7PsjZ6L8Z1eAOmkMgYGe/fopKGdvIdZwLXgC5GlGbOusTz2T/YzmuPgwYI3+vAYpvRrgBAZVIX5oA9XMhjdUN3YMrwlZqLxIVmjPSnT9fwHTPlGBY6OIKgs81qRICViA77KCtqRsPif0enRlWKjC5zM64nTpS+DxKtio6GvDF1JzYLxiao0xUR8/iwbJDSUr+btc4N9/krPtdoirE5UwsBDTUK9JdIZUiJbnRTahsBQK6Nrn1yIsbJ2GsM9xV3FPx0jRS69PbmN7Gzq7dfetCyf8YqgFPvDtUiNbucO6mItv8Wu/RBgqq8ePyE7fFMuIi24Q+vINQcDilMN94ii2rOxSB3gJMu8IpiwajHJbKc/R5E+JqR3p2D2qbc5w==; 5:PjGJQyXejwYtnn+7fjbiQQeIbTpKF+fRj0Vm57CnuAFcj62h20fB6DaItp5d+LLYFmPwL0PQTktDCBMHzOau0utRhr0a/P8O7vIXC82SWWGQCCkwuEfePOIVHJXnAwH4d7B3osX1D72KtZ+yk4pbVyhAYUA+C2hSDamCDmqcHpE=; 7:6nRZGplEZB3Zqa3ClxaxevwUAgIAY5Ft7tO2xu2n1FoAWyTHPD6qnga1J+L4s0o3l33d0UjTnVaD263Cq5AE7fA5FGz691oM7U2Sfhh4gwYaOwh7LySD7Ul5iwjzL8l8Vs1I5WES9ou8O9zh7doJLsLzOM1InfqFUYUyqetqECwwwrJ8oDSjiSPix2/9cBKwMgo6EftvoXy+nslJZtEG+BL50dfVy7gzXxrCwB2hfsgkatECIt4JIDYXCgwmFsiN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM Subject: [dpdk-dev] [PATCH 05/10] crypto/caam_jr: add queue config functions Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Introducing the NXP CAAM job ring driver \| [00/10] Introducing the NXP CAAM job ring driver [01/10] doc: add caam jr cryptodev details [02/10] crypto/caam_jr: introduce basic driver [03/10] crypto/caam_jr: add HW config for job rings [04/10] crypto/caam_jr: add device configuration routines [05/10] crypto/caam_jr: add queue config functions [06/10] crypto/caam_jr: add basic session config routines [07/10] crypto/caam_jr: add enqueue and dequeue routines [08/10] crypto/caam_jr: add auth cipher and aead session support [09/10] crypto/caam_jr: add stats support [10/10] crypto/caam_jr: add security offload support

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	fail	Compilation issues

Commit Message

Gagandeep Singh Sept. 13, 2018, 6:08 a.m. UTC

  From: Hemant Agrawal <hemant.agrawal@nxp.com>

Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/crypto/caam_jr/caam_jr.c | 64 ++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

Comments

Akhil Goyal Sept. 18, 2018, 2:04 p.m. UTC | #1

Hi Gagan,

On 9/13/2018 11:38 AM, Gagandeep Singh wrote:
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>   drivers/crypto/caam_jr/caam_jr.c | 64 ++++++++++++++++++++++++++++++++
>   1 file changed, 64 insertions(+)
>
> diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
> index 43fe5233b..f05e966b0 100644
> --- a/drivers/crypto/caam_jr/caam_jr.c
> +++ b/drivers/crypto/caam_jr/caam_jr.c
> @@ -104,6 +104,67 @@ static void hw_flush_job_ring(struct sec_job_ring_t *job_ring,
>   	}
>   }
>   
> +/* Release queue pair */
> +static int
> +caam_jr_queue_pair_release(struct rte_cryptodev *dev,
> +			    uint16_t qp_id)
> +{
> +	struct sec_job_ring_t *internals;
> +	struct caam_jr_qp *qp = NULL;
> +
> +	PMD_INIT_FUNC_TRACE();
> +
> +	CAAM_JR_DEBUG("dev =%p, queue =%d", dev, qp_id);
> +
> +	internals = dev->data->dev_private;
> +	if (qp_id >= internals->max_nb_queue_pairs) {
> +		CAAM_JR_ERR("Max supported qpid %d",
> +			     internals->max_nb_queue_pairs);
> +		return -EINVAL;
> +	}
> +
> +	qp = &internals->qps[qp_id];
> +	qp->ring = NULL;
> +	dev->data->queue_pairs[qp_id] = NULL;
> +
> +	return 0;
> +}
> +
> +/* Setup a queue pair */
> +static int
> +caam_jr_queue_pair_setup(
> +		struct rte_cryptodev *dev, uint16_t qp_id,
> +		__rte_unused const struct rte_cryptodev_qp_conf *qp_conf,
> +		__rte_unused int socket_id,
> +		__rte_unused struct rte_mempool *session_pool)
> +{
> +	struct sec_job_ring_t *internals;
> +	struct caam_jr_qp *qp = NULL;
> +

PMD_INIT_FUNC_TRACE(); missing here and please check other ops as well

> +	CAAM_JR_DEBUG("dev =%p, queue =%d, conf =%p", dev, qp_id, qp_conf);
> +
> +	internals = dev->data->dev_private;
> +	if (qp_id >= internals->max_nb_queue_pairs) {
> +		CAAM_JR_ERR("Max supported qpid %d",
> +			     internals->max_nb_queue_pairs);
> +		return -EINVAL;
> +	}
> +
> +	qp = &internals->qps[qp_id];
> +	qp->ring = internals;
> +	dev->data->queue_pairs[qp_id] = qp;
> +
> +	return 0;
> +}
> +
> +/* Return the number of allocated queue pairs */
> +static uint32_t
> +caam_jr_queue_pair_count(struct rte_cryptodev *dev)
> +{
> +	PMD_INIT_FUNC_TRACE();
> +
> +	return dev->data->nb_queue_pairs;
> +}
>   
>   static int
>   caam_jr_dev_configure(struct rte_cryptodev *dev,
> @@ -186,6 +247,9 @@ static struct rte_cryptodev_ops caam_jr_ops = {
>   	.dev_stop	      = caam_jr_dev_stop,
>   	.dev_close	      = caam_jr_dev_close,
>   	.dev_infos_get        = caam_jr_dev_infos_get,
> +	.queue_pair_setup     = caam_jr_queue_pair_setup,
> +	.queue_pair_release   = caam_jr_queue_pair_release,
> +	.queue_pair_count     = caam_jr_queue_pair_count,
>   };
>   
>

Gagandeep Singh Oct. 12, 2018, 1:39 p.m. UTC | #2

Hi,

> -----Original Message-----
> From: Akhil Goyal
> Sent: Tuesday, September 18, 2018 7:35 PM
> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: Re: [dpdk-dev] [PATCH 05/10] crypto/caam_jr: add queue config
> functions
> 
> Hi Gagan,
> 
> On 9/13/2018 11:38 AM, Gagandeep Singh wrote:
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> >
> > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >   drivers/crypto/caam_jr/caam_jr.c | 64
> ++++++++++++++++++++++++++++++++
> >   1 file changed, 64 insertions(+)
> >
> > diff --git a/drivers/crypto/caam_jr/caam_jr.c
> > b/drivers/crypto/caam_jr/caam_jr.c
> > index 43fe5233b..f05e966b0 100644
> > --- a/drivers/crypto/caam_jr/caam_jr.c
> > +++ b/drivers/crypto/caam_jr/caam_jr.c
> > @@ -104,6 +104,67 @@ static void hw_flush_job_ring(struct sec_job_ring_t
> *job_ring,
> >   	}
> >   }
> >
> > +/* Release queue pair */
> > +static int
> > +caam_jr_queue_pair_release(struct rte_cryptodev *dev,
> > +			    uint16_t qp_id)
> > +{
> > +	struct sec_job_ring_t *internals;
> > +	struct caam_jr_qp *qp = NULL;
> > +
> > +	PMD_INIT_FUNC_TRACE();
> > +
> > +	CAAM_JR_DEBUG("dev =%p, queue =%d", dev, qp_id);
> > +
> > +	internals = dev->data->dev_private;
> > +	if (qp_id >= internals->max_nb_queue_pairs) {
> > +		CAAM_JR_ERR("Max supported qpid %d",
> > +			     internals->max_nb_queue_pairs);
> > +		return -EINVAL;
> > +	}
> > +
> > +	qp = &internals->qps[qp_id];
> > +	qp->ring = NULL;
> > +	dev->data->queue_pairs[qp_id] = NULL;
> > +
> > +	return 0;
> > +}
> > +
> > +/* Setup a queue pair */
> > +static int
> > +caam_jr_queue_pair_setup(
> > +		struct rte_cryptodev *dev, uint16_t qp_id,
> > +		__rte_unused const struct rte_cryptodev_qp_conf *qp_conf,
> > +		__rte_unused int socket_id,
> > +		__rte_unused struct rte_mempool *session_pool) {
> > +	struct sec_job_ring_t *internals;
> > +	struct caam_jr_qp *qp = NULL;
> > +
> 
> PMD_INIT_FUNC_TRACE(); missing here and please check other ops as well
ok
> 
> > +	CAAM_JR_DEBUG("dev =%p, queue =%d, conf =%p", dev, qp_id,
> qp_conf);
> > +
> > +	internals = dev->data->dev_private;
> > +	if (qp_id >= internals->max_nb_queue_pairs) {
> > +		CAAM_JR_ERR("Max supported qpid %d",
> > +			     internals->max_nb_queue_pairs);
> > +		return -EINVAL;
> > +	}
> > +
> > +	qp = &internals->qps[qp_id];
> > +	qp->ring = internals;
> > +	dev->data->queue_pairs[qp_id] = qp;
> > +
> > +	return 0;
> > +}
> > +
> > +/* Return the number of allocated queue pairs */ static uint32_t
> > +caam_jr_queue_pair_count(struct rte_cryptodev *dev) {
> > +	PMD_INIT_FUNC_TRACE();
> > +
> > +	return dev->data->nb_queue_pairs;
> > +}
> >
> >   static int
> >   caam_jr_dev_configure(struct rte_cryptodev *dev, @@ -186,6 +247,9 @@
> > static struct rte_cryptodev_ops caam_jr_ops = {
> >   	.dev_stop	      = caam_jr_dev_stop,
> >   	.dev_close	      = caam_jr_dev_close,
> >   	.dev_infos_get        = caam_jr_dev_infos_get,
> > +	.queue_pair_setup     = caam_jr_queue_pair_setup,
> > +	.queue_pair_release   = caam_jr_queue_pair_release,
> > +	.queue_pair_count     = caam_jr_queue_pair_count,
> >   };
> >
> >

diff mbox series

Patch

diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 43fe5233b..f05e966b0 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -104,6 +104,67 @@  static void hw_flush_job_ring(struct sec_job_ring_t *job_ring,
 	}
 }
 
+/* Release queue pair */
+static int
+caam_jr_queue_pair_release(struct rte_cryptodev *dev,
+			    uint16_t qp_id)
+{
+	struct sec_job_ring_t *internals;
+	struct caam_jr_qp *qp = NULL;
+
+	PMD_INIT_FUNC_TRACE();
+
+	CAAM_JR_DEBUG("dev =%p, queue =%d", dev, qp_id);
+
+	internals = dev->data->dev_private;
+	if (qp_id >= internals->max_nb_queue_pairs) {
+		CAAM_JR_ERR("Max supported qpid %d",
+			     internals->max_nb_queue_pairs);
+		return -EINVAL;
+	}
+
+	qp = &internals->qps[qp_id];
+	qp->ring = NULL;
+	dev->data->queue_pairs[qp_id] = NULL;
+
+	return 0;
+}
+
+/* Setup a queue pair */
+static int
+caam_jr_queue_pair_setup(
+		struct rte_cryptodev *dev, uint16_t qp_id,
+		__rte_unused const struct rte_cryptodev_qp_conf *qp_conf,
+		__rte_unused int socket_id,
+		__rte_unused struct rte_mempool *session_pool)
+{
+	struct sec_job_ring_t *internals;
+	struct caam_jr_qp *qp = NULL;
+
+	CAAM_JR_DEBUG("dev =%p, queue =%d, conf =%p", dev, qp_id, qp_conf);
+
+	internals = dev->data->dev_private;
+	if (qp_id >= internals->max_nb_queue_pairs) {
+		CAAM_JR_ERR("Max supported qpid %d",
+			     internals->max_nb_queue_pairs);
+		return -EINVAL;
+	}
+
+	qp = &internals->qps[qp_id];
+	qp->ring = internals;
+	dev->data->queue_pairs[qp_id] = qp;
+
+	return 0;
+}
+
+/* Return the number of allocated queue pairs */
+static uint32_t
+caam_jr_queue_pair_count(struct rte_cryptodev *dev)
+{
+	PMD_INIT_FUNC_TRACE();
+
+	return dev->data->nb_queue_pairs;
+}
 
 static int
 caam_jr_dev_configure(struct rte_cryptodev *dev,
@@ -186,6 +247,9 @@  static struct rte_cryptodev_ops caam_jr_ops = {
 	.dev_stop	      = caam_jr_dev_stop,
 	.dev_close	      = caam_jr_dev_close,
 	.dev_infos_get        = caam_jr_dev_infos_get,
+	.queue_pair_setup     = caam_jr_queue_pair_setup,
+	.queue_pair_release   = caam_jr_queue_pair_release,
+	.queue_pair_count     = caam_jr_queue_pair_count,
 };