diff mbox series

[3/3] net/mlx5: eswitch-modify MAC address actions

Message ID	20180925150340.25378-4-jackmin@mellanox.com (mailing list archive)
State	Superseded, archived
Delegated to:	Ferruh Yigit
Headers	From: Xiaoyu Min <jackmin@mellanox.com> To: ferruh.yigit@intel.com, Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com> Cc: dev@dpdk.org Date: Tue, 25 Sep 2018 23:03:40 +0800 Message-Id: <20180925150340.25378-4-jackmin@mellanox.com> In-Reply-To: <20180925150340.25378-1-jackmin@mellanox.com> References: <20180925150340.25378-1-jackmin@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2031; 23:M8rvPtUdKG4NBBh2gTyUydlkwtJvTSyUz+yvt/x?= opzc/vYOlOZivO/BuManwBtiOaamBr0+u9UhxinbyCLtNoUVdnnpB1gD5D6zo8CDz69nZRdTQaPO2y5zUA86PRYjb/iUjDTrDBlVTPZmx3jgdBnMel+qeJpnsfIr0myNEZ9uUqiyUkrqbjB8+v/TpYhb1/XZX1pARACZ8qVSdWuGNX+5Aj8TfpeUkx9CDK43hp9YzdNVhnr1Wygwz38crQeMme8k0RbD7o4B3xhbgk9HQapPZYvAJWzohI5gCtmVcRk0WN+K4L3a4GHnaKYClZvuUzNrxtKKXOdZMA/neKNOdkW+l80BY8lp/BqJqg/8ZzHW3ClU+Zic7fxk4qvEQNR6J/tWH1v9qL/taYsWHQGq2UM5Agz9ksOWkw0W2/07iPfKektILOuSTfljmtlByrwTxDTUHcQi+PYmfulrsX8dgHey4R34lqSa0MGetMuvUfgFi1OeAwKwUhM93efMgooVWBQbYForGREK1rBnbo5WXiy4Y/b9UWWDVclvzpxoD7lGj7v9bW8D5ai0D623BJZ6Dt7eFuGUhXsZ3m/1+KH2mdfC3tjiKEWVv26sUDBX/n3MqAWolxALfjYpkK7dUW2xhsUxE/p87QzmASuY8gFid6PDGcspcFEOZJVdyoNV0XUr8qdv9xx/NWik/a7YyvjoF4Y+6xlJt7WaYoYNy1kWmZhFzJhewwMFEBlQLN4/ah/4h8zudtyEr+2nWcKuLFY6xjWn2u1UgX+OFlIdBA1EtS0vCLjtR+LCyC11Z/KyyscFHPORY5NctOsPh62jInZBvJBoJjYFHR9UCfeGoo18dNq8NtpqcjnKSeX9X/dXomX7FylPQ7YxgKEX/+Cne+9WPj5U0V9v4Ae6uF9FmDKEMM/5TgVCLlsQ62B+d0Rud9vUm5n3eI1bO/OuCsm4nN2UAAVgd0VvIXwlfUjqVv4/6J3mAsVqeSgrJE4k3S/dpsLLOl2SxqYpRkZycgiIgT2/LHO8CZkkWazwj3DmDNwyTrvkZMdz8+ZiTVQLeTJBaPlkNwpjlYL00crufr58LP4QwTNr3Z/2WGqeiP8n6PhzEB6ip/fJz4/VTU5JT96VaMO3/GBNnvEODMvSYy5AzGVU/qyphGWYaf9wOaJ10TtafkxDmZ5bsd38yO3gAXL+oh7P3zQacJFPFZUnkBOPMp0cRDaVKI5ibCceW3n5lx5OZs2SBeFhpg/jINaTVBU+PSAkso5oWPFgGeKwAUkdcN05O X-Microsoft-Antispam-Message-Info: IK0SGPGYhfGHdysr4ajWnYE0HkcmMsRTMaAUUiyHuy/dNswDs4+UPRE/CR2sGWej8GWMg30aGH29/qIc7zDH6X0Rb+CQYrGzYxJCalc82Fp/v5ngQuzxE5vFDRJpNPEh+WOWmQnRaxZtssEpNWbLdOJM8nK1KQqXqaG5C5yx+Y5X7sNMD8KERqZJSn9Mp+kJPJIZq9s/e0tgtz868xuN6Y+ZDN/Na2ApapB8rFyb3/HH0iKvPdAH9+xeWKf6zP9ZlI1duVCwH6KFXGl9+XURqrwB+LhCtNSbnUTPpXeJ1DMQ7QF4Kf7zIlPLb13asTFmX83btDyNS4HArBkf5uBjNxhixB1tCYDWB5DOBpB7M2Q= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2031; 6:5cKNHPgj7gK2iFB3FTOvjfrBe5Ttx6v+y/OMjOCTHUwBUNU9Fc/Q+MLL6C0yj2DicGDu31AZsMt0T8hdqyB0+Tl0PqnewxcXgexwjYUB8yOsIf3Tx8dQnfTHr+fe8OkXioNaq1ht7v8OS93BxMehFn31DoGPoaL6sGWSmN/Km7hz+zuHzfBMFLbvq17YZKKNxR/ccNIrBAuZlwwp+p2HmNyeJNF42PkAMmi5v2fQE7qJT1L90SsM4IJpEt0AzSp/cKT7Eswy+CxjohXN6QSPgqObAqXQ/uyP71rXrLWRnZkJR9TIjdZY+kIv2CzMX1kS84Qew5+KKO84DFdsMwLoyJeFGrf7hvNzUNHYn4dc6I3j9x5rxYvz2pDEwRL+ojN7aAJwwvMhkncZ8MMPoRpO8jDmFNU6ztf0rs5sdWo8VOx61CAVnh8aVzZj3Oe2hpqJcBYKaI4xcHBt7Lb8xkNBDw==; 5:c/ccgclj8Vu4Pk2eVtyfve1xDnjngKTFl/kNZ2BWTr7oU8TgCiGHhm8TFH3zncyCK0yZOnhAcJ8POxKTf4nR2VDVRWq+Pvz4FPGEi4cWW4cvxhGlPb53HXc2XqXf0L4IiSaxCUdcrasxSSb+F5Ij0yV5mHOtqrWGhIG+VCt45Ak=; 7:jO/kOhMFpvDRzTtVseY10fnXE63h0AMWIgvXBnpVhUcsHpH8c2DLK6kuEbtCK6m4QA/ckbApTbw27VVeEK7cHM9P0BARnSPKvzyBYcGAQWbMh5tIJpVE8Mt3+Zl6LpA1Hxdrk7+EG0/ZOPwWtrJv2UrQ+bS0MPkI+k5M/A6hGt2aGFZm428wELSlNOViWyV0/xePqg4Otjsz/FYQbZQkWOpLbKs1b7rQwz5BjS1eAaYVG1JkXLPpTMLE2bu0HeSZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM Subject: [dpdk-dev] [PATCH 3/3] net/mlx5: eswitch-modify MAC address actions Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	ethdev: add generic MAC address rewrite actions \| [0/3] ethdev: add generic MAC address rewrite actions [1/3] ethdev: add generic MAC address rewrite actions [2/3] app/testpmd: add commands of modify MAC address [3/3] net/mlx5: eswitch-modify MAC address actions

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Xiaoyu Min Sept. 25, 2018, 3:03 p.m. UTC

  Offload following modify MAC address actions to E-Switch
via TC-Flower driver

- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST

The corresponding rte_flow_item_eth must be present in
rte_flow pattern

Only support modify outer layer MAC address

Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.h     |  2 ++
 drivers/net/mlx5/mlx5_flow_tcf.c | 62 +++++++++++++++++++++++++++++++-
 2 files changed, 63 insertions(+), 1 deletion(-)

Comments

Yongseok Koh Oct. 3, 2018, 8:10 p.m. UTC | #1

On Tue, Sep 25, 2018 at 11:03:40PM +0800, Xiaoyu Min wrote:
> Offload following modify MAC address actions to E-Switch
> via TC-Flower driver
> 
> - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
> - RTE_FLOW_ACTION_TYPE_SET_MAC_DST
> 
> The corresponding rte_flow_item_eth must be present in
> rte_flow pattern
> 
> Only support modify outer layer MAC address
> 
> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
> ---

Same comments as before.

Thanks,
Yongseok

>  drivers/net/mlx5/mlx5_flow.h     |  2 ++
>  drivers/net/mlx5/mlx5_flow_tcf.c | 62 +++++++++++++++++++++++++++++++-
>  2 files changed, 63 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
> index 5237e31dd..76c4e8398 100644
> --- a/drivers/net/mlx5/mlx5_flow.h
> +++ b/drivers/net/mlx5/mlx5_flow.h
> @@ -95,6 +95,8 @@
>  #define MLX5_ACTION_SET_TP_DST (1u << 16)
>  #define MLX5_ACTION_SET_TTL (1u << 17)
>  #define MLX5_ACTION_DEC_TTL (1u << 18)
> +#define MLX5_ACTION_SET_MAC_SRC (1u << 19)
> +#define MLX5_ACTION_SET_MAC_DST (1u << 20)
>  
>  /* possible L3 layers protocols filtering. */
>  #define MLX5_IP_PROTOCOL_TCP 6
> diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c
> index af88c4a0d..cb60c3e05 100644
> --- a/drivers/net/mlx5/mlx5_flow_tcf.c
> +++ b/drivers/net/mlx5/mlx5_flow_tcf.c
> @@ -303,7 +303,9 @@ struct flow_tcf_ptoi {
>  		(act) == RTE_FLOW_ACTION_TYPE_SET_TP_SRC    || \
>  		(act) == RTE_FLOW_ACTION_TYPE_SET_TP_DST    || \
>  		(act) == RTE_FLOW_ACTION_TYPE_SET_TTL       || \
> -		(act) == RTE_FLOW_ACTION_TYPE_DEC_TTL) ?       \
> +		(act) == RTE_FLOW_ACTION_TYPE_DEC_TTL       || \
> +		(act) == RTE_FLOW_ACTION_TYPE_SET_MAC_SRC   || \
> +		(act) == RTE_FLOW_ACTION_TYPE_SET_MAC_DST) ?   \
>  		1 : 0; })
>  #define MAX_PEDIT_KEYS (128)
>  #define SZ_PEDIT_KEY_VAL (4)
> @@ -327,6 +329,33 @@ flow_tcf_calc_pedit_keys(const uint64_t size)
>  	return keys;
>  }
>  
> +static void
> +flow_tcf_pedit_key_set_mac(const struct rte_flow_action *actions,
> +			   struct pedit_parser *p_parser)
> +{
> +	int idx = p_parser->sel.nkeys;
> +	uint32_t off =
> +		actions->type == RTE_FLOW_ACTION_TYPE_SET_MAC_SRC ? 6 : 0;
> +	const struct rte_flow_action_set_mac *conf =
> +		(const struct rte_flow_action_set_mac *)actions->conf;
> +
> +	p_parser->keys[idx].off = off;
> +	p_parser->keys[idx].mask = ~UINT32_MAX;
> +	p_parser->keys_ex[idx].htype = TCA_PEDIT_KEY_EX_HDR_TYPE_ETH;
> +	p_parser->keys_ex[idx].cmd = TCA_PEDIT_KEY_EX_CMD_SET;
> +	memcpy(&p_parser->keys[idx].val,
> +		conf->mac_addr, SZ_PEDIT_KEY_VAL);
> +	idx++;
> +	p_parser->keys[idx].off = off + SZ_PEDIT_KEY_VAL;
> +	p_parser->keys[idx].mask = 0xFFFF0000;
> +	p_parser->keys_ex[idx].htype = TCA_PEDIT_KEY_EX_HDR_TYPE_ETH;
> +	p_parser->keys_ex[idx].cmd = TCA_PEDIT_KEY_EX_CMD_SET;
> +	memcpy(&p_parser->keys[idx].val,
> +		conf->mac_addr + SZ_PEDIT_KEY_VAL,
> +		ETHER_ADDR_LEN - SZ_PEDIT_KEY_VAL);
> +	p_parser->sel.nkeys = (++idx);
> +}
> +
>  static void
>  flow_tcf_pedit_key_set_dec_ttl(const struct rte_flow_action *actions,
>  				struct pedit_parser *p_parser,
> @@ -447,6 +476,10 @@ flow_tcf_create_pedit_mnl_msg(struct nlmsghdr *nl,
>  			flow_tcf_pedit_key_set_dec_ttl(*actions,
>  							&p_parser, item_flags);
>  			break;
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
> +			flow_tcf_pedit_key_set_mac(*actions, &p_parser);
> +			break;
>  		default:
>  			goto pedit_mnl_msg_done;
>  		}
> @@ -535,6 +568,14 @@ flow_tcf_get_pedit_actions_size(const struct rte_flow_action **actions,
>  			keys += flow_tcf_calc_pedit_keys(TTL_LEN);
>  			flags |= MLX5_ACTION_DEC_TTL;
>  			break;
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
> +			keys += flow_tcf_calc_pedit_keys(ETHER_ADDR_LEN);
> +			flags |= MLX5_ACTION_SET_MAC_SRC;
> +			break;
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
> +			keys += flow_tcf_calc_pedit_keys(ETHER_ADDR_LEN);
> +			flags |= MLX5_ACTION_SET_MAC_DST;
> +			break;
>  		default:
>  			goto get_pedit_action_size_done;
>  		}
> @@ -1041,6 +1082,12 @@ flow_tcf_validate(struct rte_eth_dev *dev,
>  		case RTE_FLOW_ACTION_TYPE_DEC_TTL:
>  			action_flags |= MLX5_ACTION_DEC_TTL;
>  			break;
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
> +			action_flags |= MLX5_ACTION_SET_MAC_SRC;
> +			break;
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
> +			action_flags |= MLX5_ACTION_SET_MAC_DST;
> +			break;
>  		default:
>  			return rte_flow_error_set(error, ENOTSUP,
>  						  RTE_FLOW_ERROR_TYPE_ACTION,
> @@ -1093,6 +1140,15 @@ flow_tcf_validate(struct rte_eth_dev *dev,
>  						  actions,
>  						  "no IP found in pattern");
>  	}
> +	if (action_flags &
> +	    (MLX5_ACTION_SET_MAC_SRC | MLX5_ACTION_SET_MAC_DST)) {
> +		if (!(item_flags & MLX5_FLOW_LAYER_OUTER_L2))
> +			return rte_flow_error_set(error, ENOTSUP,
> +						  RTE_FLOW_ERROR_TYPE_ACTION,
> +						  actions,
> +						  "no ethernet found in"
> +						  " pattern");
> +	}
>  	return 0;
>  }
>  
> @@ -1244,6 +1300,8 @@ flow_tcf_get_actions_and_size(const struct rte_flow_action actions[],
>  		case RTE_FLOW_ACTION_TYPE_SET_TP_DST:
>  		case RTE_FLOW_ACTION_TYPE_SET_TTL:
>  		case RTE_FLOW_ACTION_TYPE_DEC_TTL:
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
>  			size += flow_tcf_get_pedit_actions_size(&actions,
>  								&flags);
>  			break;
> @@ -1788,6 +1846,8 @@ flow_tcf_translate(struct rte_eth_dev *dev, struct mlx5_flow *dev_flow,
>  		case RTE_FLOW_ACTION_TYPE_SET_TP_DST:
>  		case RTE_FLOW_ACTION_TYPE_SET_TTL:
>  		case RTE_FLOW_ACTION_TYPE_DEC_TTL:
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
>  			na_act_index =
>  				mnl_attr_nest_start(nlh, na_act_index_cur++);
>  			flow_tcf_create_pedit_mnl_msg(nlh,
> -- 
> 2.17.1
>

diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index 5237e31dd..76c4e8398 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -95,6 +95,8 @@ 
 #define MLX5_ACTION_SET_TP_DST (1u << 16)
 #define MLX5_ACTION_SET_TTL (1u << 17)
 #define MLX5_ACTION_DEC_TTL (1u << 18)
+#define MLX5_ACTION_SET_MAC_SRC (1u << 19)
+#define MLX5_ACTION_SET_MAC_DST (1u << 20)
 
 /* possible L3 layers protocols filtering. */
 #define MLX5_IP_PROTOCOL_TCP 6
diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c
index af88c4a0d..cb60c3e05 100644
--- a/drivers/net/mlx5/mlx5_flow_tcf.c
+++ b/drivers/net/mlx5/mlx5_flow_tcf.c
@@ -303,7 +303,9 @@  struct flow_tcf_ptoi {
 		(act) == RTE_FLOW_ACTION_TYPE_SET_TP_SRC    || \
 		(act) == RTE_FLOW_ACTION_TYPE_SET_TP_DST    || \
 		(act) == RTE_FLOW_ACTION_TYPE_SET_TTL       || \
-		(act) == RTE_FLOW_ACTION_TYPE_DEC_TTL) ?       \
+		(act) == RTE_FLOW_ACTION_TYPE_DEC_TTL       || \
+		(act) == RTE_FLOW_ACTION_TYPE_SET_MAC_SRC   || \
+		(act) == RTE_FLOW_ACTION_TYPE_SET_MAC_DST) ?   \
 		1 : 0; })
 #define MAX_PEDIT_KEYS (128)
 #define SZ_PEDIT_KEY_VAL (4)
@@ -327,6 +329,33 @@  flow_tcf_calc_pedit_keys(const uint64_t size)
 	return keys;
 }
 
+static void
+flow_tcf_pedit_key_set_mac(const struct rte_flow_action *actions,
+			   struct pedit_parser *p_parser)
+{
+	int idx = p_parser->sel.nkeys;
+	uint32_t off =
+		actions->type == RTE_FLOW_ACTION_TYPE_SET_MAC_SRC ? 6 : 0;
+	const struct rte_flow_action_set_mac *conf =
+		(const struct rte_flow_action_set_mac *)actions->conf;
+
+	p_parser->keys[idx].off = off;
+	p_parser->keys[idx].mask = ~UINT32_MAX;
+	p_parser->keys_ex[idx].htype = TCA_PEDIT_KEY_EX_HDR_TYPE_ETH;
+	p_parser->keys_ex[idx].cmd = TCA_PEDIT_KEY_EX_CMD_SET;
+	memcpy(&p_parser->keys[idx].val,
+		conf->mac_addr, SZ_PEDIT_KEY_VAL);
+	idx++;
+	p_parser->keys[idx].off = off + SZ_PEDIT_KEY_VAL;
+	p_parser->keys[idx].mask = 0xFFFF0000;
+	p_parser->keys_ex[idx].htype = TCA_PEDIT_KEY_EX_HDR_TYPE_ETH;
+	p_parser->keys_ex[idx].cmd = TCA_PEDIT_KEY_EX_CMD_SET;
+	memcpy(&p_parser->keys[idx].val,
+		conf->mac_addr + SZ_PEDIT_KEY_VAL,
+		ETHER_ADDR_LEN - SZ_PEDIT_KEY_VAL);
+	p_parser->sel.nkeys = (++idx);
+}
+
 static void
 flow_tcf_pedit_key_set_dec_ttl(const struct rte_flow_action *actions,
 				struct pedit_parser *p_parser,
@@ -447,6 +476,10 @@  flow_tcf_create_pedit_mnl_msg(struct nlmsghdr *nl,
 			flow_tcf_pedit_key_set_dec_ttl(*actions,
 							&p_parser, item_flags);
 			break;
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
+			flow_tcf_pedit_key_set_mac(*actions, &p_parser);
+			break;
 		default:
 			goto pedit_mnl_msg_done;
 		}
@@ -535,6 +568,14 @@  flow_tcf_get_pedit_actions_size(const struct rte_flow_action **actions,
 			keys += flow_tcf_calc_pedit_keys(TTL_LEN);
 			flags |= MLX5_ACTION_DEC_TTL;
 			break;
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
+			keys += flow_tcf_calc_pedit_keys(ETHER_ADDR_LEN);
+			flags |= MLX5_ACTION_SET_MAC_SRC;
+			break;
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
+			keys += flow_tcf_calc_pedit_keys(ETHER_ADDR_LEN);
+			flags |= MLX5_ACTION_SET_MAC_DST;
+			break;
 		default:
 			goto get_pedit_action_size_done;
 		}
@@ -1041,6 +1082,12 @@  flow_tcf_validate(struct rte_eth_dev *dev,
 		case RTE_FLOW_ACTION_TYPE_DEC_TTL:
 			action_flags |= MLX5_ACTION_DEC_TTL;
 			break;
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
+			action_flags |= MLX5_ACTION_SET_MAC_SRC;
+			break;
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
+			action_flags |= MLX5_ACTION_SET_MAC_DST;
+			break;
 		default:
 			return rte_flow_error_set(error, ENOTSUP,
 						  RTE_FLOW_ERROR_TYPE_ACTION,
@@ -1093,6 +1140,15 @@  flow_tcf_validate(struct rte_eth_dev *dev,
 						  actions,
 						  "no IP found in pattern");
 	}
+	if (action_flags &
+	    (MLX5_ACTION_SET_MAC_SRC | MLX5_ACTION_SET_MAC_DST)) {
+		if (!(item_flags & MLX5_FLOW_LAYER_OUTER_L2))
+			return rte_flow_error_set(error, ENOTSUP,
+						  RTE_FLOW_ERROR_TYPE_ACTION,
+						  actions,
+						  "no ethernet found in"
+						  " pattern");
+	}
 	return 0;
 }
 
@@ -1244,6 +1300,8 @@  flow_tcf_get_actions_and_size(const struct rte_flow_action actions[],
 		case RTE_FLOW_ACTION_TYPE_SET_TP_DST:
 		case RTE_FLOW_ACTION_TYPE_SET_TTL:
 		case RTE_FLOW_ACTION_TYPE_DEC_TTL:
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
 			size += flow_tcf_get_pedit_actions_size(&actions,
 								&flags);
 			break;
@@ -1788,6 +1846,8 @@  flow_tcf_translate(struct rte_eth_dev *dev, struct mlx5_flow *dev_flow,
 		case RTE_FLOW_ACTION_TYPE_SET_TP_DST:
 		case RTE_FLOW_ACTION_TYPE_SET_TTL:
 		case RTE_FLOW_ACTION_TYPE_DEC_TTL:
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
+		case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
 			na_act_index =
 				mnl_attr_nest_start(nlh, na_act_index_cur++);
 			flow_tcf_create_pedit_mnl_msg(nlh,