From patchwork Mon Oct 29 12:15:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 47557 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4D271F1C; Mon, 29 Oct 2018 13:15:57 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0072.outbound.protection.outlook.com [104.47.0.72]) by dpdk.org (Postfix) with ESMTP id C2FC91E2F for ; Mon, 29 Oct 2018 13:15:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJYuLpevShbGGtWxUGpJ1dJCHCbS/heru1QnFct6iFk=; b=riuxOoiSI+IXI5ZQ6mBWfFHrM2XcIzU/5uELNJeL+YRx8HuL5y7LRkB4y/ASGPrAGC3x8a/lp1KLpukRfmWN32ixuNtC7e6KDnhqrv6AMkHML/NFSoFM9zKKmQivTKLIlQjHt2RXCQSmppjX3ahYyP+O8P9DI9WNyamytNPqKZI= Received: from HE1PR04MB1530.eurprd04.prod.outlook.com (10.164.48.20) by HE1PR04MB0860.eurprd04.prod.outlook.com (10.162.21.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.20; Mon, 29 Oct 2018 12:15:51 +0000 Received: from HE1PR04MB1530.eurprd04.prod.outlook.com ([fe80::cd42:9c37:6021:d641]) by HE1PR04MB1530.eurprd04.prod.outlook.com ([fe80::cd42:9c37:6021:d641%3]) with mapi id 15.20.1273.027; Mon, 29 Oct 2018 12:15:51 +0000 From: Gagandeep Singh To: "dev@dpdk.org" CC: Gagandeep Singh Thread-Topic: [PATCH] crypto/caam_jr: fix incorrect check Thread-Index: AQHUb4Ehmvl+s6EYAEaYF57lastajw== Date: Mon, 29 Oct 2018 12:15:51 +0000 Message-ID: <20181029121511.7433-1-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR01CA0096.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::12) To HE1PR04MB1530.eurprd04.prod.outlook.com (2a01:111:e400:59a8::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [14.142.187.166] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR04MB0860; 6:sTNSZnsyd+yXh/xIZWa13bfS4RO8a0ktn8lndtkDnjsu5GULOezqB9jzViFfwC7dWpUuMxfMgX+hVhTH4m89P9LyWisM7fe9ar73Ok0nU3ePv+IQMZGR5EYYC5jZvYTwkTFhGczydz3hZAIv/aUj3SrwVfeCKo6RadSNpiQfniEtSPWB3yzcJcsiiBIm+wCEdYbbv/f86gufCI3tfWA0YeyWOcCYIplNbu89L2hlEXwWo7gdMrw4WGNtGu7ALTA/TiF+ad9O5oMUNvvlExztdE2sMhdokS8LpyU4sNsivkSrTz9oa50OQsSqdXGQ6WC+eOvRSneWFrYBXDH0b0nJ7chGCOTFsnZRrRNnEv70qbi8311yq11MUk65Nk07FGRHlfCHAhlPD+3rFwILmOOByqQXJ9MgU1SAkUUBWwFgkYS2W4coXJnfEs/xQkuasLat5ipvixQAtMVibRryWHFiTrvH9SVJv/p4Ck8WyugDR6I=; 5:A7Z8fPJoVWIfAPTpqRzNj0Uv0yX4nWbemaTwL3xmdty8DyqlrYad6WEsJZSzWkm2efQZOoOkbSnNKGTPuBJTd1OlerA0wQyNy+ZsMszjNWX+ku+tAl7spBddQB2jqPgiS/9Td8fRbBlTeu00OWoTy38wm7kNvTc2pHGkNgZhCHE=; 7:EtQcOyYZZFml9mdouU0BoYaj+miiRMTjk12CqOmtoRI5Vnk4owtg52HZhoWKUGfRgYnE4iz+Ot+Qvw5g7KdB0iUVS0kgFF+sC8jb7mUNaBTy3vMcSHPP/umjM90pCdvz+hBGIe0f6U2kWWjBB5xMPg== x-ms-office365-filtering-correlation-id: 3b8a54e9-9af5-44ac-3ac2-08d63d984404 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:HE1PR04MB0860; x-ms-traffictypediagnostic: HE1PR04MB0860: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:HE1PR04MB0860; BCL:0; PCL:0; RULEID:; SRVR:HE1PR04MB0860; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(136003)(376002)(39860400002)(396003)(199004)(189003)(66066001)(5250100002)(2900100001)(186003)(1857600001)(386003)(55236004)(102836004)(6506007)(26005)(8936002)(2501003)(4326008)(478600001)(97736004)(486006)(68736007)(99286004)(7736002)(305945005)(25786009)(106356001)(72206003)(2616005)(6916009)(8676002)(1730700003)(81156014)(81166006)(6512007)(6116002)(86362001)(14444005)(14454004)(2351001)(316002)(105586002)(5640700003)(78486011)(256004)(36756003)(71200400001)(1076002)(71190400001)(476003)(6486002)(6436002)(53936002)(2906002)(5660300001)(52116002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR04MB0860; H:HE1PR04MB1530.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Wdh+zseL4deGQV5xCdCW+Z3NovDMpgEiMTA+SMGYvHSg+avZIBMYoKWIM+P1rFvkW6RYDu4u1zI89+elnRT3KeWF1jULBFWzSsIt29fvtlPu5wHinz8Em/V0nhpyWcmepHZ7bCLUh3pb5Nd4YI9jZN/ZwRVp7UuivVOQ3jtNFPevzApPQ5DNRt5Y5YQUPO/kuLG1HSDA0/o/F0DdqYzSQZ7/n6stmpbdQmc94cx+TqGFsIlcjpSG1FF4CpKYFmsdRjfWDp/uAhQCpX8q/1IvYxO7Iu9+4pGdLmD85Gy5L4K7ueu5Tkubupc1nnUo9xWD05GxtJLizHc2XB+YbqtwvSnRjxYI+/zsm2e4H1RvFqA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b8a54e9-9af5-44ac-3ac2-08d63d984404 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 12:15:51.2611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB0860 Subject: [dpdk-dev] [PATCH] crypto/caam_jr: fix incorrect check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Check should be on parameter uio_fd instead of local variable job_ring Fixes: e7a45f3cc2 ("crypto/caam_jr: add UIO specific operations") Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal --- changes: * fixed incorrect check in free_job_ring (comment by Ferruh) drivers/crypto/caam_jr/caam_jr_uio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/caam_jr/caam_jr_uio.c b/drivers/crypto/caam_jr/caam_jr_uio.c index c07d9db01..d94101c2f 100644 --- a/drivers/crypto/caam_jr/caam_jr_uio.c +++ b/drivers/crypto/caam_jr/caam_jr_uio.c @@ -332,7 +332,7 @@ free_job_ring(uint32_t uio_fd) struct uio_job_ring *job_ring = NULL; int i; - if (!job_ring->uio_fd) + if (!uio_fd) return; for (i = 0; i < MAX_SEC_JOB_RINGS; i++) {