From patchwork Fri Apr 12 12:28:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 52701 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E48641B144; Fri, 12 Apr 2019 14:29:12 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50047.outbound.protection.outlook.com [40.107.5.47]) by dpdk.org (Postfix) with ESMTP id CD95E7D4A; Fri, 12 Apr 2019 14:28:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WG7degB6ozVO9RMO+s4cqdnYWSp6hd57N45bUqz2EVo=; b=eFuLpkZbz4yKwklczKyxoOIVhJMKgmYNJGnC2E8fTa6LjR9G4ZSced5lyS+pcYSu89VCTAQfbqAHkzvEmjpVbrW+gpQIuwmvCEGEAHSe32MJcjOcDZZ/Ykj2CuqOJsi3/lPThHmdAOAy/JfH7wHp4Mz20lD1QuABl2xegXdbQ0k= Received: from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by VE1PR04MB6367.eurprd04.prod.outlook.com (10.255.118.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.15; Fri, 12 Apr 2019 12:28:56 +0000 Received: from VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0]) by VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016; Fri, 12 Apr 2019 12:28:56 +0000 From: Gagandeep Singh To: "dev@dpdk.org" , "ferruh.yigit@intel.com" CC: Gagandeep Singh , "stable@dpdk.org" Thread-Topic: [PATCH v4 03/13] net/enetc: fix big endian build and correct buffer allocation Thread-Index: AQHU8StMmSIXkm1U3UONrid7tt+Tvg== Date: Fri, 12 Apr 2019 12:28:56 +0000 Message-ID: <20190412122840.1908-4-g.singh@nxp.com> References: <20190412105105.24351-1-g.singh@nxp.com> <20190412122840.1908-1-g.singh@nxp.com> In-Reply-To: <20190412122840.1908-1-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BMXPR01CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::15) To VE1PR04MB6365.eurprd04.prod.outlook.com (2603:10a6:803:12a::14) x-mailer: git-send-email 2.19.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.0.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 235a8828-24c3-42d4-95f9-08d6bf426e78 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6367; x-ms-traffictypediagnostic: VE1PR04MB6367: x-microsoft-antispam-prvs: x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(39860400002)(366004)(136003)(189003)(199004)(476003)(99286004)(1076003)(8936002)(2501003)(5660300002)(186003)(6486002)(97736004)(3846002)(6436002)(106356001)(6116002)(7736002)(6506007)(102836004)(386003)(305945005)(256004)(446003)(76176011)(2616005)(105586002)(26005)(71190400001)(53936002)(36756003)(66066001)(25786009)(8676002)(486006)(11346002)(14454004)(50226002)(71200400001)(81156014)(6512007)(86362001)(2906002)(316002)(478600001)(110136005)(54906003)(72206003)(4326008)(52116002)(68736007)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6367; H:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Rn4w/8u7y52//RWRAqO0TqhBlwwxChIF+MsptuHovtWL1Mi2vcnu/yO/A7xnHy1xAPNJtoV4YKUmh9SxcOW6v5KKsRxg4twyXPYUf9blJ6XQzfhkrE/oBFlMnPS4rrm4MaiCIecNFdb7Xf/a9/h5Y13eydnt1EmQMt4kvAq2mV+giHdlTsFd2Fr1eDa4f/SBOjIZk7ZFtaSPc/mZcekyGR7xHTrHhLfrCJPxc+LCKhB1SBkkF2/pgONWrtxXa3nITsL/EAX6CHkSJ1c7n0CUw6szN3LIvPFyEcxBELqlgvckCm8kBNMxryjMFyul74bQ+oy3lltCMPSrHeMxAELVNDeMoi/nadVb9DWcVz4SCyPic1UwiiKg7vYlJrzKjRFv1oxfTnYBPOB1AV2TgBK9IIe52+D/8RxSaL9Zoy2jm6w= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 235a8828-24c3-42d4-95f9-08d6bf426e78 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 12:28:56.6380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6367 Subject: [dpdk-dev] [PATCH v4 03/13] net/enetc: fix big endian build and correct buffer allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There was an error at rte_constant_bswap64 while compiling with big endian toolchain. so fixing it by adding type cast. Also, rte_pktmbuf_alloc API should be used to allocate mbuf instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf information. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: stable@dpdk.org Suggested-by: Thomas Monjalon Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c index a31a38725..42f16cab1 100644 --- a/drivers/net/enetc/enetc_rxtx.c +++ b/drivers/net/enetc/enetc_rxtx.c @@ -88,8 +88,9 @@ enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const int buff_cnt) rx_swbd = &rx_ring->q_swbd[i]; rxbd = ENETC_RXBD(*rx_ring, i); for (j = 0; j < buff_cnt; j++) { - rx_swbd->buffer_addr = - rte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool)); + rx_swbd->buffer_addr = (void *)(uintptr_t) + rte_cpu_to_le_64((uint64_t)(uintptr_t) + rte_pktmbuf_alloc(rx_ring->mb_pool)); rxbd->w.addr = (uint64_t)(uintptr_t) rx_swbd->buffer_addr->buf_iova + rx_swbd->buffer_addr->data_off;