From patchwork Sat Jun 8 19:22:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 54567 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FD451BD27; Sat, 8 Jun 2019 21:22:35 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 18CF51BD1F for ; Sat, 8 Jun 2019 21:22:32 +0200 (CEST) Received: from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net [10.75.144.136]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 41AEE30C064; Sat, 8 Jun 2019 12:22:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 41AEE30C064 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1560021750; bh=VS9FHd3pceao/Tw9HhQUusAK89e+PqEfX4/19ULYOOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MaKSXdmfq2s2i3u4sgRdPG083NMHiUZdKeqzlMlfnb7mOJvL2pgq/GdK9N8kzHSak vj3bogqkcvk5DYYWA0lPbjglxPZU894oEMpXrWezOQQyZw5E9+yldnSlC351g8MnpI VsMkrTvH4W0emW1kGYjPoas5REM/O6lw2lsWKAsI= Received: from localhost.localdomain (unknown [10.230.18.249]) by nis-sj1-27.broadcom.com (Postfix) with ESMTP id 19C68AC0737; Sat, 8 Jun 2019 12:22:28 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Naresh Kumar PBS , Lance Richardson Date: Sat, 8 Jun 2019 23:22:07 +0400 Message-Id: <20190608192208.77607-6-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.20.1 (Apple Git-117) In-Reply-To: <20190608192208.77607-1-ajit.khaparde@broadcom.com> References: <20190608192208.77607-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 5/6] net/bnxt: fix interrupt vector array initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Naresh Kumar PBS Initialize the vector array when it is valid, thereby preventing a case were it may be accessed when the array is unallocated Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt") Signed-off-by: Naresh Kumar PBS Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 4133d0bef..4dd845992 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -412,13 +412,12 @@ static int bnxt_init_chip(struct bnxt *bp) "intr_handle->nb_efd = %d intr_handle->max_intr = %d\n", intr_handle->intr_vec, intr_handle->nb_efd, intr_handle->max_intr); - } - - for (queue_id = 0; queue_id < bp->eth_dev->data->nb_rx_queues; - queue_id++) { - intr_handle->intr_vec[queue_id] = vec; - if (vec < base + intr_handle->nb_efd - 1) - vec++; + for (queue_id = 0; queue_id < bp->eth_dev->data->nb_rx_queues; + queue_id++) { + intr_handle->intr_vec[queue_id] = vec; + if (vec < base + intr_handle->nb_efd - 1) + vec++; + } } /* enable uio/vfio intr/eventfd mapping */