From patchwork Fri Jun 21 22:08:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 55177 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6866B1D4C9; Sat, 22 Jun 2019 00:08:28 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 520891D4C4 for ; Sat, 22 Jun 2019 00:08:27 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id bh12so3629868plb.4 for ; Fri, 21 Jun 2019 15:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8h84e2FkS7gDwLnhovR/3D/b0n3QmADP7XER69dVhn8=; b=szF7Ft19kiBOGDLHtuxlAiJQyrNdHHJkqzzwyOazweqkXng8s0wcPKRyTfn05FZKfQ yyd+wznqGuyVGrxMsf1oC9za6U02K+YfQC8WE5yCmZqNMB0KgX+DMhPi3SQBzquq7a8/ WYY2o8VNTPfqyZJBHg1OCrySrYh/2J0rJuZtymaPLQiMn6n5uut2IoiQR3LSYBKLjx3A UfDN6ZjT/MY+qSdu8C7I1GyLh4tiVdIWNjtUL339fBcEjNgHRyp42g7EFivnakUT4sou espuRWL9wHbztEtMlbD4dhl0FkIzqpgtp1wwiy3nhRn9gCOiz5G4mGKCRborUj//7P4W mhqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8h84e2FkS7gDwLnhovR/3D/b0n3QmADP7XER69dVhn8=; b=euqpJiE6BnG7u8pzwTno9u60twwGUOinsGF6ifrzeAcu4bFk5Z7PlGnhxv8XGRLXYL NkbfhS+SZOA1hecIOEOlydEdKHJQP/JFe+MqCMlO7Z0/conSTZ4tuns7+6QrFQW8iGhN WD94HD4TfEzwL6lUw+4sYz45/yRJ3pa2ZnC9KqjkuKvdaIqdjqu0Kqmus2Io6JD/jIiV 462qhJBrOOQlWb9kPTk8ZUSGnWSjOXIzAwis+SMvXNXruSsUwTC7RKxCpA7vVxmdfg5K XSYpxbz9ryqzEUxtOSgmLYU+W/1f1PIlYY/Vj7+lm27X4XPfvHjYEn6Y4fhoFBzWfE9Z d9bQ== X-Gm-Message-State: APjAAAUINDCH/gbk56R1QuVqpdvqikjvM3GNlzTnQZppwzDobB8Sw+4U URaK+mW6//41ksdyRV8cI6Rvuqia/dE= X-Google-Smtp-Source: APXvYqz0VC6wlLAxoOcP1dIguPDGPId8MrqRRwGfWftSs2/OZjjJ5ZDODKRquKRIUIpg+egwB+MW1A== X-Received: by 2002:a17:902:2869:: with SMTP id e96mr128888586plb.203.1561154906440; Fri, 21 Jun 2019 15:08:26 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w197sm4418997pfd.41.2019.06.21.15.08.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 21 Jun 2019 15:08:25 -0700 (PDT) From: Stephen Hemminger To: gaetan.rivet@6wind.com Cc: dev@dpdk.org, Stephen Hemminger Date: Fri, 21 Jun 2019 15:08:24 -0700 Message-Id: <20190621220824.18073-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] failsafe: skip devargs if not present in secondary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When secondary process is run was noticing that the log always contained complaints about unable to parse devargs. It turns out that an empty devargs turns into "" and this value is not parsable. Change the failsafe secondary to just skip doing devargs if it empty. Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index e91c274d8059..04ca0cab0d78 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/net/failsafe/failsafe.c @@ -364,6 +364,10 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) * A sub-device can be plugged later. */ FOREACH_SUBDEV(sdev, i, eth_dev) { + /* skip empty devargs */ + if (sdev->devargs.name[0] == '\0') + continue; + /* rebuild devargs to be able to get the bus name. */ ret = rte_devargs_parse(&devargs, sdev->devargs.name);