From patchwork Thu Jun 27 15:10:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ali Alnubani X-Patchwork-Id: 55504 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56A6A2BF7; Thu, 27 Jun 2019 17:10:46 +0200 (CEST) Received: from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130]) by dpdk.org (Postfix) with ESMTP id D3D9D2BE3; Thu, 27 Jun 2019 17:10:44 +0200 (CEST) From: Ali Alnubani To: dev@dpdk.org Cc: motih@mellanox.com, stable@dpdk.org Date: Thu, 27 Jun 2019 18:10:07 +0300 Message-Id: <20190627151007.5156-1-alialnu@mellanox.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix 32-bit build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This is to fix the error: ``` drivers/net/mlx5/mlx5_defs.h:14:26: error: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'off_t {aka long long int}' [-Werror=format=] #define MLX5_DRIVER_NAME "net_mlx5" ^ RTE_SDK/i686-native-linuxapp-gcc/include/rte_common.h:642:27: note: in definition of macro 'RTE_FMT' #define RTE_FMT(fmt, ...) fmt "%.0s", __VA_ARGS__ "" ^~~ RTE_SDK/drivers/net/mlx5/mlx5_utils.h:79:11: note: in expansion of macro 'MLX5_DRIVER_NAME' RTE_FMT(MLX5_DRIVER_NAME ": " \ ^~~~~~~~~~~~~~~~ RTE_SDK/drivers/net/mlx5/mlx5_utils.h:101:2: note: in expansion of macro 'PMD_DRV_LOG___' PMD_DRV_LOG___(level, __VA_ARGS__) ^~~~~~~~~~~~~~ RTE_SDK/drivers/net/mlx5/mlx5_utils.h:103:2: note: in expansion of macro 'PMD_DRV_LOG__' PMD_DRV_LOG__(level, s "\n", __VA_ARGS__) ^~~~~~~~~~~~~ RTE_SDK/drivers/net/mlx5/mlx5_utils.h:109:2: note: in expansion of macro 'PMD_DRV_LOG_' PMD_DRV_LOG_(level, \ ^~~~~~~~~~~~ RTE_SDK/drivers/net/mlx5/mlx5_txq.c:569:3: note: in expansion of macro 'DRV_LOG' DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx", ^~~~~~~ RTE_SDK/drivers/net/mlx5/mlx5_txq.c:569:48: note: format string is defined here DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx" ~~^ %llx ``` Which reproduces with gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0. Fixes: 6bf10ab69be0 ("net/mlx5: support 32-bit systems") Cc: motih@mellanox.com Cc: stable@dpdk.org Signed-off-by: Ali Alnubani Reviewed-by: Ferruh Yigit --- drivers/net/mlx5/mlx5_txq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index ebb42cbff..5cdcbf2f2 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -10,6 +10,7 @@ #include #include #include +#include /* Verbs header. */ /* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */ @@ -566,7 +567,7 @@ mlx5_txq_ibv_new(struct rte_eth_dev *dev, uint16_t idx) txq_uar_init(txq_ctrl); if (qp.comp_mask & MLX5DV_QP_MASK_UAR_MMAP_OFFSET) { txq_ctrl->uar_mmap_offset = qp.uar_mmap_offset; - DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx", + DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%"PRIx64"", dev->data->port_id, txq_ctrl->uar_mmap_offset); } else { DRV_LOG(ERR,