From patchwork Mon Jul 8 12:18:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kanas X-Patchwork-Id: 56228 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21EC837B0; Mon, 8 Jul 2019 14:18:46 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id D5085325F for ; Mon, 8 Jul 2019 14:18:43 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x68CIUTI028076 for ; Mon, 8 Jul 2019 05:18:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=tMLSHwjxRYwrbiEVhImd14/avBxeSUYdWwNGlz5C6lU=; b=OXWVBXsWwmevsiEK7hfc8lw5/WWojJIs/+vTY20HnLNVjGasa6ecBP0vSZzptIV5Oprc 4vnyI5vgyVXmAgHximpsdKqNEoWkn/XdKfMNm277mjq+L1qrN+u+W2jRnPEY/Wk0qpW+ sLirlhgFe6nFx4a23BZyO8XERk4n4wmz8esHSMLRCC11WJjt7YJng8JrptbNSMhfb0TU Y9V3zRQUHN14JV1oh3yO6OwAsdxHrooY8EBMGXFNY1KgxhrrvnicFP6Q1LMgj4xaSzZS MPLuDTYARPs/YYRKlvCux2TU1bJcKjUTjtb11G9xs/ORihjfxLjpEBR0lAkjIgoUlShX 5Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2tju5j6y87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 08 Jul 2019 05:18:42 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 8 Jul 2019 05:18:40 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Mon, 8 Jul 2019 05:18:40 -0700 Received: from kk-box-0.marvell.com (unknown [10.95.130.189]) by maili.marvell.com (Postfix) with ESMTP id 06E223F7043; Mon, 8 Jul 2019 05:18:37 -0700 (PDT) From: To: , Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru CC: Krzysztof Kanas Date: Mon, 8 Jul 2019 14:18:32 +0200 Message-ID: <20190708121833.4208-1-kkanas@marvell.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-08_04:, , signatures=0 Subject: [dpdk-dev] [PATCH] common/octeontx2: cleanup void returns X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Krzysztof Kanas mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value. mbox_unregister_irq also returns void. Clang with flags '-Wall -Wextra -pedantic' complains about: void function should not return void expression Signed-off-by: Krzysztof Kanas --- drivers/common/octeontx2/otx2_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/octeontx2/otx2_dev.c b/drivers/common/octeontx2/otx2_dev.c index 53a0c6efbcbc..3b51fa93ad29 100644 --- a/drivers/common/octeontx2/otx2_dev.c +++ b/drivers/common/octeontx2/otx2_dev.c @@ -744,9 +744,9 @@ static void mbox_unregister_irq(struct rte_pci_device *pci_dev, struct otx2_dev *dev) { if (otx2_dev_is_vf(dev)) - return mbox_unregister_vf_irq(pci_dev, dev); + mbox_unregister_vf_irq(pci_dev, dev); else - return mbox_unregister_pf_irq(pci_dev, dev); + mbox_unregister_pf_irq(pci_dev, dev); } static int