From patchwork Mon Jul 8 18:26:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 56250 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 855641BDE7; Mon, 8 Jul 2019 20:26:40 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 1BD581B9D9 for ; Mon, 8 Jul 2019 20:26:30 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id u17so7619989pgi.6 for ; Mon, 08 Jul 2019 11:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=PtqLsR+Yf7ZMROyJ98PH3dc6Y4SFIPNKoHMCfVy8COCrFqhL4qgG2cpLdRisagz6to 6SYa3mcJgZfqUiEi8hQF3D/8Yez4khq31hVRTemNReFmVBUNPr/FpgxIfV4tIIN8olVF hGW6su+g6ziXLI/peH6tmnHqMB1yleogzOoMCtjMFcYo/Dwb4Q+R7ZomHYc6reKIsyom CCtMSwxC0eq5Ch5n195eR+JNIwk4dSaMqyr6b41xFLZN75EoOgKnfYZnCYgF84n/yIry uvYIdTONc2yqOMI6XVG8EZz2EVB598XsM3pfT/MRqXTT1XFWhgjYTqvPCTgcQDSXZDi0 gcwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=rvzerFE/eJnweKlDs+5ewoiGBMA5Gcye5VjG0DFYbhcV4ey/UUITkm1w1M46e2zI50 z7a9uvnj7d248nn4EVuoYfBLe/mBkw01Vas6kEJhPG1xjpM6izYO+FB1ZtVnBMshyJOv ksaRBpZ4bW9It77QuuUkTf5q3G1XCTPZJKY4vyInIp4xAQjRtHALIcsVpFl95K/GTgYV XVFkhC5zSW+eU5rkSIpt4GPcYqqSnCJRqow5gV7gJjvykspJ6cL9u573V6M5OyJxGdEm 2zcruB2BwoCvXGcMZcCQljXVahzrYooRwHXSzkUjb2eMwp/W3I8kn50JvTgcOasw1H91 /2qw== X-Gm-Message-State: APjAAAUSekadpOSzq3aMJXmwWE7eEdUo2a4ULmCTKpLUA2wZqnlKRYAN Fdh5FeiwkXwk11EBNSbm1VcQRFkI8fM= X-Google-Smtp-Source: APXvYqys5mIKT/hfoc/N7+qV5utX8IJqvRx+qKzGV4RQ6sRmu2H1t4P40de2C3WHkmT9BOQBUnpzAA== X-Received: by 2002:a65:6114:: with SMTP id z20mr25981828pgu.141.1562610389000; Mon, 08 Jul 2019 11:26:29 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o15sm18769295pgj.18.2019.07.08.11.26.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Jul 2019 11:26:27 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 8 Jul 2019 11:26:09 -0700 Message-Id: <20190708182614.1677-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190708182614.1677-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190708182614.1677-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v9 06/11] net/bonding: use new ethernet address parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile | 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile index 1893e3cad313..26c1782554cd 100644 --- a/drivers/net/bonding/Makefile +++ b/drivers/net/bonding/Makefile @@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_pci -lrte_bus_pci LDLIBS += -lrte_bus_vdev diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build index 00374edb2a9d..6267210adf5f 100644 --- a/drivers/net/bonding/meson.build +++ b/drivers/net/bonding/meson.build @@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c 'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c') deps += 'sched' # needed for rte_bitmap.h -deps += ['ip_frag', 'cmdline'] +deps += ['ip_frag'] install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h') diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index 01bbb06c1a84..936440fb8491 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/net/bonding/rte_eth_bond_args.c @@ -7,9 +7,6 @@ #include #include -#include -#include - #include "rte_eth_bond.h" #include "rte_eth_bond_private.h" @@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused, return -1; /* Parse MAC */ - return cmdline_parse_etheraddr(NULL, value, extra_args, - sizeof(struct rte_ether_addr)); + return rte_ether_unformat_addr(value, extra_args); } int