doc: fix list of unsupported features for IPsec lib

Message ID 20190927142042.27513-1-konstantin.ananyev@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series doc: fix list of unsupported features for IPsec lib |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ananyev, Konstantin Sept. 27, 2019, 2:20 p.m. UTC
  List of unsupported features doesn't reflect latest changes.

Fixes: cd5b860c1851 ("ipsec: support header construction")
Fixes: 2c1887fad075 ("ipsec: fix transport mode for IPv6 with extensions")

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
 doc/guides/prog_guide/ipsec_lib.rst | 3 ---
 1 file changed, 3 deletions(-)
  

Comments

Iremonger, Bernard Oct. 1, 2019, 4:26 p.m. UTC | #1
Hi Konstantin,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Konstantin
> Ananyev
> Sent: Friday, September 27, 2019 3:21 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib
> 
> List of unsupported features doesn't reflect latest changes.
> 
> Fixes: cd5b860c1851 ("ipsec: support header construction")
> Fixes: 2c1887fad075 ("ipsec: fix transport mode for IPv6 with extensions")
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
>  doc/guides/prog_guide/ipsec_lib.rst | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/doc/guides/prog_guide/ipsec_lib.rst
> b/doc/guides/prog_guide/ipsec_lib.rst
> index 63b75b652..17d9da28f 100644
> --- a/doc/guides/prog_guide/ipsec_lib.rst
> +++ b/doc/guides/prog_guide/ipsec_lib.rst
> @@ -161,7 +161,4 @@ Limitations
> 
>  The following features are not properly supported in the current version:
> 
> -*  ESP transport mode for IPv6 packets with extension headers.
> -*  Updates of the fields in inner IP header for tunnel mode
> -   (as described in RFC 4301, section 5.1.2).
>  *  Hard/soft limit for SA lifetime (time interval/byte count).
> --
> 2.17.1

./devtools/check-git-log.sh -1
Is it candidate for Cc: stable@dpdk.org backport?
        doc: fix list of unsupported features for IPsec lib

Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
  
Ananyev, Konstantin Oct. 1, 2019, 5:27 p.m. UTC | #2
> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Tuesday, October 1, 2019 5:27 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib
> 
> Hi Konstantin,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Konstantin
> > Ananyev
> > Sent: Friday, September 27, 2019 3:21 PM
> > To: dev@dpdk.org
> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > Subject: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib
> >
> > List of unsupported features doesn't reflect latest changes.
> >
> > Fixes: cd5b860c1851 ("ipsec: support header construction")
> > Fixes: 2c1887fad075 ("ipsec: fix transport mode for IPv6 with extensions")
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > ---
> >  doc/guides/prog_guide/ipsec_lib.rst | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/doc/guides/prog_guide/ipsec_lib.rst
> > b/doc/guides/prog_guide/ipsec_lib.rst
> > index 63b75b652..17d9da28f 100644
> > --- a/doc/guides/prog_guide/ipsec_lib.rst
> > +++ b/doc/guides/prog_guide/ipsec_lib.rst
> > @@ -161,7 +161,4 @@ Limitations
> >
> >  The following features are not properly supported in the current version:
> >
> > -*  ESP transport mode for IPv6 packets with extension headers.
> > -*  Updates of the fields in inner IP header for tunnel mode
> > -   (as described in RFC 4301, section 5.1.2).
> >  *  Hard/soft limit for SA lifetime (time interval/byte count).
> > --
> > 2.17.1
> 
> ./devtools/check-git-log.sh -1
> Is it candidate for Cc: stable@dpdk.org backport?
>         doc: fix list of unsupported features for IPsec lib

Nope, librte_ipsec was introduced in 19.02.
These features appeared only in 19.08.

> 
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
  
Akhil Goyal Oct. 17, 2019, 9:57 a.m. UTC | #3
> >
> > Hi Konstantin,
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Konstantin
> > > Ananyev
> > > Sent: Friday, September 27, 2019 3:21 PM
> > > To: dev@dpdk.org
> > > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > > Subject: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib
> > >
> > > List of unsupported features doesn't reflect latest changes.
> > >
> > > Fixes: cd5b860c1851 ("ipsec: support header construction")
> > > Fixes: 2c1887fad075 ("ipsec: fix transport mode for IPv6 with extensions")
> > >
> > > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > > ---
> > >  doc/guides/prog_guide/ipsec_lib.rst | 3 ---
> > >  1 file changed, 3 deletions(-)
> > >
> > > diff --git a/doc/guides/prog_guide/ipsec_lib.rst
> > > b/doc/guides/prog_guide/ipsec_lib.rst
> > > index 63b75b652..17d9da28f 100644
> > > --- a/doc/guides/prog_guide/ipsec_lib.rst
> > > +++ b/doc/guides/prog_guide/ipsec_lib.rst
> > > @@ -161,7 +161,4 @@ Limitations
> > >
> > >  The following features are not properly supported in the current version:
> > >
> > > -*  ESP transport mode for IPv6 packets with extension headers.
> > > -*  Updates of the fields in inner IP header for tunnel mode
> > > -   (as described in RFC 4301, section 5.1.2).
> > >  *  Hard/soft limit for SA lifetime (time interval/byte count).
> > > --
> > > 2.17.1
> >
> > ./devtools/check-git-log.sh -1
> > Is it candidate for Cc: stable@dpdk.org backport?
> >         doc: fix list of unsupported features for IPsec lib
> 
> Nope, librte_ipsec was introduced in 19.02.
> These features appeared only in 19.08.
> 
> >
> > Otherwise
> > Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-crypto

Thanks.
  

Patch

diff --git a/doc/guides/prog_guide/ipsec_lib.rst b/doc/guides/prog_guide/ipsec_lib.rst
index 63b75b652..17d9da28f 100644
--- a/doc/guides/prog_guide/ipsec_lib.rst
+++ b/doc/guides/prog_guide/ipsec_lib.rst
@@ -161,7 +161,4 @@  Limitations
 
 The following features are not properly supported in the current version:
 
-*  ESP transport mode for IPv6 packets with extension headers.
-*  Updates of the fields in inner IP header for tunnel mode
-   (as described in RFC 4301, section 5.1.2).
 *  Hard/soft limit for SA lifetime (time interval/byte count).