[v2] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path

Message ID 20191112024206.5563-1-leyi.rong@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series [v2] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Leyi Rong Nov. 12, 2019, 2:42 a.m. UTC
  Fix iavf vf_checksum_sw case fail in X710/XXV710, set bit2 to 1
of CMD field in Tx descriptor of AVX Tx path according to Spec.

Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf")

Signed-off-by: Leyi Rong <leyi.rong@intel.com>

---
v2:
- Use IAVF_TX_DESC_CMD_ICRC instead of 0x04.
---
 drivers/net/iavf/iavf_rxtx_vec_avx2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
  

Comments

Qi Zhang Nov. 12, 2019, 3 a.m. UTC | #1
> -----Original Message-----
> From: Rong, Leyi <leyi.rong@intel.com>
> Sent: Tuesday, November 12, 2019 10:42 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
> Subject: [PATCH v2] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path
> 
> Fix iavf vf_checksum_sw case fail in X710/XXV710, set bit2 to 1 of CMD field in
> Tx descriptor of AVX Tx path according to Spec.
> 
> Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf")
> 
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>
  
Xiaolong Ye Nov. 13, 2019, 2:28 a.m. UTC | #2
On 11/12, Leyi Rong wrote:
>Fix iavf vf_checksum_sw case fail in X710/XXV710, set bit2 to 1
>of CMD field in Tx descriptor of AVX Tx path according to Spec.
>
>Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf")
>
>Signed-off-by: Leyi Rong <leyi.rong@intel.com>
>
>---
>v2:
>- Use IAVF_TX_DESC_CMD_ICRC instead of 0x04.
>---
> drivers/net/iavf/iavf_rxtx_vec_avx2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
>index f0c00be56..a5133d8d8 100644
>--- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c
>+++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
>@@ -785,8 +785,9 @@ iavf_xmit_fixed_burst_vec_avx2(void *tx_queue, struct rte_mbuf **tx_pkts,
> 	volatile struct iavf_tx_desc *txdp;
> 	struct iavf_tx_entry *txep;
> 	uint16_t n, nb_commit, tx_id;
>-	uint64_t flags = IAVF_TX_DESC_CMD_EOP;
>-	uint64_t rs = IAVF_TX_DESC_CMD_RS | IAVF_TX_DESC_CMD_EOP;
>+	/* bit2 is reserved and must be set to 1 according to Spec */
>+	uint64_t flags = IAVF_TX_DESC_CMD_EOP | IAVF_TX_DESC_CMD_ICRC;
>+	uint64_t rs = IAVF_TX_DESC_CMD_RS | flags;
> 
> 	/* cross rx_thresh boundary is not allowed */
> 	nb_pkts = RTE_MIN(nb_pkts, txq->rs_thresh);
>-- 
>2.17.1
>

Applied to dpdk-next-net-intel, Thanks.
  

Patch

diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
index f0c00be56..a5133d8d8 100644
--- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c
+++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
@@ -785,8 +785,9 @@  iavf_xmit_fixed_burst_vec_avx2(void *tx_queue, struct rte_mbuf **tx_pkts,
 	volatile struct iavf_tx_desc *txdp;
 	struct iavf_tx_entry *txep;
 	uint16_t n, nb_commit, tx_id;
-	uint64_t flags = IAVF_TX_DESC_CMD_EOP;
-	uint64_t rs = IAVF_TX_DESC_CMD_RS | IAVF_TX_DESC_CMD_EOP;
+	/* bit2 is reserved and must be set to 1 according to Spec */
+	uint64_t flags = IAVF_TX_DESC_CMD_EOP | IAVF_TX_DESC_CMD_ICRC;
+	uint64_t rs = IAVF_TX_DESC_CMD_RS | flags;
 
 	/* cross rx_thresh boundary is not allowed */
 	nb_pkts = RTE_MIN(nb_pkts, txq->rs_thresh);