From patchwork Fri Nov 15 13:03:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Pfeiffer X-Patchwork-Id: 63042 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E03E0A04C2; Fri, 15 Nov 2019 14:03:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E37A42C08; Fri, 15 Nov 2019 14:03:42 +0100 (CET) Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67]) by dpdk.org (Postfix) with ESMTP id 0B53A2BA8 for ; Fri, 15 Nov 2019 14:03:42 +0100 (CET) Received: from tywin.prakinf.tu-ilmenau.de (unknown [141.24.212.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id C908358006E; Fri, 15 Nov 2019 14:03:41 +0100 (CET) From: Michael Pfeiffer To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Michael Pfeiffer Date: Fri, 15 Nov 2019 14:03:28 +0100 Message-Id: <20191115130328.25683-1-michael.pfeiffer@tu-ilmenau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191115114107.30737-1-michael.pfeiffer@tu-ilmenau.de> References: <20191115114107.30737-1-michael.pfeiffer@tu-ilmenau.de> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] kni: reduce interface name size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The name in rte_kni_device_info is passed to the kernel, which allows interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a longer name currently trigger a kernel BUG in alloc_netdev_mqs in net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation. Signed-off-by: Michael Pfeiffer Acked-by: Ferruh Yigit --- lib/librte_eal/linux/eal/include/rte_kni_common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h index 46f75a710..b427cd56c 100644 --- a/lib/librte_eal/linux/eal/include/rte_kni_common.h +++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h @@ -15,10 +15,10 @@ #include #endif -/** - * KNI name is part of memzone name. +/* + * KNI name is part of memzone name. Must not exceed IFNAMSIZ. */ -#define RTE_KNI_NAMESIZE 32 +#define RTE_KNI_NAMESIZE 16 #define RTE_CACHE_LINE_MIN_SIZE 64