From patchwork Sat Nov 23 08:58:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 63259 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27222A04C1; Sat, 23 Nov 2019 09:58:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B73022952; Sat, 23 Nov 2019 09:58:40 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E772191 for ; Sat, 23 Nov 2019 09:58:38 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAN8kMJY000870 for ; Sat, 23 Nov 2019 00:58:37 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=X8IgLQ/MHna5wJTsqeSvFIZcIL457zoXdTAZGuDz5PM=; b=My0KwQld/2YECRQw35Z4v0uc904JXvKZJ0OmC6eTYMHdg4J+clvlJy1zjyjPj0AI54hT IZjJQ1cnZJENAIvnekBXhmqkhh0QcgBvU6G5vpvBH8dKUTuKMFhk55RrG4Hd+IXoO4ni JT+ahYzz7iobVxiJK+IvUZaF3mtAH9aDew0Tw5uE/6J3OzdjJupq6kId38ItZ8Hy3s4Y 5OSDonL+Yw3xD6Wy45P1AAUj3r8QEe/sBKxnGTE2XK28WfmbIrlwNh0pTLE+28LwXj2M CxQMWXuNWztmu9DZHs3m+S9cvzZMntn0yvMZAYqUj6DcDO+RkSt7uwL1bpYxG40yNi2/ yw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2weafbd4mq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Sat, 23 Nov 2019 00:58:37 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 23 Nov 2019 00:58:36 -0800 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Sat, 23 Nov 2019 00:58:36 -0800 Received: from BG-LT7430.marvell.com (unknown [10.28.17.72]) by maili.marvell.com (Postfix) with ESMTP id 207C03F703F; Sat, 23 Nov 2019 00:58:33 -0800 (PST) From: To: , Nithin Dabilpuram , "Kiran Kumar K" CC: , Pavan Nikhilesh Date: Sat, 23 Nov 2019 14:28:31 +0530 Message-ID: <20191123085832.1730-1-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-23_01:2019-11-21,2019-11-23 signatures=0 Subject: [dpdk-dev] [PATCH] net/octeontx2: fix ptype parsing disabled by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Enable Ptype parsing by default, only disable when `rte_eth_dev_set_ptypes` is called with ptype_mask as 0. This would enable applications that are dependent on packet type parsing like l3fwd. Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/net/octeontx2/otx2_ethdev.c | 4 ++++ drivers/net/octeontx2/otx2_ethdev.h | 1 + drivers/net/octeontx2/otx2_lookup.c | 7 +++++-- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c index ddab3aa06..eaf7ba917 100644 --- a/drivers/net/octeontx2/otx2_ethdev.c +++ b/drivers/net/octeontx2/otx2_ethdev.c @@ -622,6 +622,9 @@ nix_rx_offload_flags(struct rte_eth_dev *eth_dev) if ((dev->rx_offloads & DEV_RX_OFFLOAD_TIMESTAMP)) flags |= NIX_RX_OFFLOAD_TSTAMP_F; + if (!dev->ptype_disable) + flags |= NIX_RX_OFFLOAD_PTYPE_F; + return flags; } @@ -2168,6 +2171,7 @@ otx2_eth_dev_init(struct rte_eth_dev *eth_dev) dev->configured = 0; dev->drv_inited = true; + dev->ptype_disable = 0; dev->base = dev->bar2 + (RVU_BLOCK_ADDR_NIX0 << 20); dev->lmt_addr = dev->bar2 + (RVU_BLOCK_ADDR_LMT << 20); diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h index eb1626309..987e7607c 100644 --- a/drivers/net/octeontx2/otx2_ethdev.h +++ b/drivers/net/octeontx2/otx2_ethdev.h @@ -276,6 +276,7 @@ struct otx2_eth_dev { uint8_t configured_cints; uint8_t configured_nb_rx_qs; uint8_t configured_nb_tx_qs; + uint8_t ptype_disable; uint16_t nix_msixoff; uintptr_t base; uintptr_t lmt_addr; diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c index 17c44e20e..bcf2ff4e8 100644 --- a/drivers/net/octeontx2/otx2_lookup.c +++ b/drivers/net/octeontx2/otx2_lookup.c @@ -67,10 +67,13 @@ otx2_nix_ptypes_set(struct rte_eth_dev *eth_dev, uint32_t ptype_mask) { struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); - if (ptype_mask) + if (ptype_mask) { dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F; - else + dev->ptype_disable = 0; + } else { dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F; + dev->ptype_disable = 1; + } otx2_eth_set_rx_function(eth_dev);