[v1] maintainers: update for AMD xgbe and ccp crypto
Checks
Commit Message
From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
Ownership change.
Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
[AMD Public Use]
Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
>-----Original Message-----
>From: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
>Sent: Monday, April 27, 2020 11:42 AM
>To: dev@dpdk.org
>Cc: Kumar, Ravi1 <Ravi1.Kumar@amd.com>
>Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
>
>From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>
>Ownership change.
>
>Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>---
> MAINTAINERS | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/MAINTAINERS b/MAINTAINERS
>index d31a80929..c3dcedbb3 100644
>--- a/MAINTAINERS
>+++ b/MAINTAINERS
>@@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst
> F: doc/guides/nics/features/ena.ini
>
> AMD axgbe
>-M: Ravi Kumar <ravi1.kumar@amd.com>
>+M: Somalapuram Amaranath <asomalap@amd.com>
> F: drivers/net/axgbe/
> F: doc/guides/nics/axgbe.rst
> F: doc/guides/nics/features/axgbe.ini
>@@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto
> F: doc/guides/cryptodevs/features/default.ini
>
> AMD CCP Crypto
>-M: Ravi Kumar <ravi1.kumar@amd.com>
>+M: Somalapuram Amaranath <asomalap@amd.com>
> F: drivers/crypto/ccp/
> F: doc/guides/cryptodevs/ccp.rst
> F: doc/guides/cryptodevs/features/ccp.ini
>--
>2.17.1
>
On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:
> [AMD Public Use]
>
> Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
>> -----Original Message-----
>> From: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
>> Sent: Monday, April 27, 2020 11:42 AM
>> To: dev@dpdk.org
>> Cc: Kumar, Ravi1 <Ravi1.Kumar@amd.com>
>> Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
I guess net driver is called 'axgbe', good to fix while merging.
>>
>> From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>>
>> Ownership change.
>>
>> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>> ---
>> MAINTAINERS | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d31a80929..c3dcedbb3 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst
>> F: doc/guides/nics/features/ena.ini
>>
>> AMD axgbe
>> -M: Ravi Kumar <ravi1.kumar@amd.com>
>> +M: Somalapuram Amaranath <asomalap@amd.com>
>> F: drivers/net/axgbe/
>> F: doc/guides/nics/axgbe.rst
>> F: doc/guides/nics/features/axgbe.ini
>> @@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto
>> F: doc/guides/cryptodevs/features/default.ini
Thanks Ravi, Welcome Somalapuram.
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> AMD CCP Crypto
>> -M: Ravi Kumar <ravi1.kumar@amd.com>
>> +M: Somalapuram Amaranath <asomalap@amd.com>
>> F: drivers/crypto/ccp/
>> F: doc/guides/cryptodevs/ccp.rst
>> F: doc/guides/cryptodevs/features/ccp.ini
>> --
>> 2.17.1
>>
Hi Ferruh,
Do you want me to resubmit.
I see this below errors email:
From: robot@bytheb.org
Test-Label: travis-robot
Test-Status:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fpatch%2F69359&data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&sdata=WcqAv8%2BRhMq4z0YRZ9S09NuV8x7kjgc2TtX3jmvJlzA%3D&reserved=0
_Travis build: errored_
Build URL: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.com%2Fovsrobot%2Fdpdk%2Fbuilds%2F162163735&data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&sdata=plABOXG44ijGqIo5CHCHWerbirVOlf5hujOFiWkysb4%3D&reserved=0
Regards,
S.Amarnath
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com>
Sent: Monday, April 27, 2020 4:29 PM
To: Kumar, Ravi1 <Ravi1.Kumar@amd.com>; Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
[CAUTION: External Email]
On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:
> [AMD Public Use]
>
> Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
>> -----Original Message-----
>> From: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
>> Sent: Monday, April 27, 2020 11:42 AM
>> To: dev@dpdk.org
>> Cc: Kumar, Ravi1 <Ravi1.Kumar@amd.com>
>> Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
I guess net driver is called 'axgbe', good to fix while merging.
>>
>> From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>>
>> Ownership change.
>>
>> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>> ---
>> MAINTAINERS | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d31a80929..c3dcedbb3 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst
>> F: doc/guides/nics/features/ena.ini
>>
>> AMD axgbe
>> -M: Ravi Kumar <ravi1.kumar@amd.com>
>> +M: Somalapuram Amaranath <asomalap@amd.com>
>> F: drivers/net/axgbe/
>> F: doc/guides/nics/axgbe.rst
>> F: doc/guides/nics/features/axgbe.ini
>> @@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto
>> F: doc/guides/cryptodevs/features/default.ini
Thanks Ravi, Welcome Somalapuram.
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> AMD CCP Crypto
>> -M: Ravi Kumar <ravi1.kumar@amd.com>
>> +M: Somalapuram Amaranath <asomalap@amd.com>
>> F: drivers/crypto/ccp/
>> F: doc/guides/cryptodevs/ccp.rst
>> F: doc/guides/cryptodevs/features/ccp.ini
>> --
>> 2.17.1
>>
On 4/27/2020 12:24 PM, Somalapuram, Amaranath wrote:
> Hi Ferruh,
>
> Do you want me to resubmit.
Hi Amaranath,
No need to send a new version.
>
> I see this below errors email:
>
> From: robot@bytheb.org
>
> Test-Label: travis-robot
> Test-Status:
> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fpatch%2F69359&data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&sdata=WcqAv8%2BRhMq4z0YRZ9S09NuV8x7kjgc2TtX3jmvJlzA%3D&reserved=0
>
> _Travis build: errored_
> Build URL: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.com%2Fovsrobot%2Fdpdk%2Fbuilds%2F162163735&data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&sdata=plABOXG44ijGqIo5CHCHWerbirVOlf5hujOFiWkysb4%3D&reserved=0
The travis error seems unrelated [1], cc'ed David and Aaron for it.
[1] Two issues reported
a) ninja: build stopped: Error writing to build log: Disk quota exceeded.
b) No output has been received in the last 10m0s, this potentially indicates a
stalled build or something wrong with the build itself.
Also community lab tests seems failing because of the mellanox performance
report, but this patch is not something that can affect the performance.
Cc'ed Raslan & Ali and lab for it.
https://lab.dpdk.org/results/dashboard/patchsets/10717/
>
> Regards,
> S.Amarnath
>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, April 27, 2020 4:29 PM
> To: Kumar, Ravi1 <Ravi1.Kumar@amd.com>; Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
>
> [CAUTION: External Email]
>
> On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:
>> [AMD Public Use]
>>
>> Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
>>> -----Original Message-----
>>> From: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
>>> Sent: Monday, April 27, 2020 11:42 AM
>>> To: dev@dpdk.org
>>> Cc: Kumar, Ravi1 <Ravi1.Kumar@amd.com>
>>> Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
>
> I guess net driver is called 'axgbe', good to fix while merging.
>
>>>
>>> From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>>>
>>> Ownership change.
>>>
>>> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>>> ---
>>> MAINTAINERS | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index d31a80929..c3dcedbb3 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst
>>> F: doc/guides/nics/features/ena.ini
>>>
>>> AMD axgbe
>>> -M: Ravi Kumar <ravi1.kumar@amd.com>
>>> +M: Somalapuram Amaranath <asomalap@amd.com>
>>> F: drivers/net/axgbe/
>>> F: doc/guides/nics/axgbe.rst
>>> F: doc/guides/nics/features/axgbe.ini
>>> @@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto
>>> F: doc/guides/cryptodevs/features/default.ini
>
> Thanks Ravi, Welcome Somalapuram.
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
>>>
>>> AMD CCP Crypto
>>> -M: Ravi Kumar <ravi1.kumar@amd.com>
>>> +M: Somalapuram Amaranath <asomalap@amd.com>
>>> F: drivers/crypto/ccp/
>>> F: doc/guides/cryptodevs/ccp.rst
>>> F: doc/guides/cryptodevs/features/ccp.ini
>>> --
>>> 2.17.1
>>>
>
Ferruh Yigit <ferruh.yigit@intel.com> writes:
> On 4/27/2020 12:24 PM, Somalapuram, Amaranath wrote:
>> Hi Ferruh,
>>
>> Do you want me to resubmit.
>
> Hi Amaranath,
>
> No need to send a new version.
>
>>
>> I see this below errors email:
>>
>> From: robot@bytheb.org
>>
>> Test-Label: travis-robot
>> Test-Status:
>> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fpatch%2F69359&data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&sdata=WcqAv8%2BRhMq4z0YRZ9S09NuV8x7kjgc2TtX3jmvJlzA%3D&reserved=0
>>
>> _Travis build: errored_
>> Build URL:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.com%2Fovsrobot%2Fdpdk%2Fbuilds%2F162163735&data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&sdata=plABOXG44ijGqIo5CHCHWerbirVOlf5hujOFiWkysb4%3D&reserved=0
>
> The travis error seems unrelated [1], cc'ed David and Aaron for it.
I agree.
> [1] Two issues reported
> a) ninja: build stopped: Error writing to build log: Disk quota
> exceeded.
This occurs on some of the ARM64 builds. Travis is aware of the issue,
but don't seem urgently fixing it. :-/ I think we have a series
outstanding that should be applied to drop those builds for now.
> b) No output has been received in the last 10m0s, this potentially indicates a
> stalled build or something wrong with the build itself.
This is a future enhancement I need to work on. When a build has jobs
that are stalled / errored, we need to restart them (at least once). Or
otherwise flag it. It especially happens when internal travis
infrastructure fails.
>
> Also community lab tests seems failing because of the mellanox performance
> report, but this patch is not something that can affect the performance.
> Cc'ed Raslan & Ali and lab for it.
> https://lab.dpdk.org/results/dashboard/patchsets/10717/
>
>>
>> Regards,
>> S.Amarnath
>>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, April 27, 2020 4:29 PM
>> To: Kumar, Ravi1 <Ravi1.Kumar@amd.com>; Somalapuram, Amaranath
>> <Amaranath.Somalapuram@amd.com>; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
>>
>> [CAUTION: External Email]
>>
>> On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:
>>> [AMD Public Use]
>>>
>>> Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
>>>> -----Original Message-----
>>>> From: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
>>>> Sent: Monday, April 27, 2020 11:42 AM
>>>> To: dev@dpdk.org
>>>> Cc: Kumar, Ravi1 <Ravi1.Kumar@amd.com>
>>>> Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
>>
>> I guess net driver is called 'axgbe', good to fix while merging.
>>
>>>>
>>>> From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>>>>
>>>> Ownership change.
>>>>
>>>> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>>>> ---
>>>> MAINTAINERS | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index d31a80929..c3dcedbb3 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst
>>>> F: doc/guides/nics/features/ena.ini
>>>>
>>>> AMD axgbe
>>>> -M: Ravi Kumar <ravi1.kumar@amd.com>
>>>> +M: Somalapuram Amaranath <asomalap@amd.com>
>>>> F: drivers/net/axgbe/
>>>> F: doc/guides/nics/axgbe.rst
>>>> F: doc/guides/nics/features/axgbe.ini
>>>> @@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto
>>>> F: doc/guides/cryptodevs/features/default.ini
>>
>> Thanks Ravi, Welcome Somalapuram.
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>>>>
>>>> AMD CCP Crypto
>>>> -M: Ravi Kumar <ravi1.kumar@amd.com>
>>>> +M: Somalapuram Amaranath <asomalap@amd.com>
>>>> F: drivers/crypto/ccp/
>>>> F: doc/guides/cryptodevs/ccp.rst
>>>> F: doc/guides/cryptodevs/features/ccp.ini
>>>> --
>>>> 2.17.1
>>>>
>>
27/04/2020 14:58, Aaron Conole:
> Ferruh Yigit <ferruh.yigit@intel.com> writes:
> > [1] Two issues reported
> > a) ninja: build stopped: Error writing to build log: Disk quota
> > exceeded.
>
> This occurs on some of the ARM64 builds. Travis is aware of the issue,
> but don't seem urgently fixing it. :-/ I think we have a series
> outstanding that should be applied to drop those builds for now.
I saw some "Disk quota exceeded" on x86 static builds.
So I changed my mind, I am not sure dropping only Arm from Travis
is a solution, even temporary.
> > b) No output has been received in the last 10m0s, this potentially indicates a
> > stalled build or something wrong with the build itself.
>
> This is a future enhancement I need to work on. When a build has jobs
> that are stalled / errored, we need to restart them (at least once). Or
> otherwise flag it. It especially happens when internal travis
> infrastructure fails.
Yes Travis infrastructure fails. Always.
Travis is free, but it is not a reason to provide a randomly failing tool.
I suggest switching to other platforms like OBS or our community lab,
preferring the most reliable one.
27/04/2020 12:58, Ferruh Yigit:
> On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:
> > [AMD Public Use]
> >
> > Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
> >> -----Original Message-----
> >> From: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
> >> Sent: Monday, April 27, 2020 11:42 AM
> >> To: dev@dpdk.org
> >> Cc: Kumar, Ravi1 <Ravi1.Kumar@amd.com>
> >> Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto
>
> I guess net driver is called 'axgbe', good to fix while merging.
Fixed
> >>
> >> From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
Changed email address to match the one filled in MAINTAINERS file
and in previous contributions.
> >>
> >> Ownership change.
> >>
> >> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
> >> ---
> >> AMD axgbe
> >> -M: Ravi Kumar <ravi1.kumar@amd.com>
> >> +M: Somalapuram Amaranath <asomalap@amd.com>
>
> Thanks Ravi, Welcome Somalapuram.
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> >> AMD CCP Crypto
> >> -M: Ravi Kumar <ravi1.kumar@amd.com>
> >> +M: Somalapuram Amaranath <asomalap@amd.com>
Applied
Thomas Monjalon <thomas@monjalon.net> writes:
> 27/04/2020 14:58, Aaron Conole:
>> Ferruh Yigit <ferruh.yigit@intel.com> writes:
>> > [1] Two issues reported
>> > a) ninja: build stopped: Error writing to build log: Disk quota
>> > exceeded.
>>
>> This occurs on some of the ARM64 builds. Travis is aware of the issue,
>> but don't seem urgently fixing it. :-/ I think we have a series
>> outstanding that should be applied to drop those builds for now.
>
> I saw some "Disk quota exceeded" on x86 static builds.
> So I changed my mind, I am not sure dropping only Arm from Travis
> is a solution, even temporary.
Okay.
>
>> > b) No output has been received in the last 10m0s, this potentially indicates a
>> > stalled build or something wrong with the build itself.
>>
>> This is a future enhancement I need to work on. When a build has jobs
>> that are stalled / errored, we need to restart them (at least once). Or
>> otherwise flag it. It especially happens when internal travis
>> infrastructure fails.
>
> Yes Travis infrastructure fails. Always.
> Travis is free, but it is not a reason to provide a randomly failing tool.
It has been quite useful - it shows us that we still have some
incomplete unit tests and also some racy unit tests. I agree, it
shouldn't be failing the way it is.
> I suggest switching to other platforms like OBS or our community lab,
> preferring the most reliable one.
OBS and community lab isn't as easy for individual developers to
integrate with. One thing that's been useful for me is to push to my
github repo and see the results of all the build configurations. It
doesn't require much effort from my side to ensure that code works. I
don't always do this (but that's my bad habit), but when I do it proves
very useful.
Maybe the new github-ci (I think it's called 'actions') would be good to
investigate. Also, Cirrus-CI lets us test on windows and freebsd. And
there's no reason we can't use all of them.
@@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst
F: doc/guides/nics/features/ena.ini
AMD axgbe
-M: Ravi Kumar <ravi1.kumar@amd.com>
+M: Somalapuram Amaranath <asomalap@amd.com>
F: drivers/net/axgbe/
F: doc/guides/nics/axgbe.rst
F: doc/guides/nics/features/axgbe.ini
@@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto
F: doc/guides/cryptodevs/features/default.ini
AMD CCP Crypto
-M: Ravi Kumar <ravi1.kumar@amd.com>
+M: Somalapuram Amaranath <asomalap@amd.com>
F: drivers/crypto/ccp/
F: doc/guides/cryptodevs/ccp.rst
F: doc/guides/cryptodevs/features/ccp.ini