diff mbox series

net/virtio: fix 32-bit build with clang 6.0.0

Message ID 20200506064737.80627-1-yong.liu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers show
Series net/virtio: fix 32-bit build with clang 6.0.0 | expand

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Marvin Liu May 6, 2020, 6:47 a.m. UTC
Clang 6.0.0 will undefine function _mm512_maskz_set1_epi64 on i686
target. Fix it by replacing the function with _mm512_set4_epi64 when
doing 32-bit build.

Warning messasge during build:
../drivers/net/virtio/virtio_rxtx_packed_avx.c:385:19: warning:
implicit declaration of function '_mm512_maskz_set1_epi64' is invalid
in C99 [-Wimplicit-function-declaration]

Fixes: 8d35836e4a7c ("net/virtio: add vectorized packed ring Rx path")
Signed-off-by: Marvin Liu <yong.liu@intel.com>

Comments

Maxime Coquelin May 7, 2020, 10:02 a.m. UTC | #1
On 5/6/20 8:47 AM, Marvin Liu wrote:
> Clang 6.0.0 will undefine function _mm512_maskz_set1_epi64 on i686
> target. Fix it by replacing the function with _mm512_set4_epi64 when
> doing 32-bit build.
> 
> Warning messasge during build:
> ../drivers/net/virtio/virtio_rxtx_packed_avx.c:385:19: warning:
> implicit declaration of function '_mm512_maskz_set1_epi64' is invalid
> in C99 [-Wimplicit-function-declaration]
> 
> Fixes: 8d35836e4a7c ("net/virtio: add vectorized packed ring Rx path")
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Maxime Coquelin May 7, 2020, 2:18 p.m. UTC | #2
On 5/6/20 8:47 AM, Marvin Liu wrote:
> Clang 6.0.0 will undefine function _mm512_maskz_set1_epi64 on i686
> target. Fix it by replacing the function with _mm512_set4_epi64 when
> doing 32-bit build.
> 
> Warning messasge during build:
> ../drivers/net/virtio/virtio_rxtx_packed_avx.c:385:19: warning:
> implicit declaration of function '_mm512_maskz_set1_epi64' is invalid
> in C99 [-Wimplicit-function-declaration]
> 
> Fixes: 8d35836e4a7c ("net/virtio: add vectorized packed ring Rx path")
> Signed-off-by: Marvin Liu <yong.liu@intel.com>

Applied to dpdk-next-virtio/master

Thanks,
Maxime
diff mbox series

Patch

diff --git a/drivers/net/virtio/virtio_rxtx_packed_avx.c b/drivers/net/virtio/virtio_rxtx_packed_avx.c
index d130d68bf..6a8214725 100644
--- a/drivers/net/virtio/virtio_rxtx_packed_avx.c
+++ b/drivers/net/virtio/virtio_rxtx_packed_avx.c
@@ -365,7 +365,12 @@  virtqueue_dequeue_batch_packed_vec(struct virtnet_rx *rxvq,
 		return -1;
 
 	/* only care avail/used bits */
+#if defined(RTE_ARCH_I686)
+	__m512i v_mask = _mm512_set4_epi64(PACKED_FLAGS_MASK, 0x0,
+					   PACKED_FLAGS_MASK, 0x0);
+#else
 	__m512i v_mask = _mm512_maskz_set1_epi64(0xaa, PACKED_FLAGS_MASK);
+#endif
 	desc_addr = &vq->vq_packed.ring.desc[id];
 
 	__m512i v_desc = _mm512_loadu_si512(desc_addr);
@@ -373,7 +378,12 @@  virtqueue_dequeue_batch_packed_vec(struct virtnet_rx *rxvq,
 
 	__m512i v_used_flag = _mm512_setzero_si512();
 	if (vq->vq_packed.used_wrap_counter)
+#if defined(RTE_ARCH_I686)
+		v_used_flag = _mm512_set4_epi64(PACKED_FLAGS_MASK, 0x0,
+						PACKED_FLAGS_MASK, 0x0);
+#else
 		v_used_flag = _mm512_maskz_set1_epi64(0xaa, PACKED_FLAGS_MASK);
+#endif
 
 	/* Check all descs are used */
 	desc_stats = _mm512_cmpneq_epu64_mask(v_flag, v_used_flag);