From patchwork Thu Jul 2 03:13:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinan Sun X-Patchwork-Id: 72713 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B24E1A0523; Thu, 2 Jul 2020 05:32:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5ABD41D662; Thu, 2 Jul 2020 05:31:07 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 89EC51D65C for ; Thu, 2 Jul 2020 05:31:05 +0200 (CEST) IronPort-SDR: B51FtxKxE2d2dIRBVJNTMBVWLWZjJGb42Vm39dLjAKkrZcObWt8gGDf597/SRjo3aPC1z9Vw0p WaaT2C8RrzRQ== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="144300653" X-IronPort-AV: E=Sophos;i="5.75,302,1589266800"; d="scan'208";a="144300653" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 20:31:05 -0700 IronPort-SDR: FQ9q5zcZVEM8hdlfqc0sYeZeQrfnWoCs+6iXKTx4MhYW2D25cnCqC/rpfYvpZGVXSSniOkn8Mh a47/LO7PMnMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,302,1589266800"; d="scan'208";a="295751595" Received: from intel.sh.intel.com ([10.239.255.18]) by orsmga002.jf.intel.com with ESMTP; 01 Jul 2020 20:31:03 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Jeff Guo , Zhao1 Wei , Guinan Sun , Zalfresso-Jundzillo Date: Thu, 2 Jul 2020 03:13:22 +0000 Message-Id: <20200702031329.4495-14-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200702031329.4495-1-guinanx.sun@intel.com> References: <20200612032410.20864-1-guinanx.sun@intel.com> <20200702031329.4495-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH v2 13/20] net/ixgbe/base: remove unnecessary log message FC autonego X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function ixgbe_device_supports_autoneg_fc is checking whether a particular device and medium configuration is supporting Flow Control Autonegotiation. In case of non-support, the message is always logged which is confusing. The fix is removing unnecessary log entry. Signed-off-by: Zalfresso-Jundzillo Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_common.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index c4e99d876..4a3b48b39 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -187,10 +187,6 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw) break; } - if (!supported) - ERROR_REPORT2(IXGBE_ERROR_UNSUPPORTED, - "Device %x does not support flow control autoneg", - hw->device_id); return supported; }