[2/2] devtools: fix forbidden token
Checks
Commit Message
An expression with a space is split by the awk script resulting in
false positive for any patch matching any of the two part of the
expression.
Fix this by using [[:space:]].
Fixes: 43e73483a4b8 ("devtools: forbid variable declaration inside for")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
06/07/2020 10:00, David Marchand:
> An expression with a space is split by the awk script resulting in
> false positive for any patch matching any of the two part of the
> expression.
> Fix this by using [[:space:]].
>
> Fixes: 43e73483a4b8 ("devtools: forbid variable declaration inside for")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied, thanks
@@ -71,7 +71,7 @@ check_forbidden_additions() { # <patch>
# forbid variable declaration inside "for" loop
awk -v FOLDERS='.' \
- -v EXPRESSIONS='for *\\((char|u?int|unsigned|s?size_t)' \
+ -v EXPRESSIONS='for[[:space:]]*\\((char|u?int|unsigned|s?size_t)' \
-v RET_ON_FAIL=1 \
-v MESSAGE='Declaring a variable inside for()' \
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \