[v2] eal/windows: add pthread TLS function support
Checks
Commit Message
Add the following functions to the pthread shim implementation
for Windows as they are needed for thread safe rte_flow functions.
pthread_key_create.
pthread_key_delete.
pthread_getspecific.
pthread_setspecific.
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
v2: fix style issues
---
lib/librte_eal/windows/include/pthread.h | 43 ++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
Comments
On Sun, 13 Dec 2020 22:24:37 +0200, Tal Shnaiderman wrote:
> Add the following functions to the pthread shim implementation
> for Windows as they are needed for thread safe rte_flow functions.
>
> pthread_key_create.
> pthread_key_delete.
> pthread_getspecific.
> pthread_setspecific.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> v2: fix style issues
> ---
> lib/librte_eal/windows/include/pthread.h | 43 ++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
It's been planned to remove the shim, not to extend it; and to introduce a
generic threading API in EAL. Why not start with these functions? It's quite
an isolated set.
@@ -34,6 +34,8 @@ typedef CRITICAL_SECTION pthread_mutex_t;
typedef SYNCHRONIZATION_BARRIER pthread_barrier_t;
+typedef DWORD pthread_key_t;
+
#define pthread_barrier_init(barrier, attr, count) \
InitializeSynchronizationBarrier(barrier, count, -1)
#define pthread_barrier_wait(barrier) EnterSynchronizationBarrier(barrier, \
@@ -179,6 +181,47 @@ pthread_mutex_destroy(pthread_mutex_t *mutex)
return 0;
}
+static inline int
+pthread_key_create(pthread_key_t *key,
+ __rte_unused void (*destructor)(void *))
+{
+ *key = TlsAlloc();
+ if ((*key) == TLS_OUT_OF_INDEXES) {
+ RTE_LOG_WIN32_ERR("TlsAlloc()");
+ return -ENOMEM;
+ }
+ return 0;
+}
+
+static inline int
+pthread_key_delete(pthread_key_t key)
+{
+ if (!TlsFree(key)) {
+ RTE_LOG_WIN32_ERR("TlsFree()");
+ return -1;
+ }
+ return 0;
+}
+
+static inline void *
+pthread_getspecific(pthread_key_t key)
+{
+ return TlsGetValue(key);
+}
+
+static inline int
+pthread_setspecific(pthread_key_t key, const void *value)
+{
+ /* discard const qualifier */
+ char *p = (char *) (uintptr_t) value;
+
+ if (!TlsSetValue(key, p)) {
+ RTE_LOG_WIN32_ERR("TlsSetValue()");
+ return -1;
+ }
+ return 0;
+}
+
#ifdef __cplusplus
}
#endif