[v2] eal: fix errno on service cores init failure
Checks
Commit Message
Currently, when rte_service_init() fails at initialization, we
see the following message:
Cannot init EAL: Exec format error
This error code does describe the real issue. Instead, use the error
code returned by the function.
Fixes: e39824500825 ("service: initialize with EAL")
Cc: stable@dpdk.org
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
v2
* rebase on top of main branch
* add same change for windows
lib/librte_eal/freebsd/eal.c | 4 ++--
lib/librte_eal/linux/eal.c | 4 ++--
lib/librte_eal/windows/eal.c | 6 ++++--
3 files changed, 8 insertions(+), 6 deletions(-)
Comments
On Wed, Jan 13, 2021 at 9:29 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> Currently, when rte_service_init() fails at initialization, we
> see the following message:
>
> Cannot init EAL: Exec format error
>
> This error code does describe the real issue. Instead, use the error
> code returned by the function.
>
> Fixes: e39824500825 ("service: initialize with EAL")
> Cc: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks.
@@ -906,7 +906,7 @@ rte_eal_init(int argc, char **argv)
ret = rte_service_init();
if (ret) {
rte_eal_init_alert("rte_service_init() failed");
- rte_errno = ENOEXEC;
+ rte_errno = -ret;
return -1;
}
@@ -922,7 +922,7 @@ rte_eal_init(int argc, char **argv)
*/
ret = rte_service_start_with_defaults();
if (ret < 0 && ret != -ENOTSUP) {
- rte_errno = ENOEXEC;
+ rte_errno = -ret;
return -1;
}
@@ -1273,7 +1273,7 @@ rte_eal_init(int argc, char **argv)
ret = rte_service_init();
if (ret) {
rte_eal_init_alert("rte_service_init() failed");
- rte_errno = ENOEXEC;
+ rte_errno = -ret;
return -1;
}
@@ -1295,7 +1295,7 @@ rte_eal_init(int argc, char **argv)
*/
ret = rte_service_start_with_defaults();
if (ret < 0 && ret != -ENOTSUP) {
- rte_errno = ENOEXEC;
+ rte_errno = -ret;
return -1;
}
@@ -264,6 +264,7 @@ rte_eal_init(int argc, char **argv)
const struct rte_config *config = rte_eal_get_configuration();
struct internal_config *internal_conf =
eal_get_internal_configuration();
+ int ret;
rte_eal_log_init(NULL, 0);
@@ -387,9 +388,10 @@ rte_eal_init(int argc, char **argv)
}
/* Initialize services so drivers can register services during probe. */
- if (rte_service_init()) {
+ ret = rte_service_init();
+ if (ret) {
rte_eal_init_alert("rte_service_init() failed");
- rte_errno = ENOEXEC;
+ rte_errno = -ret;
return -1;
}