diff mbox series

mbuf: remove unneeded EAL header include

Message ID 20210129203307.25123-1-david.marchand@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series mbuf: remove unneeded EAL header include |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing warning Testing issues

Commit Message

David Marchand Jan. 29, 2021, 8:33 p.m. UTC 
There is no need for the direct inclusion of the generic/ header [1]
now that we don't use the rte_atomic API anymore.

1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7

Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_mbuf/rte_mbuf_core.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Ruifeng Wang Feb. 1, 2021, 7:51 a.m. UTC | #1 
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Saturday, January 30, 2021 4:33 AM
> To: dev@dpdk.org
> Cc: konstantin.ananyev@intel.com; bruce.richardson@intel.com;
> stable@dpdk.org; Olivier Matz <olivier.matz@6wind.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com>; Andrew
> Rybchenko <arybchenko@solarflare.com>; thomas@monjalon.net
> Subject: [PATCH] mbuf: remove unneeded EAL header include
> 
> There is no need for the direct inclusion of the generic/ header [1] now that
> we don't use the rte_atomic API anymore.
> 
> 1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
> 
> Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  lib/librte_mbuf/rte_mbuf_core.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf_core.h
> b/lib/librte_mbuf/rte_mbuf_core.h index a85cabdd18..9d1609336a 100644
> --- a/lib/librte_mbuf/rte_mbuf_core.h
> +++ b/lib/librte_mbuf/rte_mbuf_core.h
> @@ -20,7 +20,6 @@
> 
>  #include <rte_compat.h>
>  #include <rte_byteorder.h>
> -#include <generic/rte_atomic.h>
> 
>  #ifdef __cplusplus
>  extern "C" {
> --
> 2.23.0

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
diff mbox series

Patch

diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
index a85cabdd18..9d1609336a 100644
--- a/lib/librte_mbuf/rte_mbuf_core.h
+++ b/lib/librte_mbuf/rte_mbuf_core.h
@@ -20,7 +20,6 @@ 
 
 #include <rte_compat.h>
 #include <rte_byteorder.h>
-#include <generic/rte_atomic.h>
 
 #ifdef __cplusplus
 extern "C" {