From patchwork Tue Feb 16 20:35:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 87954 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EF5BA054D; Tue, 16 Feb 2021 21:37:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16A0E160815; Tue, 16 Feb 2021 21:36:19 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id E4EA71607F9 for ; Tue, 16 Feb 2021 21:36:15 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id c19so31868pjq.3 for ; Tue, 16 Feb 2021 12:36:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=DvgvfWSZ5T++gECStxr6V74FNWCdtej6oqiRpIiOyxI=; b=aE3oMumXyHy7qszISNuL/ClRMoCBEI2R+95HVZJmlqDuOznyaaTKX2oK33qnd6mFxJ XZ3RJny7M2QGPr1VFDwI6LglfPJA4K+831QP+2l6mD7ZG1bMsvPWLAXWEI/Bj5gLoPXb FVSGKLvbVrLJZHnC0XhcFzTlsTWnl7gL90xkC/tGDTkvD5hn2pG6p9zLQH0EiLOtJ6vY fmghj6nUTkQNlydVgFcwx3NARohf0/A3h6TfJkKmK8LdoNcmpY7QKqqqswdWGX29Tqjd lCoX7JTn9MQg6aaB1Sp+NKZ3a55rquZ+i7hfUSa+DL3epP/puG0hXQ7buocHs4z11pbo rpCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=DvgvfWSZ5T++gECStxr6V74FNWCdtej6oqiRpIiOyxI=; b=uC3g9Krns2OmkSajqu2s3aKjOdCKeQFdLNTC6OsiP0Ctmz/AGwQateF3hzCnKRPzrl 2wM0KCE3Nh2WOTrTE39vi864EbWgSLJ4QhPMyh1QS0UbcKSfCpcIgsa/Wy0xp4CD+qh1 u/PtRwWbEE0iUX26GZynkq53a9cGl411xdzg7h+8D9c9WpMZIoKgyetJJgVerOsBudXI hR8w7o+z/o3iQ1ZbZu1lq3RSh0sYXBtKQDAJoWhOSP//AHCIOFuHneU1wBH91Ic9MRLv yt2wRGGmKg50dZBSSCXhX8InolwrwB2NK04j2+cN9vWbdxCZaO2By/psegkfY+ia8phL Ctrg== X-Gm-Message-State: AOAM531BR6eHMWpsZRraej/TEIt11n87SQkpF6RufzWcGGYX1AvIsc5I zXo4P1iMTaT7IQZsQCZ2GEtNavboRZ0xhg== X-Google-Smtp-Source: ABdhPJwWDxRlrsW0HwdWPFMgDDeMb6KpgEJdhiXUJ7C/QZdKT7meUQegX8zBYBw1Xy3n3pwJCnanNA== X-Received: by 2002:a17:90a:c684:: with SMTP id n4mr5993244pjt.13.1613507775006; Tue, 16 Feb 2021 12:36:15 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id u17sm11371pgh.72.2021.02.16.12.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Feb 2021 12:36:14 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer , stable@dpdk.org Date: Tue, 16 Feb 2021 12:35:40 -0800 Message-Id: <20210216203540.29290-16-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210216203540.29290-1-aboyer@pensando.io> References: <20210216203540.29290-1-aboyer@pensando.io> In-Reply-To: <20210204195853.13411-1-aboyer@pensando.io> References: <20210204195853.13411-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH v2 15/15] net/ionic: fix code around lif init devcmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The completion type was wrong. Don't check the completion if the wait timed out. Fixes: 669c8de67c88 ("net/ionic: support basic LIF") Cc: cardigliano@ntop.org Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index b8023e0632..cd220abee2 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -1605,17 +1605,18 @@ int ionic_lif_init(struct ionic_lif *lif) { struct ionic_dev *idev = &lif->adapter->idev; - struct ionic_q_init_comp comp; + struct ionic_lif_init_comp comp; int err; memset(&lif->stats_base, 0, sizeof(lif->stats_base)); ionic_dev_cmd_lif_init(idev, lif->info_pa); err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT); - ionic_dev_cmd_comp(idev, &comp); if (err) return err; + ionic_dev_cmd_comp(idev, &comp); + lif->hw_index = rte_cpu_to_le_16(comp.hw_index); err = ionic_lif_adminq_init(lif);