From patchwork Sun Feb 21 11:16:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 88058 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84134A034F; Sun, 21 Feb 2021 12:16:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03AEB22A2A7; Sun, 21 Feb 2021 12:16:47 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id F13A122A2A4; Sun, 21 Feb 2021 12:16:45 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11LB9eMW020545; Sun, 21 Feb 2021 03:16:45 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=UuYLNLVvs2EEUerQ0Sbf/NZWMvmILP9lVNcUj1q3bPU=; b=Qjt3ZtCnZG4rp24QKJDjU3hhqB5ZoNZ9LyVrAswIg0+UqP7rhFQgdJj+7ThThDIobnya zvmvVbTT0tvf7X0rYhgTHYmGrVFxbT2sJ+22sQj1bcBvZ62Kpm5q3jDRtL3FKUQ10SZY 4u4zrofxb78Xb2LFhEYLCxnoQ0P5zEXV7JkPwPs1JjXXqjUO1cjbRm22GnGc3iSw/JDR F6FWTxxysZy9wCP+vvbeeUlnVIa2KIwhwyYtJ9EcKfDt4jDvHaCsSyOppcqxRPfWEvkw i+EEqGhSPa1TfrQwQXyGgwdVk78GXG8kg/4Qs3woVMaNgUuRbR5z3IN4Y+THIfmJOf5O 4A== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com with ESMTP id 36u2tu1jcr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 21 Feb 2021 03:16:45 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Feb 2021 03:16:43 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 21 Feb 2021 03:16:43 -0800 Received: from EL-LT0043.marvell.com (unknown [10.193.38.106]) by maili.marvell.com (Postfix) with ESMTP id 0B12D3F703F; Sun, 21 Feb 2021 03:16:41 -0800 (PST) From: Igor Russkikh To: CC: Rasesh Mody , Devendra Singh Rawat , Igor Russkikh , Date: Sun, 21 Feb 2021 12:16:37 +0100 Message-ID: <20210221111637.31193-3-irusskikh@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210221111637.31193-1-irusskikh@marvell.com> References: <20210221111637.31193-1-irusskikh@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-02-21_03:2021-02-18, 2021-02-21 signatures=0 Subject: [dpdk-dev] [PATCH 2/2] qede: make driver accept bigger rss tables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We found some dpdk applications blindly pass fixed side rss hash tables, and do not check driver/device capabilities. Moreover, many other drivers do not do such a strong check as well. So here we fix it, making qede accept any size rss_key. For larger key tables we just crop it with notice trace message. CC: stable@dpdk.org Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index ab5f5b106..7363d98f2 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -2139,8 +2139,8 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev, /* RSS hash key */ if (key) { if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) { - DP_ERR(edev, "RSS key length exceeds limit\n"); - return -EINVAL; + len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t); + DP_NOTICE(edev, false, "RSS key length exceeds limit\n"); } DP_INFO(edev, "Applying user supplied hash key\n"); rss_params.update_rss_key = 1;