From patchwork Wed Mar 10 13:53:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wisam Monther X-Patchwork-Id: 88872 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD0DAA0567; Wed, 10 Mar 2021 14:54:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 393DD22A696; Wed, 10 Mar 2021 14:54:19 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2063.outbound.protection.outlook.com [40.107.94.63]) by mails.dpdk.org (Postfix) with ESMTP id C1FA722A684 for ; Wed, 10 Mar 2021 14:54:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jx4yE5Qt+oVBgKmiok680EL6Z5haH20Fzfre+rtBOw7dWr4A0U0wSC4Jz36D19WNa9ObMWlkmYP6k+0fBY/9B2hweX1JotWzPjiXXjFx93I86c8TUy1+1ICcbjykkKaHWM4cjVqcmK74KYvYb6nqh/ZTT1vqSB3I0QT3h7tulgGB3dPNxY7jCB5/ojs7T+50Wj3beRmHVppQOa2oj7n5NoToHGgQAscNwfF8M/x9qVaD6x1jY1u9Z+zUBuiE6JUyvBFulAdfzru5TbrFyKnVGAw4XUqH2ZdqsEvDf6uTT7ISUQNtsxmI92r8puW4Vta3EB5yvg/dnB4m/3jjPGOs6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=; b=VKfUiBDY9R7dX3ZHxPCJD3Rb4Q1RCkK25OSWKQFUStGA1gV0hqcYTF5uXgGWmOP7gJQqOsBCq646lxHPSZ9+en+geFKA2Dhvlj6uqgFgll6XjcNmDs6fKW69WqM3a7dGH60Wrzky1Foa7pnym3CWVcdnPZ/73NLheQljmHsLZZzr2y3tmiBTEtNkHXPw8JCP5p/2JwL5GkOKij58NpLG+PIVBPAOK5vM7onOAE529Hrht1A+BaURjUb9iGpOerxGV8oBvMRkS0/GT5dHHGXJ1hEt2t8zaEzbgkb/Bq3xv31OyZL3Xa6zbhoxiODppf7+CCIe7PyJ3B98TnG9yqYMAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=; b=lKU/JMV3SEtjzKGKURCEWYz5ixjgyeZw4bO7/qyd1dvqWAnmJXiFh4RV1q2dOZhYlugC+u/YVtpsqKvmxOGcMXZGPEvaGFaw9byRB7/GVdrxLjUm+sjiEJKaZY5x9tvG6C9kk4n2HZbaAX4/TIt8uZkLCjXXjwG7GhjVzVpZsC+6++dvMKrPMLnK05BLitMUdFchih/FP/k3hLklHKaysq8krz4ji7+wADD7HeqFbvp9dEAfIigHGxiu3jWfkrIWTf+3twvThYoAR7zFC9D3h6J4GiTxYw6nbtgburCB+ZKZteFiJG+4Qm9L12/tsPAC4AWptJG5oC7rEeOvhpXoWA== Received: from BN1PR13CA0011.namprd13.prod.outlook.com (2603:10b6:408:e2::16) by DM6PR12MB3497.namprd12.prod.outlook.com (2603:10b6:5:3c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 10 Mar 2021 13:54:14 +0000 Received: from BN8NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e2:cafe::ae) by BN1PR13CA0011.outlook.office365.com (2603:10b6:408:e2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.13 via Frontend Transport; Wed, 10 Mar 2021 13:54:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT049.mail.protection.outlook.com (10.13.177.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 10 Mar 2021 13:54:14 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar 2021 13:54:12 +0000 From: Wisam Jaddo To: , , , , CC: Date: Wed, 10 Mar 2021 15:53:49 +0200 Message-ID: <20210310135353.8429-4-wisamm@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210310135353.8429-1-wisamm@nvidia.com> References: <20210310134858.8104-2-wisamm@nvidia.com> <20210310135353.8429-1-wisamm@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 541c1623-0022-477d-f532-08d8e3cbfdc1 X-MS-TrafficTypeDiagnostic: DM6PR12MB3497: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:204; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8MZm7jRBWjEnjSEOjmbhPhx5mFEEgOTfuvaXmgW/ZgGgV61SSeu2HKryTIrxFxTZn7fiysNjJPJsuD8OSCmZvAe52v3ENMOEJ7QGNN8qJca9/azyIg7Hn7bFvw4hTDyUoyq0gWqkixpJgEhjPVxJDt0dcoaMz6Sm/Pnd7S3HtIOac4Aoo69vydA5Gd5YeXmCZJlq+Zs/u8iX/EpfzIq2a7VeNxXQUfu4V7Q29BP3f91NrmJDcm1dmtLi+WzzsTaP9FMd2s4jzD2avJ2qaqOEU6ktWxBtzmovIREN/VJzNJYznf+1n61d0JDFs34hVlzONmu/NN2m2O+uyTcBXuQAcJmzSKX5C5SZBrRqC8R51cTxzVxyP/8Q8LLHLMdJDE1xsS0R67mmq09wg8bwQSRrdMmT4pCXKnWgEFkQ9eevVU/iMSM33fMBUJzqFjhZaTYFS7Mn7CtIDhgOasHGBbd5kgsVHsYTdconi/OEZsmoX5I1ufnEemKJ7o5b4xGxaA9/ib59Ao38GYL858YbdiLCabA4/Q3a7hOlvdQV2GxkgajFdVU8rrErWveDaDk2+N1vBuQAKcob1m2spm15SL1DN/vcve06qLI3kRm84ipW8H/ZXG1jSeq/sDwx/T7E72Y5ym0zwzwbdPMLJNV9WLRms2gI9S/hjULG9jj5N4KH8VsI3+aMG6KjPy7H3/o1Oke5 X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966006)(36840700001)(6666004)(70586007)(47076005)(110136005)(70206006)(7636003)(8676002)(6286002)(36756003)(478600001)(8936002)(26005)(316002)(36906005)(34020700004)(36860700001)(7696005)(82310400003)(426003)(4326008)(356005)(186003)(83380400001)(107886003)(2906002)(1076003)(16526019)(336012)(86362001)(5660300002)(2616005)(55016002)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 13:54:14.6539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 541c1623-0022-477d-f532-08d8e3cbfdc1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3497 Subject: [dpdk-dev] [PATCH v3 3/7] app/flow-perf: fix naming of CPU used structured data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" create_flow and create_meter are not correct names since those are records that contain creation and deletion, which makes them more of a record for such data. Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: dongzhou@nvidia.com Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index 4054178273..01607881df 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -105,8 +105,8 @@ struct used_cpu_time { struct multi_cores_pool { uint32_t cores_count; uint32_t rules_count; - struct used_cpu_time create_meter; - struct used_cpu_time create_flow; + struct used_cpu_time meters_record; + struct used_cpu_time flows_record; int64_t last_alloc[RTE_MAX_LCORE]; int64_t current_alloc[RTE_MAX_LCORE]; } __rte_cache_aligned; @@ -1013,10 +1013,10 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops) cpu_time_used, insertion_rate); if (ops == METER_CREATE) - mc_pool.create_meter.insertion[port_id][core_id] + mc_pool.meters_record.insertion[port_id][core_id] = cpu_time_used; else - mc_pool.create_meter.deletion[port_id][core_id] + mc_pool.meters_record.deletion[port_id][core_id] = cpu_time_used; } @@ -1134,7 +1134,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list) printf(":: Port %d :: Core %d :: The time for deleting %d rules is %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.deletion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.deletion[port_id][core_id] = cpu_time_used; } static struct rte_flow ** @@ -1241,7 +1241,7 @@ insert_flows(int port_id, uint8_t core_id) printf(":: Port %d :: Core %d :: The time for creating %d in rules %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.insertion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.insertion[port_id][core_id] = cpu_time_used; return flows_list; } @@ -1439,9 +1439,9 @@ run_rte_flow_handler_cores(void *data __rte_unused) RTE_ETH_FOREACH_DEV(port) { if (has_meter()) dump_used_cpu_time("Meters:", - port, &mc_pool.create_meter); + port, &mc_pool.meters_record); dump_used_cpu_time("Flows:", - port, &mc_pool.create_flow); + port, &mc_pool.flows_record); dump_used_mem(port); }