From patchwork Thu Mar 11 06:36:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yu, DapengX" X-Patchwork-Id: 88923 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18615A056A; Thu, 11 Mar 2021 07:37:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D74322A2EF; Thu, 11 Mar 2021 07:37:09 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 655D54003D; Thu, 11 Mar 2021 07:37:07 +0100 (CET) IronPort-SDR: sr44CE6/ynC1uIICrK1io7jMWBNrqn+zFHWQu/JgEZBmenoH5pa/+aIkHMIN9FP4YRwtW64t+z MAqOp/4TZ26w== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="273660508" X-IronPort-AV: E=Sophos;i="5.81,239,1610438400"; d="scan'208";a="273660508" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 22:37:05 -0800 IronPort-SDR: YSnzhRyuKZ2TS0eSV4uaUvkjKUti5SpQR5fWHDtRiAjEHnam4JhAz0ytu0oH2BZP+udL9QQDYx xNOtLu0VEH7g== X-IronPort-AV: E=Sophos;i="5.81,239,1610438400"; d="scan'208";a="448185652" Received: from unknown (HELO localhost.localdomain) ([10.240.183.93]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 22:37:03 -0800 From: dapengx.yu@intel.com To: reshma.pattan@intel.com Cc: dev@dpdk.org, Dapeng Yu , stable@dpdk.org Date: Thu, 11 Mar 2021 14:36:54 +0800 Message-Id: <20210311063654.233157-1-dapengx.yu@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] examples/packet_ordering: use local port config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dapeng Yu A global ethernet port configuration is assigned to local variable because in this way the local variable may be updated as required. But this local variable is not used as input of rte_eth_dev_configure() in original implementation, and cause that fast mbuf free feature cannot be enabled on port. This patch use this local variable as input of rte_eth_dev_configure(). Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API") Cc: stable@dpdk.org Signed-off-by: Dapeng Yu Acked-by: Reshma Pattan --- examples/packet_ordering/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index 4bea1982d..963b11d6d 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c @@ -290,7 +290,7 @@ configure_eth_port(uint16_t port_id) if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MBUF_FAST_FREE; - ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf_default); + ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf); if (ret != 0) return ret;