[RFC,03/14] build: correct indentation in list of libs
Checks
Commit Message
With the lib/meson.build file changed from C-style indentation to
python-style indentation, we need to correct the indentation of the lists
of libraries, since these libs were not modified in the previous patches.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/meson.build | 72 ++++++++++++++++++++++++-------------------------
1 file changed, 36 insertions(+), 36 deletions(-)
Comments
01/04/2021 13:49, Bruce Richardson:
> With the lib/meson.build file changed from C-style indentation to
> python-style indentation, we need to correct the indentation of the lists
> of libraries, since these libs were not modified in the previous patches.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> + 'kvargs', # eal depends on kvargs
> + 'telemetry', # basic info querying
> + 'eal', # everything depends on eal
> + 'ring',
> + 'rcu', # rcu depends on ring
> + 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core
> + 'cmdline',
> + 'metrics', # bitrate/latency stats depends on this
> + 'hash', # efd depends on this
> + 'timer', # eventdev depends on this
> + 'acl', 'bbdev', 'bitratestats', 'cfgfile',
> + 'compressdev', 'cryptodev',
> + 'distributor', 'efd', 'eventdev',
> + 'gro', 'gso', 'ip_frag', 'jobstats',
> + 'kni', 'latencystats', 'lpm', 'member',
> + 'power', 'pdump', 'rawdev', 'regexdev',
> + 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost',
> + # ipsec lib depends on net, crypto and security
> + 'ipsec',
> + #fib lib depends on rib
space missing
> + 'fib',
> + # add pkt framework libs which use other libs from above
> + 'port', 'table', 'pipeline',
> + # flow_classify lib depends on pkt framework table lib
> + 'flow_classify', 'bpf', 'graph', 'node']
Some may deserve to be on their own line.
On Thu, Apr 01, 2021 at 03:30:24PM +0200, Thomas Monjalon wrote:
> 01/04/2021 13:49, Bruce Richardson:
> > With the lib/meson.build file changed from C-style indentation to
> > python-style indentation, we need to correct the indentation of the lists
> > of libraries, since these libs were not modified in the previous patches.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > + 'kvargs', # eal depends on kvargs
> > + 'telemetry', # basic info querying
> > + 'eal', # everything depends on eal
> > + 'ring',
> > + 'rcu', # rcu depends on ring
> > + 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core
> > + 'cmdline',
> > + 'metrics', # bitrate/latency stats depends on this
> > + 'hash', # efd depends on this
> > + 'timer', # eventdev depends on this
> > + 'acl', 'bbdev', 'bitratestats', 'cfgfile',
> > + 'compressdev', 'cryptodev',
> > + 'distributor', 'efd', 'eventdev',
> > + 'gro', 'gso', 'ip_frag', 'jobstats',
> > + 'kni', 'latencystats', 'lpm', 'member',
> > + 'power', 'pdump', 'rawdev', 'regexdev',
> > + 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost',
> > + # ipsec lib depends on net, crypto and security
> > + 'ipsec',
> > + #fib lib depends on rib
>
> space missing
>
> > + 'fib',
> > + # add pkt framework libs which use other libs from above
> > + 'port', 'table', 'pipeline',
> > + # flow_classify lib depends on pkt framework table lib
> > + 'flow_classify', 'bpf', 'graph', 'node']
>
> Some may deserve to be on their own line.
>
Maybe put them all on their own line, or would just just be too long a
list?
@@ -9,44 +9,44 @@
# given as a dep, no need to mention ring. This is especially true for the
# core libs which are widely reused, so their deps are kept to a minimum.
libraries = [
- 'kvargs', # eal depends on kvargs
- 'telemetry', # basic info querying
- 'eal', # everything depends on eal
- 'ring',
- 'rcu', # rcu depends on ring
- 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core
- 'cmdline',
- 'metrics', # bitrate/latency stats depends on this
- 'hash', # efd depends on this
- 'timer', # eventdev depends on this
- 'acl', 'bbdev', 'bitratestats', 'cfgfile',
- 'compressdev', 'cryptodev',
- 'distributor', 'efd', 'eventdev',
- 'gro', 'gso', 'ip_frag', 'jobstats',
- 'kni', 'latencystats', 'lpm', 'member',
- 'power', 'pdump', 'rawdev', 'regexdev',
- 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost',
- # ipsec lib depends on net, crypto and security
- 'ipsec',
- #fib lib depends on rib
- 'fib',
- # add pkt framework libs which use other libs from above
- 'port', 'table', 'pipeline',
- # flow_classify lib depends on pkt framework table lib
- 'flow_classify', 'bpf', 'graph', 'node']
+ 'kvargs', # eal depends on kvargs
+ 'telemetry', # basic info querying
+ 'eal', # everything depends on eal
+ 'ring',
+ 'rcu', # rcu depends on ring
+ 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core
+ 'cmdline',
+ 'metrics', # bitrate/latency stats depends on this
+ 'hash', # efd depends on this
+ 'timer', # eventdev depends on this
+ 'acl', 'bbdev', 'bitratestats', 'cfgfile',
+ 'compressdev', 'cryptodev',
+ 'distributor', 'efd', 'eventdev',
+ 'gro', 'gso', 'ip_frag', 'jobstats',
+ 'kni', 'latencystats', 'lpm', 'member',
+ 'power', 'pdump', 'rawdev', 'regexdev',
+ 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost',
+ # ipsec lib depends on net, crypto and security
+ 'ipsec',
+ #fib lib depends on rib
+ 'fib',
+ # add pkt framework libs which use other libs from above
+ 'port', 'table', 'pipeline',
+ # flow_classify lib depends on pkt framework table lib
+ 'flow_classify', 'bpf', 'graph', 'node']
if is_windows
- libraries = [
- 'kvargs',
- 'telemetry',
- 'eal',
- 'ring',
- 'rcu',
- 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci',
- 'cmdline',
- 'hash',
- 'cfgfile',
- ] # only supported libraries for windows
+ libraries = [
+ 'kvargs',
+ 'telemetry',
+ 'eal',
+ 'ring',
+ 'rcu',
+ 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci',
+ 'cmdline',
+ 'hash',
+ 'cfgfile',
+ ] # only supported libraries for windows
endif
default_cflags = machine_args