From patchwork Tue Apr 20 04:08:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalesh A P X-Patchwork-Id: 91812 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A2C5A0524; Tue, 20 Apr 2021 05:46:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96ED34159C; Tue, 20 Apr 2021 05:46:56 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com [192.19.11.229]) by mails.dpdk.org (Postfix) with ESMTP id 7FD2E41598 for ; Tue, 20 Apr 2021 05:46:55 +0200 (CEST) Received: from dhcp-10-123-153-22.dhcp.broadcom.net (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id D65587DA7; Mon, 19 Apr 2021 20:46:53 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com D65587DA7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1618890414; bh=Wgt6S6hOw/MODKgZsFoKXrMz2V/Yl2DZd0Y1OUVVLy4=; h=From:To:Cc:Subject:Date:From; b=d2M5i0NWBEbLI+JaQZWkyp2hrrQPjm5ZZfdETCZaN8OSx9npdvHh2d2wTzXUmwu78 fiQxZsjUAUEr/hBeGq2FIPv5X6bEVkAAY/ZnEokOnnWCp7LkaFYOoIf8aB9LPj5Q5r 6qZydtW5Q5LeJZyDgEXQYsEyrMebL3N0shj2D+Oc= From: Kalesh A P To: dev@dpdk.org Cc: ferruh.yigit@intel.com, ajit.khaparde@broadcom.com Date: Tue, 20 Apr 2021 09:38:45 +0530 Message-Id: <20210420040845.28725-1-kalesh-anakkur.purayil@broadcom.com> X-Mailer: git-send-email 2.10.1 Subject: [dpdk-dev] [PATCH] net/bnxt: fix cancelling health check alarm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP Driver cancels the health check alarm only if error recovery is enabled in the FW. This can cause an issue. There is a small window where the driver receives the async event from fw and port close is invoked immediately. Driver clears BNXT_FLAG_RECOVERY_ENABLED flag when it gets the async event from FW. As a result, the health check alarm will not get canceled during port close and causes a segfault when the alarm tries to read Heartbeat register. Fix this by cancelling the health check alarm unconditionally during port stop. Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 9da817f..f5d2dc8 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4274,9 +4274,6 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp) static void bnxt_cancel_fw_health_check(struct bnxt *bp) { - if (!bnxt_is_recovery_enabled(bp)) - return; - rte_eal_alarm_cancel(bnxt_check_fw_health, (void *)bp); bp->flags &= ~BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED; }