[v3,1/4] mbuf: mark old offload flag as deprecated
Checks
Commit Message
PKT_RX_EIP_CKSUM_BAD has been declared deprecated but there was no
warning to applications still using it.
Fix this by marking as deprecated with the newly introduced
RTE_DEPRECATED.
Fixes: e8a419d6de4b ("mbuf: rename outer IP checksum macro")
Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Flavio Leitner <fbl@sysclose.org>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Lance Richardson <lance.richardson@broadcom.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
Changes since v1:
- updated commitlog following Olivier comment,
---
lib/mbuf/rte_mbuf_core.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 5/3/21 3:26 PM, David Marchand wrote:
> PKT_RX_EIP_CKSUM_BAD has been declared deprecated but there was no
> warning to applications still using it.
> Fix this by marking as deprecated with the newly introduced
> RTE_DEPRECATED.
>
> Fixes: e8a419d6de4b ("mbuf: rename outer IP checksum macro")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Flavio Leitner <fbl@sysclose.org>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Lance Richardson <lance.richardson@broadcom.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> Changes since v1:
> - updated commitlog following Olivier comment,
>
> ---
> lib/mbuf/rte_mbuf_core.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
On Mon, May 3, 2021 at 3:27 PM David Marchand <david.marchand@redhat.com> wrote:
>
> PKT_RX_EIP_CKSUM_BAD has been declared deprecated but there was no
> warning to applications still using it.
> Fix this by marking as deprecated with the newly introduced
> RTE_DEPRECATED.
>
> Fixes: e8a419d6de4b ("mbuf: rename outer IP checksum macro")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Flavio Leitner <fbl@sysclose.org>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Lance Richardson <lance.richardson@broadcom.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied to the main branch.
The rest of the series will go through next-virtio.
@@ -83,7 +83,8 @@ extern "C" {
* Deprecated.
* This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead.
*/
-#define PKT_RX_EIP_CKSUM_BAD PKT_RX_OUTER_IP_CKSUM_BAD
+#define PKT_RX_EIP_CKSUM_BAD \
+ RTE_DEPRECATED(PKT_RX_EIP_CKSUM_BAD) PKT_RX_OUTER_IP_CKSUM_BAD
/**
* A vlan has been stripped by the hardware and its tci is saved in