[v1] net/ice: fix wrong FDIR flow type for IPv4 fragment
Checks
Commit Message
When creating FDIR rule and parsing the pattern, if IPv4 fragment type is
detected, the flow type is not changed to ICE_FLTR_PTYPE_FRAG_IPV4 from
ICE_FLTR_PTYPE_NONF_IPV4_OTHER. It will cause profile confilict with
other FDIR rules for IPv4 other type.
Fixes: b7e8781de768 ("net/ice: support flow director for IP fragment packet")
Cc: stable@dpdk.org
Signed-off-by: Ting Xu <ting.xu@intel.com>
---
drivers/net/ice/ice_fdir_filter.c | 1 +
1 file changed, 1 insertion(+)
Comments
> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Wednesday, June 2, 2021 4:21 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Xu, Ting <ting.xu@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] net/ice: fix wrong FDIR flow type for IPv4 fragment
>
> When creating FDIR rule and parsing the pattern, if IPv4 fragment type is
> detected, the flow type is not changed to ICE_FLTR_PTYPE_FRAG_IPV4 from
> ICE_FLTR_PTYPE_NONF_IPV4_OTHER. It will cause profile confilict with other
> FDIR rules for IPv4 other type.
>
> Fixes: b7e8781de768 ("net/ice: support flow director for IP fragment packet")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ting Xu <ting.xu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -1780,6 +1780,7 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
* ethertype, if the spec is for all valid
* packet id, set ethertype into input set.
*/
+ flow_type = ICE_FLTR_PTYPE_FRAG_IPV4;
*input_set |= ICE_INSET_ETHERTYPE;
input_set_o |= ICE_INSET_ETHERTYPE;
} else if (ipv4_mask->hdr.packet_id == UINT16_MAX) {